-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infineon p6 all clusters update #19245
Merged
andy31415
merged 1 commit into
project-chip:master
from
keithmwheeler:infineon-p6-all-clusters-update
Jun 9, 2022
Merged
Infineon p6 all clusters update #19245
andy31415
merged 1 commit into
project-chip:master
from
keithmwheeler:infineon-p6-all-clusters-update
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
requested changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be making changes to the EFR32 SDK or the ZAP repo... and probably not to mbedtls.
examples/chip-tool/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
keithmwheeler
force-pushed
the
infineon-p6-all-clusters-update
branch
from
June 7, 2022 16:31
58cbbff
to
17ff172
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
June 7, 2022 16:31
pullapprove
bot
requested review from
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 7, 2022 16:31
bzbarsky-apple
approved these changes
Jun 8, 2022
PR #19245: Size comparison from 8cc291d to 17ff172 Decreases (1 build for nrfconnect)
Full report (2 builds for nrfconnect)
|
bzbarsky-apple
approved these changes
Jun 8, 2022
andy31415
approved these changes
Jun 9, 2022
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixed commissioning issue with all clusters; updated network commissioning wifi driver with needed lock/unlock sequences.
Change overview
Updated P6 all clusters and all clusters minimal apptask to support commissioning only on endpoint 0. Added necessary lock/unlock calls to P6 network commissioning wifi driver.
Testing
Tested by commissioning both all clusters and all clusters minimal on P6 hardware.