Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Fixed a timer issue on WindowApp #19224

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[nrfconnect] Fixed a timer issue on WindowApp #19224

merged 1 commit into from
Jun 9, 2022

Conversation

ArekBalysNordic
Copy link
Contributor

Problem

Nrfconnect WindowApp example fell into a hard fault
after receiving windowcovering commands from a chip-tool.

Change overview

Moved the application timer's invocation to SystemLayer because previously,
it was called from an ISR context, and it caused a hard fault.
Added also DFU SMP to the WindowApp example and set proper pins to PWM.

Testing

Tested manually on nrf53 and nrf52

@ArekBalysNordic ArekBalysNordic force-pushed the window_covering_timer_fix branch from 75eed42 to ca76475 Compare June 6, 2022 11:55
@github-actions
Copy link

github-actions bot commented Jun 6, 2022 •
edited
Loading

PR #19224: Size comparison from 0ef4a9d to ca76475

Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0ef4a9d ca76475 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651579 651579 0 0.0
(read/write) 158924 158924 0 0.0
.bss 74604 74604 0 0.0
.data 3404 3404 0 0.0
.rodata 85523 85523 0 0.0
.text 565824 565824 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617595 617595 0 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74955 74955 0 0.0
.text 542408 542408 0 0.0
lock-ftd LP_CC2652R7 (read only) 682967 682967 0 0.0
(read/write) 159864 159864 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97671 97671 0 0.0
.text 584816 584816 0 0.0
lock-mtd LP_CC2652R7 (read only) 632367 632367 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97551 97551 0 0.0
.text 534328 534328 0 0.0
pump-app LP_CC2652R7 (read only) 664079 664079 0 0.0
(read/write) 179656 179656 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577752 577752 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655151 655151 0 0.0
(read/write) 188696 188696 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570776 570776 0 0.0
shell LP_CC2652R7 (read only) 644602 644602 0 0.0
(read/write) 154480 154480 0 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 82506 82506 0 0.0
.text 561860 561860 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602110 602110 0 0.0
.app_xip_area 461136 461136 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599218 599218 0 0.0
.app_xip_area 458108 458108 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596890 596890 0 0.0
.app_xip_area 456912 456912 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916016 916016 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916008 916008 0 0.0
BRD4161A+rpc (read only) 950244 950244 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950236 950236 0 0.0
BRD4161A+rs911x (read only) 791228 791228 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791220 791220 0 0.0
lock-app BRD4161A+wf200 (read only) 958092 958092 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958084 958084 0 0.0
window-app BRD4161A (read only) 901056 901056 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901048 901048 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007688 1007688 0 0.0
(read/write) 1481482 1481482 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212232 212232 0 0.0
.flash.text 1007688 1007688 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062651 1062651 0 0.0
(read/write) 483652 483652 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242768 242768 0 0.0
.flash.text 1057267 1057267 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653284 653284 0 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575508 575508 0 0.0
lock k32w061+release (read/write) 714304 714304 0 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636116 636116 0 0.0
linux all-clusters-app debug (read only) 2778041 2778041 0 0.0
(read/write) 178568 178568 0 0.0
.bss 86368 86368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 246205 246205 0 0.0
.text 2357954 2357954 0 0.0
all-clusters-minimal-app debug (read only) 2653601 2653601 0 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2233058 2233058 0 0.0
bridge-app debug+rpc (read only) 2031129 2031129 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704786 1704786 0 0.0
chip-tool debug (read only) 9670269 9670269 0 0.0
(read/write) 611152 611152 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 579760 579760 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497021 497021 0 0.0
.text 7760613 7760613 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9421684 9421684 0 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460900 460900 0 0.0
.text 7413172 7413172 0 0.0
lighting-app debug+rpc (read only) 2321385 2321385 0 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966866 1966866 0 0.0
lock-app debug (read only) 2264753 2264753 0 0.0
(read/write) 148768 148768 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 68008 68008 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1901346 1901346 0 0.0
ota-provider-app debug (read only) 2066897 2066897 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726562 1726562 0 0.0
ota-requestor-app debug (read only) 2094705 2094705 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756994 1756994 0 0.0
shell debug (read only) 2582881 2582881 0 0.0
(read/write) 201976 201976 0 0.0
.bss 117224 117224 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77624 77624 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 226258 226258 0 0.0
.text 2197250 2197250 0 0.0
thermostat-no-ble arm64 (read only) 2367844 2367844 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148820 148820 0 0.0
.text 1989344 1989344 0 0.0
tv-app debug (read only) 2879649 2879649 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223136 223136 0 0.0
.text 2473906 2473906 0 0.0
tv-casting-app debug (read only) 5329161 5329161 0 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337536 337536 0 0.0
.text 4640434 4640434 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427200 2427200 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389844 1389844 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191407 1191407 0 0.0
bss 141297 141297 0 0.0
rodata 154232 154232 0 0.0
text 817008 817008 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139127 1139127 0 0.0
bss 140514 140514 0 0.0
rodata 130744 130744 0 0.0
text 789056 789056 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1152679 1152679 0 0.0
bss 143871 143871 0 0.0
rodata 121344 121344 0 0.0
text 808656 808656 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1120047 1120047 0 0.0
bss 144112 144112 0 0.0
rodata 112856 112856 0 0.0
text 783816 783816 0 0.0
nrf52840dongle_nrf52840 (read/write) 1059151 1059151 0 0.0
bss 151102 151102 0 0.0
rodata 90416 90416 0 0.0
text 736564 736564 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1056462 1056462 0 0.0
bss 140242 140242 0 0.0
rodata 113764 113764 0 0.0
text 721388 721388 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1104519 1104519 0 0.0
bss 133800 133800 0 0.0
rodata 137896 137896 0 0.0
text 754000 754000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1008430 1008430 0 0.0
bss 130203 130203 0 0.0
rodata 130380 130380 0 0.0
text 666796 666796 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1065271 1065271 0 0.0
bss 133782 133782 0 0.0
rodata 114552 114552 0 0.0
text 738040 738040 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058355 1058355 0 0.0
bss 133559 133559 0 0.0
rodata 113580 113580 0 0.0
text 732364 732364 0 0.0
p6 all-clusters-app default (read/write) 2545624 2545624 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503888 1503888 0 0.0
all-clusters-minimal-app default (read/write) 2490488 2490488 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448752 1448752 0 0.0
light-app default (read/write) 2422368 2422368 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380632 1380632 0 0.0
lock-app default (read/write) 2442728 2442728 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400992 1400992 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780916 780916 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552312 552312 0 0.0
lighting-app tlsr9518adk80d (read/write) 800960 800960 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569054 569054 0 0.0

jmeg-sfy
jmeg-sfy requested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@jmeg-sfy jmeg-sfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review comments

@ArekBalysNordic ArekBalysNordic force-pushed the window_covering_timer_fix branch from ca76475 to a1ebc68 Compare June 7, 2022 08:40
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19224: Size comparison from 55ab764 to a1ebc68

Full report (14 builds for cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 55ab764 a1ebc68 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602242 0 0.0
.app_xip_area 461268 461268 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599294 0 0.0
.app_xip_area 458184 458184 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596910 0 0.0
.app_xip_area 456932 456932 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 653400 653400 0 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575624 0 0.0
lock k32w061+release (read/write) 714380 714380 0 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636192 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409764 0 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412116 0 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545728 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503992 0 0.0
all-clusters-minimal-app default (read/write) 2490592 2490592 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448856 0 0.0
light-app default (read/write) 2422488 2422488 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380752 0 0.0
lock-app default (read/write) 2442808 2442808 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401072 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781016 781016 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552406 552406 0 0.0
lighting-app tlsr9518adk80d (read/write) 801052 801052 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569148 569148 0 0.0

@ArekBalysNordic
Copy link
Contributor Author

@jmeg-sfy I passed the argument for Tilt/Lift within the pointer as you suggested. What do you think right now?

@ArekBalysNordic ArekBalysNordic force-pushed the window_covering_timer_fix branch from b098085 to 1a3c428 Compare June 7, 2022 09:28
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19224: Size comparison from 55ab764 to 1a3c428

Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 55ab764 1a3c428 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689547 689547 0 0.0
(read/write) 162220 162220 0 0.0
.bss 74660 74660 0 0.0
.data 3404 3404 0 0.0
.rodata 111787 111787 0 0.0
.text 577444 577444 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640171 640171 0 0.0
(read/write) 158136 158136 0 0.0
.bss 73876 73876 0 0.0
.data 3344 3344 0 0.0
.rodata 88827 88827 0 0.0
.text 551020 551020 0 0.0
lock-ftd LP_CC2652R7 (read only) 683027 683027 0 0.0
(read/write) 159804 159804 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97651 97651 0 0.0
.text 584896 584896 0 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632435 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97531 97531 0 0.0
.text 534416 534416 0 0.0
pump-app LP_CC2652R7 (read only) 664099 664099 0 0.0
(read/write) 179636 179636 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85851 85851 0 0.0
.text 577768 577768 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655259 0 0.0
(read/write) 188588 188588 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83899 83899 0 0.0
.text 570880 570880 0 0.0
shell LP_CC2652R7 (read only) 681842 681842 0 0.0
(read/write) 165420 165420 0 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 108394 108394 0 0.0
.text 573132 573132 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602242 0 0.0
.app_xip_area 461268 461268 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599294 0 0.0
.app_xip_area 458184 458184 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596910 0 0.0
.app_xip_area 456932 456932 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916152 916152 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916144 916144 0 0.0
BRD4161A+rpc (read only) 950380 950380 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950372 950372 0 0.0
BRD4161A+rs911x (read only) 791364 791364 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791356 791356 0 0.0
lock-app BRD4161A+wf200 (read only) 958152 958152 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958144 958144 0 0.0
window-app BRD4161A (read only) 901208 901208 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901200 901200 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007798 0 0.0
(read/write) 1481490 1481490 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212240 212240 0 0.0
.flash.text 1007798 1007798 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062743 1062743 0 0.0
(read/write) 483660 483660 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242776 242776 0 0.0
.flash.text 1057359 1057359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653400 653400 0 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575624 0 0.0
lock k32w061+release (read/write) 714380 714380 0 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636192 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409764 0 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412116 0 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191507 0 0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139227 0 0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789152 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1152811 1152811 0 0.0
bss 143871 143871 0 0.0
rodata 121348 121348 0 0.0
text 808776 808776 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1120179 1120179 0 0.0
bss 144112 144112 0 0.0
rodata 112860 112860 0 0.0
text 783940 783940 0 0.0
nrf52840dongle_nrf52840 (read/write) 1059283 1059283 0 0.0
bss 151102 151102 0 0.0
rodata 90420 90420 0 0.0
text 736684 736684 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1056578 1056578 0 0.0
bss 140242 140242 0 0.0
rodata 113768 113768 0 0.0
text 721512 721512 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1104595 1104595 0 0.0
bss 133799 133799 0 0.0
rodata 137876 137876 0 0.0
text 754096 754096 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1008506 1008506 0 0.0
bss 130202 130202 0 0.0
rodata 130360 130360 0 0.0
text 666892 666892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1065291 1065291 0 0.0
bss 133782 133782 0 0.0
rodata 114556 114556 0 0.0
text 738064 738064 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058471 1058471 0 0.0
bss 133559 133559 0 0.0
rodata 113584 113584 0 0.0
text 732484 732484 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545728 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503992 0 0.0
all-clusters-minimal-app default (read/write) 2490592 2490592 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448856 0 0.0
light-app default (read/write) 2422488 2422488 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380752 0 0.0
lock-app default (read/write) 2442808 2442808 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401072 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781016 781016 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552406 552406 0 0.0
lighting-app tlsr9518adk80d (read/write) 801052 801052 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569148 569148 0 0.0

@ArekBalysNordic ArekBalysNordic force-pushed the window_covering_timer_fix branch from 1a3c428 to 6cb1b77 Compare June 8, 2022 10:32
@restyled-io restyled-io bot mentioned this pull request Jun 8, 2022
Closed
@ArekBalysNordic
[nrfconnect] Fixed a timer problem on WindowApp
075e438 
Nrfconnect WindowApp example fell into a hard fault
after receiving `windowcovering` commands from a chip-tool.
Moved the application timer's invocation to SystemLayer because previously,
it was called from ISR, and it caused a hard fault.
Added also DFU SMP to the example and set proper pins to PWM.
@ArekBalysNordic ArekBalysNordic force-pushed the window_covering_timer_fix branch from 6cb1b77 to 075e438 Compare June 8, 2022 10:34
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19224: Size comparison from b8e9ab1 to 075e438

Increases (2 builds for nrfconnect, telink)
platform target config section b8e9ab1 075e438 change % change
nrfconnect lighting-app nrf5340dk_nrf5340_cpuapp text 721472 721476 4 0.0
telink lighting-app tlsr9518adk80d text 569270 569272 2 0.0
Decreases (3 builds for esp32, nrfconnect)
platform target config section b8e9ab1 075e438 change % change
esp32 all-clusters-app c3devkit (read only) 1007708 1007704 -4 -0.0
.flash.text 1007708 1007704 -4 -0.0
nrfconnect lock-app nrf52840dk_nrf52840 text 754084 754080 -4 -0.0
nrf5340dk_nrf5340_cpuapp text 666880 666876 -4 -0.0
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b8e9ab1 075e438 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689863 689863 0 0.0
(read/write) 161904 161904 0 0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112279 112279 0 0.0
.text 577272 577272 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640479 640479 0 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89319 89319 0 0.0
.text 550840 550840 0 0.0
lock-ftd LP_CC2652R7 (read only) 683375 683375 0 0.0
(read/write) 159456 159456 0 0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98143 98143 0 0.0
.text 584748 584748 0 0.0
lock-mtd LP_CC2652R7 (read only) 632791 632791 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98031 98031 0 0.0
.text 534268 534268 0 0.0
pump-app LP_CC2652R7 (read only) 664819 664819 0 0.0
(read/write) 178924 178924 0 0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86315 86315 0 0.0
.text 578020 578020 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655403 655403 0 0.0
(read/write) 188444 188444 0 0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84211 84211 0 0.0
.text 570708 570708 0 0.0
shell LP_CC2652R7 (read only) 682142 682142 0 0.0
(read/write) 165120 165120 0 0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108878 108878 0 0.0
.text 572952 572952 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602546 0 0.0
.app_xip_area 461492 461492 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599630 599630 0 0.0
.app_xip_area 458440 458440 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599374 599374 0 0.0
.app_xip_area 459300 459300 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914968 914968 0 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 914960 914960 0 0.0
BRD4161A+rpc (read only) 949188 949188 0 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949180 949180 0 0.0
BRD4161A+rs911x (read only) 790156 790156 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790148 790148 0 0.0
lock-app BRD4161A+wf200 (read only) 958396 958396 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958388 958388 0 0.0
window-app BRD4161A (read only) 900040 900040 0 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900032 900032 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007708 1007704 -4 -0.0
(read/write) 1481786 1481786 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212536 212536 0 0.0
.flash.text 1007708 1007704 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062479 1062479 0 0.0
(read/write) 483928 483928 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243044 243044 0 0.0
.flash.text 1057095 1057095 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653744 653744 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575896 575896 0 0.0
lock k32w061+release (read/write) 714788 714788 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636528 636528 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9474604 9474604 0 0.0
(read/write) 674257 674257 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14928 14928 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 467548 0 0.0
.text 7470052 7470052 0 0.0
thermostat-no-ble arm64 (read only) 2543900 2543900 0 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160084 160084 0 0.0
.text 2146880 2146880 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429544 2429544 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392188 1392188 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191959 1191959 0 0.0
bss 141362 141362 0 0.0
rodata 154600 154600 0 0.0
text 817076 817076 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139683 1139683 0 0.0
bss 140579 140579 0 0.0
rodata 131092 131092 0 0.0
text 789128 789128 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1153243 1153243 0 0.0
bss 143936 143936 0 0.0
rodata 121692 121692 0 0.0
text 808748 808748 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1120639 1120639 0 0.0
bss 144177 144177 0 0.0
rodata 113208 113208 0 0.0
text 783920 783920 0 0.0
nrf52840dongle_nrf52840 (read/write) 1059595 1059595 0 0.0
bss 151167 151167 0 0.0
rodata 90764 90764 0 0.0
text 736652 736652 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1056950 1056950 0 0.0
bss 140307 140307 0 0.0
rodata 114116 114116 0 0.0
text 721472 721476 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1104919 1104919 0 0.0
bss 133864 133864 0 0.0
rodata 138224 138224 0 0.0
text 754084 754080 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1008910 1008910 0 0.0
bss 130267 130267 0 0.0
rodata 130708 130708 0 0.0
text 666880 666876 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1066227 1066227 0 0.0
bss 133847 133847 0 0.0
rodata 115060 115060 0 0.0
text 738484 738484 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058811 1058811 0 0.0
bss 133624 133624 0 0.0
rodata 113932 113932 0 0.0
text 732472 732472 0 0.0
p6 all-clusters-app default (read/write) 2544464 2544464 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502728 1502728 0 0.0
all-clusters-minimal-app default (read/write) 2489328 2489328 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447592 1447592 0 0.0
light-app default (read/write) 2421240 2421240 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379504 1379504 0 0.0
lock-app default (read/write) 2441576 2441576 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399840 1399840 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781628 781628 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552550 552550 0 0.0
lighting-app tlsr9518adk80d (read/write) 801640 801640 0 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569270 569272 2 0.0

@Damian-Nordic Damian-Nordic merged commit de9e907 into project-chip:master Jun 9, 2022
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@ArekBalysNordic @mkardous-silabs
[nrfconnect] Fixed a timer problem on WindowApp (project-chip#19224)
77e1d2d 
Nrfconnect WindowApp example fell into a hard fault
after receiving `windowcovering` commands from a chip-tool.
Moved the application timer's invocation to SystemLayer because previously,
it was called from ISR, and it caused a hard fault.
Added also DFU SMP to the example and set proper pins to PWM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@markaj-nordic markaj-nordic markaj-nordic approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ArekBalysNordic @andy31415 @mrjerryjohns @Damian-Nordic @jmeg-sfy @markaj-nordic