Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thread] use MLE Discovery mechanism instead of active scanning #19200

Merged
merged 1 commit into from
Jun 10, 2022
Merged

[thread] use MLE Discovery mechanism instead of active scanning #19200

merged 1 commit into from
Jun 10, 2022

Conversation

LuDuda
Copy link
Contributor

@LuDuda LuDuda commented Jun 3, 2022 •
edited
Loading

Problem

The current implementation of ScanNetworks command for Thread uses legacy 15.4 active scanning. This mechanism does not provide parameters such as Thread Network name or Extended PAN Id.

Change overview

Use MLE Discovery to trigger Thread scanning. Simple API change, the result callback has the same type.

Testing

Tested manually on nRF Connect platform that ScanNetworkResponse includes Network Name and Extended Pan ID over Thread network by executing ./chip-tool networkcommissioning scan-networks 1111 0

[1654725420.491720][119922:119927] CHIP:TOO:   ScanNetworksResponse: {
[1654725420.491797][119922:119927] CHIP:TOO:     networkingStatus: 0
[1654725420.491870][119922:119927] CHIP:TOO:     threadScanResults: 1 entries
[1654725420.491954][119922:119927] CHIP:TOO:       [1]: {
[1654725420.492005][119922:119927] CHIP:TOO:         PanId: 41209
[1654725420.492054][119922:119927] CHIP:TOO:         ExtendedPanId: 2944460015548818066
[1654725420.492103][119922:119927] CHIP:TOO:         NetworkName: OpenThread-a0f9
[1654725420.492149][119922:119927] CHIP:TOO:         Channel: 21
[1654725420.492195][119922:119927] CHIP:TOO:         Version: 3
[1654725420.492244][119922:119927] CHIP:TOO:         ExtendedAddress: 82B8FBEB54F3DAC3
[1654725420.492291][119922:119927] CHIP:TOO:         Rssi: -66
[1654725420.492337][119922:119927] CHIP:TOO:         Lqi: 108
[1654725420.492385][119922:119927] CHIP:TOO:        }
[1654725420.492437][119922:119927] CHIP:TOO:    }

Additionally modified chip-tool locally to send the ScanNetworks command during BLE commissioning, before Thread interface is brought up.

[1654725369.517185][119903:119909] CHIP:DMG: InvokeResponseMessage =
[1654725369.517235][119903:119909] CHIP:DMG: {
[1654725369.517305][119903:119909] CHIP:DMG: 	suppressResponse = false, 
[1654725369.517357][119903:119909] CHIP:DMG: 	InvokeResponseIBs =
[1654725369.517450][119903:119909] CHIP:DMG: 	[
[1654725369.517502][119903:119909] CHIP:DMG: 		InvokeResponseIB =
[1654725369.517607][119903:119909] CHIP:DMG: 		{
[1654725369.517680][119903:119909] CHIP:DMG: 			CommandDataIB =
[1654725369.517749][119903:119909] CHIP:DMG: 			{
[1654725369.517829][119903:119909] CHIP:DMG: 				CommandPathIB =
[1654725369.517900][119903:119909] CHIP:DMG: 				{
[1654725369.517989][119903:119909] CHIP:DMG: 					EndpointId = 0x0,
[1654725369.518069][119903:119909] CHIP:DMG: 					ClusterId = 0x31,
[1654725369.518212][119903:119909] CHIP:DMG: 					CommandId = 0x1,
[1654725369.518303][119903:119909] CHIP:DMG: 				},
[1654725369.518377][119903:119909] CHIP:DMG: 				
[1654725369.518455][119903:119909] CHIP:DMG: 				CommandFields = 
[1654725369.518524][119903:119909] CHIP:DMG: 				{
[1654725369.518613][119903:119909] CHIP:DMG: 					0x0 = 0, 
[1654725369.518702][119903:119909] CHIP:DMG: 					0x3 = [
[1654725369.518781][119903:119909] CHIP:DMG: 						
[1654725369.518878][119903:119909] CHIP:DMG: 						{
[1654725369.518959][119903:119909] CHIP:DMG: 							0x0 = 41209, 
[1654725369.519050][119903:119909] CHIP:DMG: 							0x1 = 2944460015548818066, 
[1654725369.519137][119903:119909] CHIP:DMG: 							0x2 = "OpenThread-a0f9", 
[1654725369.519224][119903:119909] CHIP:DMG: 							0x3 = 21, 
[1654725369.519307][119903:119909] CHIP:DMG: 							0x4 = 3, 
[1654725369.519387][119903:119909] CHIP:DMG: 							0x5 = [
[1654725369.519477][119903:119909] CHIP:DMG: 								0x82, 0xb8, 0xfb, 0xeb, 0x54, 0xf3, 0xda, 0xc3, 
[1654725369.519557][119903:119909] CHIP:DMG: 						]
[1654725369.519631][119903:119909] CHIP:DMG: 							0x6 = -67, 
[1654725369.519755][119903:119909] CHIP:DMG: 							0x7 = 104, 
[1654725369.519835][119903:119909] CHIP:DMG: 						},
[1654725369.519930][119903:119909] CHIP:DMG: 					],
[1654725369.520020][119903:119909] CHIP:DMG: 				},
[1654725369.520091][119903:119909] CHIP:DMG: 			},
[1654725369.520188][119903:119909] CHIP:DMG: 			
[1654725369.520261][119903:119909] CHIP:DMG: 		},
[1654725369.520340][119903:119909] CHIP:DMG: 		
[1654725369.520406][119903:119909] CHIP:DMG: 	],
[1654725369.520473][119903:119909] CHIP:DMG: 	
[1654725369.520515][119903:119909] CHIP:DMG: 	InteractionModelRevision = 1
[1654725369.520555][119903:119909] CHIP:DMG: },

@restyled-io restyled-io bot mentioned this pull request Jun 3, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19200: Size comparison from cb5b1b3 to 34f7a96

Increases (14 builds for cc13x2_26x2, cyw30739, k32w, telink)
platform target config section cb5b1b3 34f7a96 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 650819 651539 720 0.1
.text 565104 565824 720 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 617587 618315 728 0.1
.text 542400 543128 728 0.1
lock-ftd LP_CC2652R7 (read only) 682959 683687 728 0.1
.text 584808 585536 728 0.1
lock-mtd LP_CC2652R7 (read only) 632359 633087 728 0.1
.text 534320 535048 728 0.1
pump-app LP_CC2652R7 (read only) 664063 664783 720 0.1
.text 577736 578456 720 0.1
pump-controller-app LP_CC2652R7 (read only) 655135 655855 720 0.1
.text 570760 571480 720 0.1
shell LP_CC2652R7 (read only) 643850 644578 728 0.1
.text 561140 561868 728 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602102 602862 760 0.1
.app_xip_area 461128 461888 760 0.2
lock cyw930739m2evb_01 (read/write) 599210 599970 760 0.1
.app_xip_area 458100 458860 760 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596874 597626 752 0.1
.app_xip_area 456896 457648 752 0.2
k32w light k32w061+release (read/write) 657976 658760 784 0.1
.bss 69760 69776 16 0.0
.text 580400 581168 768 0.1
lock k32w061+release (read/write) 719204 719988 784 0.1
.bss 70192 70208 16 0.0
.text 641224 641992 768 0.1
telink light-switch-app tlsr9518adk80d (read/write) 780900 781796 896 0.1
text 552296 553120 824 0.1
lighting-app tlsr9518adk80d (read/write) 800944 801840 896 0.1
text 569038 569862 824 0.1
Decreases (3 builds for cc13x2_26x2)
platform target config section cb5b1b3 34f7a96 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 159872 159144 -728 -0.5
pump-app LP_CC2652R7 (read/write) 179672 178952 -720 -0.4
pump-controller-app LP_CC2652R7 (read/write) 188712 187992 -720 -0.4
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section cb5b1b3 34f7a96 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 650819 651539 720 0.1
(read/write) 158916 158916 0 0.0
.bss 74596 74596 0 0.0
.data 3404 3404 0 0.0
.rodata 85483 85483 0 0.0
.text 565104 565824 720 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 617587 618315 728 0.1
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74955 74955 0 0.0
.text 542400 543128 728 0.1
lock-ftd LP_CC2652R7 (read only) 682959 683687 728 0.1
(read/write) 159872 159144 -728 -0.5
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97671 97671 0 0.0
.text 584808 585536 728 0.1
lock-mtd LP_CC2652R7 (read only) 632359 633087 728 0.1
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97551 97551 0 0.0
.text 534320 535048 728 0.1
pump-app LP_CC2652R7 (read only) 664063 664783 720 0.1
(read/write) 179672 178952 -720 -0.4
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577736 578456 720 0.1
pump-controller-app LP_CC2652R7 (read only) 655135 655855 720 0.1
(read/write) 188712 187992 -720 -0.4
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570760 571480 720 0.1
shell LP_CC2652R7 (read only) 643850 644578 728 0.1
(read/write) 154472 154472 0 0.0
.bss 76948 76948 0 0.0
.data 3408 3408 0 0.0
.rodata 82474 82474 0 0.0
.text 561140 561868 728 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602102 602862 760 0.1
.app_xip_area 461128 461888 760 0.2
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599210 599970 760 0.1
.app_xip_area 458100 458860 760 0.2
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596874 597626 752 0.1
.app_xip_area 456896 457648 752 0.2
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916016 916016 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916008 916008 0 0.0
BRD4161A+rpc (read only) 950228 950228 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950220 950220 0 0.0
BRD4161A+rs911x (read only) 791212 791212 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791204 791204 0 0.0
lock-app BRD4161A+wf200 (read only) 958076 958076 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958068 958068 0 0.0
window-app BRD4161A (read only) 901064 901064 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901056 901056 0 0.0
esp32 all-clusters-app c3devkit (read only) 1006840 1006840 0 0.0
(read/write) 1481330 1481330 0 0.0
.dram0.bss 69160 69160 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212080 212080 0 0.0
.flash.text 1006840 1006840 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1061847 1061847 0 0.0
(read/write) 483508 483508 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242624 242624 0 0.0
.flash.text 1056463 1056463 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657976 658760 784 0.1
.bss 69760 69776 16 0.0
.data 2016 2016 0 0.0
.text 580400 581168 768 0.1
lock k32w061+release (read/write) 719204 719988 784 0.1
.bss 70192 70208 16 0.0
.data 1988 1988 0 0.0
.text 641224 641992 768 0.1
linux all-clusters-app debug (read only) 2773505 2773505 0 0.0
(read/write) 178504 178504 0 0.0
.bss 86304 86304 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 245885 245885 0 0.0
.text 2353522 2353522 0 0.0
all-clusters-minimal-app debug (read only) 2653537 2653537 0 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2232994 2232994 0 0.0
bridge-app debug+rpc (read only) 2031089 2031089 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704722 1704722 0 0.0
chip-tool debug (read only) 9668877 9668877 0 0.0
(read/write) 611152 611152 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 579760 579760 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496989 496989 0 0.0
.text 7759253 7759253 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9420652 9420652 0 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460844 460844 0 0.0
.text 7412196 7412196 0 0.0
lighting-app debug+rpc (read only) 2321321 2321321 0 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966802 1966802 0 0.0
lock-app debug (read only) 2264689 2264689 0 0.0
(read/write) 148768 148768 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 68008 68008 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1901282 1901282 0 0.0
ota-provider-app debug (read only) 2066817 2066817 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726482 1726482 0 0.0
ota-requestor-app debug (read only) 2094641 2094641 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756930 1756930 0 0.0
shell debug (read only) 2578345 2578345 0 0.0
(read/write) 201912 201912 0 0.0
.bss 117160 117160 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77624 77624 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 225938 225938 0 0.0
.text 2192818 2192818 0 0.0
thermostat-no-ble arm64 (read only) 2367804 2367804 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1989280 1989280 0 0.0
tv-app debug (read only) 2878281 2878281 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2472546 2472546 0 0.0
tv-casting-app debug (read only) 5329121 5329121 0 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337536 337536 0 0.0
.text 4640370 4640370 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427136 2427136 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389780 1389780 0 0.0
p6 all-clusters-app default (read/write) 2544608 2544608 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502872 1502872 0 0.0
all-clusters-minimal-app default (read/write) 2490472 2490472 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448736 1448736 0 0.0
light-app default (read/write) 2422352 2422352 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380616 1380616 0 0.0
lock-app default (read/write) 2442712 2442712 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400976 1400976 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 781796 896 0.1
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552296 553120 824 0.1
lighting-app tlsr9518adk80d (read/write) 800944 801840 896 0.1
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569038 569862 824 0.1

@restyled-io restyled-io bot mentioned this pull request Jun 8, 2022
Closed
@LuDuda LuDuda marked this pull request as ready for review June 8, 2022 22:12
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19200: Size comparison from 2b5ec74 to edf1a9f

Increases (19 builds for cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect, telink)
platform target config section 2b5ec74 edf1a9f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 690783 800 0.1
.text 577336 578136 800 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640599 641391 792 0.1
.text 550904 551696 792 0.1
lock-ftd LP_CC2652R7 (read only) 683487 684279 792 0.1
.text 584812 585604 792 0.1
lock-mtd LP_CC2652R7 (read only) 632895 633687 792 0.1
.text 534324 535116 792 0.1
pump-app LP_CC2652R7 (read only) 664931 665723 792 0.1
.text 578076 578868 792 0.1
pump-controller-app LP_CC2652R7 (read only) 655507 656299 792 0.1
.text 570764 571556 792 0.1
shell LP_CC2652R7 (read only) 682254 683046 792 0.1
.text 573008 573800 792 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602578 603402 824 0.1
.app_xip_area 461524 462348 824 0.2
lock cyw930739m2evb_01 (read/write) 599662 600478 816 0.1
.app_xip_area 458472 459288 816 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 600286 824 0.1
.app_xip_area 459388 460212 824 0.2
efr32 lighting-app BRD4161A (read only) 915064 915144 80 0.0
.text 915056 915136 80 0.0
BRD4161A+rpc (read only) 949268 949348 80 0.0
.text 949260 949340 80 0.0
window-app BRD4161A (read only) 900136 900216 80 0.0
.text 900128 900208 80 0.0
k32w light k32w061+release (read/write) 653792 654656 864 0.1
.bss 70044 70060 16 0.0
.text 575944 576792 848 0.1
lock k32w061+release (read/write) 714900 715748 848 0.1
.bss 70484 70500 16 0.0
.text 636640 637472 832 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192139 64 0.0
text 817132 817204 72 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139847 64 0.0
text 789180 789252 72 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 782680 952 0.1
text 552594 553480 886 0.2
lighting-app tlsr9518adk80d (read/write) 801740 802700 960 0.1
text 569316 570202 886 0.2
Decreases (6 builds for cc13x2_26x2, esp32)
platform target config section 2b5ec74 edf1a9f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161784 160984 -800 -0.5
lock-ftd LP_CC2652R7 (read/write) 159344 158552 -792 -0.5
pump-app LP_CC2652R7 (read/write) 178812 178020 -792 -0.4
pump-controller-app LP_CC2652R7 (read/write) 188340 187548 -792 -0.4
shell LP_CC2652R7 (read/write) 165008 164216 -792 -0.5
esp32 all-clusters-app c3devkit (read only) 1007744 1007742 -2 -0.0
.flash.text 1007744 1007742 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2b5ec74 edf1a9f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 690783 800 0.1
(read/write) 161784 160984 -800 -0.5
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112335 112335 0 0.0
.text 577336 578136 800 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640599 641391 792 0.1
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89375 89375 0 0.0
.text 550904 551696 792 0.1
lock-ftd LP_CC2652R7 (read only) 683487 684279 792 0.1
(read/write) 159344 158552 -792 -0.5
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98191 98191 0 0.0
.text 584812 585604 792 0.1
lock-mtd LP_CC2652R7 (read only) 632895 633687 792 0.1
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98079 98079 0 0.0
.text 534324 535116 792 0.1
pump-app LP_CC2652R7 (read only) 664931 665723 792 0.1
(read/write) 178812 178020 -792 -0.4
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86371 86371 0 0.0
.text 578076 578868 792 0.1
pump-controller-app LP_CC2652R7 (read only) 655507 656299 792 0.1
(read/write) 188340 187548 -792 -0.4
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84259 84259 0 0.0
.text 570764 571556 792 0.1
shell LP_CC2652R7 (read only) 682254 683046 792 0.1
(read/write) 165008 164216 -792 -0.5
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108934 108934 0 0.0
.text 573008 573800 792 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602578 603402 824 0.1
.app_xip_area 461524 462348 824 0.2
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599662 600478 816 0.1
.app_xip_area 458472 459288 816 0.2
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 600286 824 0.1
.app_xip_area 459388 460212 824 0.2
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915064 915144 80 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915056 915136 80 0.0
BRD4161A+rpc (read only) 949268 949348 80 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949260 949340 80 0.0
BRD4161A+rs911x (read only) 790252 790252 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790244 790244 0 0.0
lock-app BRD4161A+wf200 (read only) 958508 958508 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958500 958500 0 0.0
window-app BRD4161A (read only) 900136 900216 80 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900128 900208 80 0.0
esp32 all-clusters-app c3devkit (read only) 1007744 1007742 -2 -0.0
(read/write) 1481842 1481842 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212592 212592 0 0.0
.flash.text 1007744 1007742 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062535 1062535 0 0.0
(read/write) 483976 483976 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243092 243092 0 0.0
.flash.text 1057151 1057151 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653792 654656 864 0.1
.bss 70044 70060 16 0.0
.data 2004 2004 0 0.0
.text 575944 576792 848 0.1
lock k32w061+release (read/write) 714900 715748 848 0.1
.bss 70484 70500 16 0.0
.data 1976 1976 0 0.0
.text 636640 637472 832 0.1
linux all-clusters-app debug (read only) 2892457 2892457 0 0.0
(read/write) 180024 180024 0 0.0
.bss 87840 87840 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255485 255485 0 0.0
.text 2462450 2462450 0 0.0
all-clusters-minimal-app debug (read only) 2753937 2753937 0 0.0
(read/write) 171640 171640 0 0.0
.bss 87008 87008 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256765 256765 0 0.0
.text 2324658 2324658 0 0.0
bridge-app debug+rpc (read only) 2198001 2198001 0 0.0
(read/write) 149528 149528 0 0.0
.bss 74496 74496 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187840 187840 0 0.0
.text 1851250 1851250 0 0.0
chip-tool debug (read only) 9771221 9771221 0 0.0
(read/write) 611840 611840 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579032 579032 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 506205 506205 0 0.0
.text 7851637 7851637 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9513596 9513596 0 0.0
(read/write) 678065 678065 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614488 614488 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468300 468300 0 0.0
.text 7496900 7496900 0 0.0
lighting-app debug+rpc (read only) 2482385 2482385 0 0.0
(read/write) 155136 155136 0 0.0
.bss 76320 76320 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205384 205384 0 0.0
.text 2109410 2109410 0 0.0
lock-app debug (read only) 2428353 2428353 0 0.0
(read/write) 150272 150272 0 0.0
.bss 75040 75040 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219432 219432 0 0.0
.text 2046322 2046322 0 0.0
ota-provider-app debug (read only) 2203785 2203785 0 0.0
(read/write) 143264 143264 0 0.0
.bss 74496 74496 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 191960 191960 0 0.0
.text 1852146 1852146 0 0.0
ota-requestor-app debug (read only) 2265417 2265417 0 0.0
(read/write) 146312 146312 0 0.0
.bss 75264 75264 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195296 195296 0 0.0
.text 1906386 1906386 0 0.0
shell debug (read only) 2584081 2584081 0 0.0
(read/write) 203200 203200 0 0.0
.bss 118728 118728 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228050 228050 0 0.0
.text 2197410 2197410 0 0.0
thermostat-no-ble arm64 (read only) 2544028 2544028 0 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160132 160132 0 0.0
.text 2146960 2146960 0 0.0
tv-app debug (read only) 3035985 3035985 0 0.0
(read/write) 281648 281648 0 0.0
.bss 192296 192296 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241056 241056 0 0.0
.text 2609746 2609746 0 0.0
tv-casting-app debug (read only) 5335041 5335041 0 0.0
(read/write) 224032 224032 0 0.0
.bss 80136 80136 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135248 135248 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340512 340512 0 0.0
.text 4643858 4643858 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429664 2429664 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392308 1392308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192139 64 0.0
bss 141362 141362 0 0.0
rodata 154652 154652 0 0.0
text 817132 817204 72 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139847 64 0.0
bss 140579 140579 0 0.0
rodata 131144 131144 0 0.0
text 789180 789252 72 0.0
p6 all-clusters-app default (read/write) 2544544 2544544 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502808 1502808 0 0.0
all-clusters-minimal-app default (read/write) 2489416 2489416 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447680 1447680 0 0.0
light-app default (read/write) 2421336 2421336 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379600 1379600 0 0.0
lock-app default (read/write) 2441672 2441672 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399936 1399936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 782680 952 0.1
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552594 553480 886 0.2
lighting-app tlsr9518adk80d (read/write) 801740 802700 960 0.1
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569316 570202 886 0.2

@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

PR #19200: Size comparison from ac7e2f7 to 826b8f7

Increases (17 builds for cc13x2_26x2, cyw30739, esp32, k32w, nrfconnect, telink)
platform target config section ac7e2f7 826b8f7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689943 690735 792 0.1
.text 577304 578096 792 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640599 641399 800 0.1
.text 550912 551712 800 0.1
lock-ftd LP_CC2652R7 (read only) 683455 684255 800 0.1
.text 584788 585588 800 0.1
lock-mtd LP_CC2652R7 (read only) 632879 633671 792 0.1
.text 534316 535108 792 0.1
pump-app LP_CC2652R7 (read only) 664899 665699 800 0.1
.text 578052 578852 800 0.1
pump-controller-app LP_CC2652R7 (read only) 655483 656283 800 0.1
.text 570748 571548 800 0.1
shell LP_CC2652R7 (read only) 682230 683030 800 0.1
.text 572992 573792 800 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602562 603386 824 0.1
.app_xip_area 461508 462332 824 0.2
lock cyw930739m2evb_01 (read/write) 599646 600462 816 0.1
.app_xip_area 458456 459272 816 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599446 600262 816 0.1
.app_xip_area 459372 460188 816 0.2
esp32 all-clusters-app c3devkit (read only) 1007740 1007742 2 0.0
.flash.text 1007740 1007742 2 0.0
k32w light k32w061+release (read/write) 653784 654632 848 0.1
.bss 70044 70060 16 0.0
.text 575936 576768 832 0.1
lock k32w061+release (read/write) 714876 715724 848 0.1
.bss 70484 70500 16 0.0
.text 636616 637448 832 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192051 1192115 64 0.0
text 817112 817184 72 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139775 1139855 80 0.0
text 789188 789260 72 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781696 782656 960 0.1
text 552576 553460 884 0.2
lighting-app tlsr9518adk80d (read/write) 801716 802668 952 0.1
text 569298 570180 882 0.2
Decreases (5 builds for cc13x2_26x2)
platform target config section ac7e2f7 826b8f7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161824 161032 -792 -0.5
lock-ftd LP_CC2652R7 (read/write) 159376 158576 -800 -0.5
pump-app LP_CC2652R7 (read/write) 178844 178044 -800 -0.4
pump-controller-app LP_CC2652R7 (read/write) 188364 187564 -800 -0.4
shell LP_CC2652R7 (read/write) 165032 164232 -800 -0.5
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ac7e2f7 826b8f7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689943 690735 792 0.1
(read/write) 161824 161032 -792 -0.5
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112327 112327 0 0.0
.text 577304 578096 792 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640599 641399 800 0.1
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89367 89367 0 0.0
.text 550912 551712 800 0.1
lock-ftd LP_CC2652R7 (read only) 683455 684255 800 0.1
(read/write) 159376 158576 -800 -0.5
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98183 98183 0 0.0
.text 584788 585588 800 0.1
lock-mtd LP_CC2652R7 (read only) 632879 633671 792 0.1
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98071 98071 0 0.0
.text 534316 535108 792 0.1
pump-app LP_CC2652R7 (read only) 664899 665699 800 0.1
(read/write) 178844 178044 -800 -0.4
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86363 86363 0 0.0
.text 578052 578852 800 0.1
pump-controller-app LP_CC2652R7 (read only) 655483 656283 800 0.1
(read/write) 188364 187564 -800 -0.4
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84251 84251 0 0.0
.text 570748 571548 800 0.1
shell LP_CC2652R7 (read only) 682230 683030 800 0.1
(read/write) 165032 164232 -800 -0.5
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108926 108926 0 0.0
.text 572992 573792 800 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602562 603386 824 0.1
.app_xip_area 461508 462332 824 0.2
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599646 600462 816 0.1
.app_xip_area 458456 459272 816 0.2
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599446 600262 816 0.1
.app_xip_area 459372 460188 816 0.2
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007740 1007742 2 0.0
(read/write) 1481834 1481834 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212584 212584 0 0.0
.flash.text 1007740 1007742 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062491 1062491 0 0.0
(read/write) 483968 483968 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243084 243084 0 0.0
.flash.text 1057107 1057107 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653784 654632 848 0.1
.bss 70044 70060 16 0.0
.data 2004 2004 0 0.0
.text 575936 576768 832 0.1
lock k32w061+release (read/write) 714876 715724 848 0.1
.bss 70484 70500 16 0.0
.data 1976 1976 0 0.0
.text 636616 637448 832 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9502940 9502940 0 0.0
(read/write) 678033 678033 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614464 614464 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467916 467916 0 0.0
.text 7486692 7486692 0 0.0
thermostat-no-ble arm64 (read only) 2544060 2544060 0 0.0
(read/write) 183057 183057 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82120 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160164 160164 0 0.0
.text 2147040 2147040 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429656 2429656 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392300 1392300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192051 1192115 64 0.0
bss 141362 141362 0 0.0
rodata 154644 154644 0 0.0
text 817112 817184 72 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139775 1139855 80 0.0
bss 140579 140579 0 0.0
rodata 131136 131136 0 0.0
text 789188 789260 72 0.0
p6 all-clusters-app default (read/write) 2544632 2544632 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502896 1502896 0 0.0
all-clusters-minimal-app default (read/write) 2489440 2489440 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447704 1447704 0 0.0
light-app default (read/write) 2421312 2421312 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379576 1379576 0 0.0
lock-app default (read/write) 2441648 2441648 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399912 1399912 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781696 782656 960 0.1
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552576 553460 884 0.2
lighting-app tlsr9518adk80d (read/write) 801716 802668 952 0.1
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569298 570180 882 0.2

@bzbarsky-apple bzbarsky-apple merged commit 47c8653 into project-chip:master Jun 10, 2022
This was referenced Jul 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LuDuda @saurabhst @woody-apple @Damian-Nordic @bzbarsky-apple