Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add darwin-framework-tool support for min/max constraints with saved variables #19193

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Add darwin-framework-tool support for min/max constraints with saved variables #19193

merged 1 commit into from
Jun 6, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Adds support for having the expected value in a min/max constraint be
a saveAs value in darwin-framework-tool.

Fixes #19110

Problem

See above.

Change overview

See above.

Testing

Checks that the generated code from #19110 compiles.

@bzbarsky-apple
Add darwin-framework-tool support for min/max constraints with saved …
78a4f03 
…variables.

Adds support for having the expected value in a min/max constraint be
a saveAs value in darwin-framework-tool.

Fixes project-chip#19110
@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19193: Size comparison from 6443f77 to 529b893

Full report (16 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6443f77 529b893 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602102 602102 0 0.0
.app_xip_area 461128 461128 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599210 599210 0 0.0
.app_xip_area 458100 458100 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596874 596874 0 0.0
.app_xip_area 456896 456896 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657976 657976 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580400 580400 0 0.0
lock k32w061+release (read/write) 719204 719204 0 0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 641224 641224 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9419516 9419516 0 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460844 460844 0 0.0
.text 7411060 7411060 0 0.0
thermostat-no-ble arm64 (read only) 2367596 2367596 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1989072 1989072 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427136 2427136 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389780 1389780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190463 1190463 0 0.0
bss 141293 141293 0 0.0
rodata 154088 154088 0 0.0
text 816204 816204 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139111 1139111 0 0.0
bss 140514 140514 0 0.0
rodata 130744 130744 0 0.0
text 789044 789044 0 0.0
p6 all-clusters-app default (read/write) 2544608 2544608 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502872 1502872 0 0.0
all-clusters-minimal-app default (read/write) 2490472 2490472 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448736 1448736 0 0.0
light-app default (read/write) 2422352 2422352 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380616 1380616 0 0.0
lock-app default (read/write) 2442712 2442712 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400976 1400976 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780900 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552296 552296 0 0.0
lighting-app tlsr9518adk80d (read/write) 800944 800944 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569038 569038 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the darwin-tool-min-max-value-saved branch from 529b893 to 78a4f03 Compare June 3, 2022 20:38
@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19193: Size comparison from cb5b1b3 to 78a4f03

Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section cb5b1b3 78a4f03 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 650819 650819 0 0.0
(read/write) 158916 158916 0 0.0
.bss 74596 74596 0 0.0
.data 3404 3404 0 0.0
.rodata 85483 85483 0 0.0
.text 565104 565104 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617587 617587 0 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74955 74955 0 0.0
.text 542400 542400 0 0.0
lock-ftd LP_CC2652R7 (read only) 682959 682959 0 0.0
(read/write) 159872 159872 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97671 97671 0 0.0
.text 584808 584808 0 0.0
lock-mtd LP_CC2652R7 (read only) 632359 632359 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97551 97551 0 0.0
.text 534320 534320 0 0.0
pump-app LP_CC2652R7 (read only) 664063 664063 0 0.0
(read/write) 179672 179672 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577736 577736 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655135 655135 0 0.0
(read/write) 188712 188712 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570760 570760 0 0.0
shell LP_CC2652R7 (read only) 643850 643850 0 0.0
(read/write) 154472 154472 0 0.0
.bss 76948 76948 0 0.0
.data 3408 3408 0 0.0
.rodata 82474 82474 0 0.0
.text 561140 561140 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602102 602102 0 0.0
.app_xip_area 461128 461128 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599210 599210 0 0.0
.app_xip_area 458100 458100 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596874 596874 0 0.0
.app_xip_area 456896 456896 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916016 916016 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916008 916008 0 0.0
BRD4161A+rpc (read only) 950228 950228 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950220 950220 0 0.0
BRD4161A+rs911x (read only) 791212 791212 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791204 791204 0 0.0
lock-app BRD4161A+wf200 (read only) 958076 958076 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958068 958068 0 0.0
window-app BRD4161A (read only) 901064 901064 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901056 901056 0 0.0
esp32 all-clusters-app c3devkit (read only) 1006840 1006840 0 0.0
(read/write) 1481330 1481330 0 0.0
.dram0.bss 69160 69160 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212080 212080 0 0.0
.flash.text 1006840 1006840 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1061847 1061847 0 0.0
(read/write) 483508 483508 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242624 242624 0 0.0
.flash.text 1056463 1056463 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657976 657976 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580400 580400 0 0.0
lock k32w061+release (read/write) 719204 719204 0 0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 641224 641224 0 0.0
linux all-clusters-app debug (read only) 2773505 2773505 0 0.0
(read/write) 178504 178504 0 0.0
.bss 86304 86304 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 245885 245885 0 0.0
.text 2353522 2353522 0 0.0
all-clusters-minimal-app debug (read only) 2653537 2653537 0 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2232994 2232994 0 0.0
bridge-app debug+rpc (read only) 2031089 2031089 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704722 1704722 0 0.0
chip-tool debug (read only) 9668877 9668877 0 0.0
(read/write) 611152 611152 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 579760 579760 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496989 496989 0 0.0
.text 7759253 7759253 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9420652 9420652 0 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460844 460844 0 0.0
.text 7412196 7412196 0 0.0
lighting-app debug+rpc (read only) 2321321 2321321 0 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966802 1966802 0 0.0
lock-app debug (read only) 2264689 2264689 0 0.0
(read/write) 148768 148768 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 68008 68008 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1901282 1901282 0 0.0
ota-provider-app debug (read only) 2066817 2066817 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726482 1726482 0 0.0
ota-requestor-app debug (read only) 2094641 2094641 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756930 1756930 0 0.0
shell debug (read only) 2578345 2578345 0 0.0
(read/write) 201912 201912 0 0.0
.bss 117160 117160 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77624 77624 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 225938 225938 0 0.0
.text 2192818 2192818 0 0.0
thermostat-no-ble arm64 (read only) 2367804 2367804 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1989280 1989280 0 0.0
tv-app debug (read only) 2878281 2878281 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2472546 2472546 0 0.0
tv-casting-app debug (read only) 5329121 5329121 0 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337536 337536 0 0.0
.text 4640370 4640370 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427136 2427136 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389780 1389780 0 0.0
p6 all-clusters-app default (read/write) 2544608 2544608 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502872 1502872 0 0.0
all-clusters-minimal-app default (read/write) 2490472 2490472 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448736 1448736 0 0.0
light-app default (read/write) 2422352 2422352 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380616 1380616 0 0.0
lock-app default (read/write) 2442712 2442712 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400976 1400976 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780900 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552296 552296 0 0.0
lighting-app tlsr9518adk80d (read/write) 800944 800944 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569038 569038 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 5f0dc86 into project-chip:master Jun 6, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-tool-min-max-value-saved branch June 6, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krypton36 krypton36 krypton36 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@andy31415 andy31415 Awaiting requested review from andy31415

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@lazarkov lazarkov Awaiting requested review from lazarkov

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TC-CC-9.*] tests fails for Darwin checks
5 participants
@bzbarsky-apple @andy31415 @lazarkov @krypton36 @jmartinez-silabs