Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better mandatory cluster rules in matterlint #19165

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Add better mandatory cluster rules in matterlint #19165

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24fe95
Add better mandatory cluster rules in matterlint
andy31415 Jun 3, 2022
669f36c
Code review updates - do not make network commissioning required
andy31415 Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions scripts/rules.matterlint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,25 @@ all endpoints {

endpoint 0 {
// Identifiers for clusters are loaded from XML files
// The required clusters are from the spec for RootNode (section 2.1.5 at the moment):

require server cluster Basic;
require server cluster AccessControl;
require server cluster GroupKeyManagement;
require server cluster NetworkCommissioning;
require server cluster GeneralCommissioning;
require server cluster OTASoftwareUpdateRequestor;
require server cluster AdministratorCommissioning;
require server cluster OperationalCredentials;
require server cluster GeneralDiagnostics;
andy31415 marked this conversation as resolved.
Show resolved Hide resolved

// Required only if !CustomNetworkConfig. For now assume yes for matter examples
require server cluster NetworkCommissioning;
andy31415 marked this conversation as resolved.
Show resolved Hide resolved

// If Ethernet
// require server cluster EthernetNetworkDiagnostics;

// If WiFi
// require server cluster WiFiNetworkDiagnostics;

// If Thread
// require server cluster ThreadNetworkDiagnostics;
}