Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attributes and commands for lock app #19133

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Update attributes and commands for lock app #19133

merged 2 commits into from
Jun 6, 2022

Conversation

Morozov-5F
Copy link
Contributor

Problem

Change overview

Updated attribute list and feature map for lock-app according to mandatory features in the spec.

Testing

  • Made sure that output of accepted-command-list and attribute-list matches expectations

@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #19133: Size comparison from 3ae659d to 97da94a

Increases (1 build for cc13x2_26x2)
platform target config section 3ae659d 97da94a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162372 162396 24 0.0
Decreases (8 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6)
platform target config section 3ae659d 97da94a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 680539 680515 -24 -0.0
.rodata 96627 96603 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 629939 629915 -24 -0.0
.rodata 96507 96483 -24 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 597986 597962 -24 -0.0
.app_xip_area 456884 456860 -24 -0.0
efr32 lock-app BRD4161A+wf200 (read only) 955128 955104 -24 -0.0
.text 955120 955096 -24 -0.0
k32w lock k32w061+release (read/write) 716736 716712 -24 -0.0
.text 638756 638732 -24 -0.0
linux lock-app debug (read/write) 148736 148704 -32 -0.0
.data.rel.ro 67944 67912 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425440 2425416 -24 -0.0
.text 1388084 1388060 -24 -0.0
p6 lock-app default (read/write) 2440120 2440096 -24 -0.0
.text 1398384 1398360 -24 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3ae659d 97da94a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648459 648459 0 0.0
(read/write) 158988 158988 0 0.0
.bss 74668 74668 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563696 563696 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615339 615339 0 0.0
(read/write) 158160 158160 0 0.0
.bss 73900 73900 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541192 541192 0 0.0
lock-ftd LP_CC2652R7 (read only) 680539 680515 -24 -0.0
(read/write) 162372 162396 24 0.0
.bss 72692 72692 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96603 -24 -0.0
.text 583432 583432 0 0.0
lock-mtd LP_CC2652R7 (read only) 629939 629915 -24 -0.0
(read/write) 145812 145812 0 0.0
.bss 68428 68428 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96483 -24 -0.0
.text 532944 532944 0 0.0
pump-app LP_CC2652R7 (read only) 663563 663563 0 0.0
(read/write) 180260 180260 0 0.0
.bss 72836 72836 0 0.0
.data 3300 3300 0 0.0
.rodata 85643 85643 0 0.0
.text 577436 577436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654891 654891 0 0.0
(read/write) 189044 189044 0 0.0
.bss 72948 72948 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570572 570572 0 0.0
shell LP_CC2652R7 (read only) 641482 641482 0 0.0
(read/write) 154544 154544 0 0.0
.bss 77020 77020 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559724 559724 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 601878 601878 0 0.0
.app_xip_area 460904 460904 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 597986 597962 -24 -0.0
.app_xip_area 456884 456860 -24 -0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596634 596634 0 0.0
.app_xip_area 456656 456656 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915760 915760 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131176 131176 0 0.0
.data 2100 2100 0 0.0
.text 915752 915752 0 0.0
BRD4161A+rpc (read only) 949988 949988 0 0.0
(read/write) 149968 149968 0 0.0
.bss 147664 147664 0 0.0
.data 2304 2304 0 0.0
.text 949980 949980 0 0.0
BRD4161A+rs911x (read only) 787828 787828 0 0.0
(read/write) 129496 129496 0 0.0
.bss 127396 127396 0 0.0
.data 2100 2100 0 0.0
.text 787820 787820 0 0.0
lock-app BRD4161A+wf200 (read only) 955128 955104 -24 -0.0
(read/write) 128332 128332 0 0.0
.bss 126260 126260 0 0.0
.data 2072 2072 0 0.0
.text 955120 955096 -24 -0.0
window-app BRD4161A (read only) 900680 900680 0 0.0
(read/write) 133344 133344 0 0.0
.bss 131248 131248 0 0.0
.data 2096 2096 0 0.0
.text 900672 900672 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005270 1005270 0 0.0
(read/write) 1480114 1480114 0 0.0
.dram0.bss 69232 69232 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210800 210800 0 0.0
.flash.text 1005270 1005270 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060463 1060463 0 0.0
(read/write) 482324 482324 0 0.0
.dram0.bss 74752 74752 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241368 241368 0 0.0
.flash.text 1055079 1055079 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657764 657764 0 0.0
.bss 69768 69768 0 0.0
.data 2020 2020 0 0.0
.text 580176 580176 0 0.0
lock k32w061+release (read/write) 716736 716712 -24 -0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 638756 638732 -24 -0.0
linux all-clusters-app debug (read only) 2766681 2766681 0 0.0
(read/write) 178344 178344 0 0.0
.bss 86304 86304 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 244573 244573 0 0.0
.text 2348130 2348130 0 0.0
all-clusters-minimal-app debug (read only) 2643833 2643833 0 0.0
(read/write) 170376 170376 0 0.0
.bss 85568 85568 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 246525 246525 0 0.0
.text 2224722 2224722 0 0.0
bridge-app debug+rpc (read only) 2029705 2029705 0 0.0
(read/write) 148000 148000 0 0.0
.bss 72960 72960 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 169760 169760 0 0.0
.text 1703378 1703378 0 0.0
chip-tool debug (read only) 9591333 9591333 0 0.0
(read/write) 597048 597048 0 0.0
.bss 24032 24032 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 565600 565600 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 494909 494909 0 0.0
.text 7716885 7716885 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9345492 9345492 0 0.0
(read/write) 662961 662961 0 0.0
.bss 42305 42305 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 600832 600832 0 0.0
.dynamic 528 528 0 0.0
.got 14824 14824 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 458652 458652 0 0.0
.text 7372676 7372676 0 0.0
lighting-app debug+rpc (read only) 2319857 2319857 0 0.0
(read/write) 153640 153640 0 0.0
.bss 74816 74816 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 188680 188680 0 0.0
.text 1965378 1965378 0 0.0
lock-app debug (read only) 2258489 2258489 0 0.0
(read/write) 148736 148704 -32 -0.0
.bss 73504 73504 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67912 -32 -0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 201736 201736 0 0.0
.text 1896386 1896386 0 0.0
ota-provider-app debug (read only) 2066505 2066505 0 0.0
(read/write) 141656 141656 0 0.0
.bss 73088 73088 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 181144 181144 0 0.0
.text 1726242 1726242 0 0.0
ota-requestor-app debug (read only) 2093529 2093529 0 0.0
(read/write) 144496 144496 0 0.0
.bss 73792 73792 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 177088 177088 0 0.0
.text 1755858 1755858 0 0.0
shell debug (read only) 2571665 2571665 0 0.0
(read/write) 201752 201752 0 0.0
.bss 117160 117160 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 224626 224626 0 0.0
.text 2187570 2187570 0 0.0
thermostat-no-ble arm64 (read only) 2366668 2366668 0 0.0
(read/write) 177601 177601 0 0.0
.bss 87969 87969 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80288 80288 0 0.0
.dynamic 528 528 0 0.0
.got 4800 4800 0 0.0
.init 24 24 0 0.0
.init_array 384 384 0 0.0
.rodata 148828 148828 0 0.0
.text 1988064 1988064 0 0.0
tv-app debug (read only) 2876801 2876801 0 0.0
(read/write) 280280 280280 0 0.0
.bss 191112 191112 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 223040 223040 0 0.0
.text 2471106 2471106 0 0.0
tv-casting-app debug (read only) 5326713 5326713 0 0.0
(read/write) 222744 222744 0 0.0
.bss 78696 78696 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 337408 337408 0 0.0
.text 4638066 4638066 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425440 2425416 -24 -0.0
.bss 202652 202652 0 0.0
.data 5880 5880 0 0.0
.text 1388084 1388060 -24 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187687 1187687 0 0.0
bss 141297 141297 0 0.0
rodata 152832 152832 0 0.0
text 814692 814692 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136451 1136451 0 0.0
bss 140526 140526 0 0.0
rodata 129396 129396 0 0.0
text 787736 787736 0 0.0
p6 all-clusters-app default (read/write) 2541696 2541696 0 0.0
.bss 137192 137192 0 0.0
.data 2808 2808 0 0.0
.text 1499960 1499960 0 0.0
all-clusters-minimal-app default (read/write) 2487664 2487664 0 0.0
.bss 136416 136416 0 0.0
.data 2752 2752 0 0.0
.text 1445928 1445928 0 0.0
light-app default (read/write) 2422064 2422064 0 0.0
.bss 129520 129520 0 0.0
.data 2608 2608 0 0.0
.text 1380328 1380328 0 0.0
lock-app default (read/write) 2440120 2440096 -24 -0.0
.bss 129336 129336 0 0.0
.data 2576 2576 0 0.0
.text 1398384 1398360 -24 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780672 780672 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 552106 552106 0 0.0
lighting-app tlsr9518adk80d (read/write) 800708 800708 0 0.0
bss 70844 70844 0 0.0
noinit 40416 40416 0 0.0
text 568848 568848 0 0.0

@andy31415 andy31415 merged commit 53068df into project-chip:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TC-DL-1.1] FeatureMap and Attribute/Command Lists mismatch
4 participants
@Morozov-5F @andy31415 @woody-apple @bzbarsky-apple