Allow commissioning window to work even if BLE advertising is not supported #19121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ported. An application might be built against an CHIP library that has BLE support compieled in (e.g. so it can do discovery over BLE) but does not support commissionable advertising over BLE. In that case, we should not fail to open a commissioning window just because we can't advertise over BLE; we can still advertise over DNS-SD.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
robszewczyk
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
reviewed
Jun 2, 2022
andy31415
reviewed
Jun 2, 2022
andy31415
approved these changes
Jun 2, 2022
|
PR #19121: Size comparison from 0bf3ba4 to aa59d7a Increases (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 2, 2022
chrisdecenzo
approved these changes
Jun 2, 2022
|
PR #19121: Size comparison from 0bf3ba4 to 7823ff3 Increases above 0.2%:
Increases (38 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (23 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An application might be built against an CHIP library that has BLE support
compieled in (e.g. so it can do discovery over BLE) but does not support
commissionable advertising over BLE. In that case, we should not fail to open a
commissioning window just because we can't advertise over BLE; we can still
advertise over DNS-SD.
Problem
Have to compile SDK with non-default flags to get a working example app on Mac.
Change overview
Fix things to not need that.
Testing
Compiled with
scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalonewithout disabling BLE and was able to commission the resulting example app over IP.