Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in function name FindLocalNodeFromDestionationId #19103

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

markus-becker-tridonic-com
Copy link
Contributor

Problem

Typo in FindLocalNodeFromDestionationId

Change overview

o removed from function name

Testing

CI building

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

PR #19103: Size comparison from 2f6de7b to 3a1824b

Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2f6de7b 3a1824b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648691 648691 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563924 563924 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615523 615523 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541372 541372 0 0.0
lock-ftd LP_CC2652R7 (read only) 680755 680755 0 0.0
(read/write) 162068 162068 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583644 583644 0 0.0
lock-mtd LP_CC2652R7 (read only) 630155 630155 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533156 533156 0 0.0
pump-app LP_CC2652R7 (read only) 663627 663627 0 0.0
(read/write) 180108 180108 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85643 85643 0 0.0
.text 577504 577504 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655083 655083 0 0.0
(read/write) 188764 188764 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570768 570768 0 0.0
shell LP_CC2652R7 (read only) 641706 641706 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559952 559952 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602150 602150 0 0.0
.app_xip_area 461176 461176 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598290 598290 0 0.0
.app_xip_area 457188 457188 0 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596786 596786 0 0.0
.app_xip_area 456808 456808 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915712 915712 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915704 915704 0 0.0
BRD4161A+rpc (read only) 949924 949924 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949916 949916 0 0.0
BRD4161A+rs911x (read only) 787860 787860 0 0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 787852 787852 0 0.0
lock-app BRD4161A+wf200 (read only) 955400 955400 0 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 955392 955392 0 0.0
window-app BRD4161A (read only) 900648 900648 0 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 900640 900640 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005842 1005842 0 0.0
(read/write) 1480026 1480026 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210792 210792 0 0.0
.flash.text 1005842 1005842 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060939 1060939 0 0.0
(read/write) 482232 482232 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241364 241364 0 0.0
.flash.text 1055555 1055555 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681412 681412 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597528 597528 0 0.0
lock k32w061+release (read/write) 733444 733444 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 649160 649160 0 0.0
linux all-clusters-app debug (read only) 2766769 2766769 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244605 244605 0 0.0
.text 2348210 2348210 0 0.0
all-clusters-minimal-app debug (read only) 2643921 2643921 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246557 246557 0 0.0
.text 2224802 2224802 0 0.0
bridge-app debug+rpc (read only) 2030065 2030065 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1703698 1703698 0 0.0
chip-tool debug (read only) 9682509 9682509 0 0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 498045 498045 0 0.0
.text 7795877 7795877 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9422628 9422628 0 0.0
(read/write) 666897 666897 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604672 604672 0 0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461372 461372 0 0.0
.text 7437412 7437412 0 0.0
lighting-app debug+rpc (read only) 2319881 2319881 0 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188712 188712 0 0.0
.text 1965394 1965394 0 0.0
lock-app debug (read only) 2258513 2258513 0 0.0
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201768 201768 0 0.0
.text 1896402 1896402 0 0.0
ota-provider-app debug (read only) 2066401 2066401 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181176 181176 0 0.0
.text 1726130 1726130 0 0.0
ota-requestor-app debug (read only) 2093521 2093521 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1755810 1755810 0 0.0
shell debug (read only) 2571705 2571705 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224690 224690 0 0.0
.text 2187570 2187570 0 0.0
thermostat-no-ble arm64 (read only) 2367164 2367164 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148796 148796 0 0.0
.text 1988672 1988672 0 0.0
tv-app debug (read only) 2876857 2876857 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2471122 2471122 0 0.0
tv-casting-app debug (read only) 5431761 5431761 0 0.0
(read/write) 226032 226032 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138792 138792 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340576 340576 0 0.0
.text 4731906 4731906 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425752 2425752 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388396 1388396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188179 1188179 0 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815236 815236 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136911 1136911 0 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788248 788248 0 0.0
p6 all-clusters-app default (read/write) 2541760 2541760 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1500024 1500024 0 0.0
all-clusters-minimal-app default (read/write) 2487696 2487696 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445960 1445960 0 0.0
light-app default (read/write) 2422144 2422144 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380408 1380408 0 0.0
lock-app default (read/write) 2440184 2440184 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398448 1398448 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780900 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552238 552238 0 0.0
lighting-app tlsr9518adk80d (read/write) 800936 800936 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568980 568980 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking typos

@andy31415
Copy link
Contributor

/rebase

@andy31415
Copy link
Contributor

@markus-becker-tridonic-com - restarted linux test suite 6 times, failed every time so likely not a flake.

Could you check it?

@andy31415
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

@markus-becker-tridonic-com Sorry still conflicts :(

@github-actions
Copy link

github-actions bot commented Jun 22, 2022

PR #19103: Size comparison from d1a4bb7 to 65feb8a

Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section d1a4bb7 65feb8a change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 649251 649243 -8 -0.0
.text 558424 558416 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 823984 823980 -4 -0.0
telink light-switch-app tlsr9518adk80d text 561060 561058 -2 -0.0
lighting-app tlsr9518adk80d text 577520 577518 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1a4bb7 65feb8a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660439 660439 0 0.0
(read/write) 191168 191168 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573152 573152 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649251 649243 -8 -0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558424 558416 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 691999 691999 0 0.0
(read/write) 149720 149720 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 592164 592164 0 0.0
lock-mtd LP_CC2652R7 (read only) 641415 641415 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99239 0 0.0
.text 541684 541684 0 0.0
pump-app LP_CC2652R7 (read only) 673231 673231 0 0.0
(read/write) 169384 169384 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585084 585084 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659123 659123 0 0.0
(read/write) 183604 183604 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575136 575136 0 0.0
shell LP_CC2652R7 (read only) 690198 690198 0 0.0
(read/write) 156912 156912 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109758 0 0.0
.text 580128 580128 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591730 0 0.0
.app_xip_area 462628 462628 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589106 0 0.0
.app_xip_area 459828 459828 0 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594250 0 0.0
.app_xip_area 466020 466020 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926072 926072 0 0.0
(read/write) 133664 133664 0 0.0
.bss 131584 131584 0 0.0
.data 2080 2080 0 0.0
.text 926064 926064 0 0.0
BRD4161A+rpc (read only) 963216 963216 0 0.0
(read/write) 150552 150552 0 0.0
.bss 148264 148264 0 0.0
.data 2284 2284 0 0.0
.text 963208 963208 0 0.0
BRD4161A+rs911x (read only) 802580 802580 0 0.0
(read/write) 140316 140316 0 0.0
.bss 138228 138228 0 0.0
.data 2088 2088 0 0.0
.text 802572 802572 0 0.0
lock-app BRD4161A+wf200 (read only) 968288 968288 0 0.0
(read/write) 140692 140692 0 0.0
.bss 138604 138604 0 0.0
.data 2088 2088 0 0.0
.text 968280 968280 0 0.0
window-app BRD4161A (read only) 911240 911240 0 0.0
(read/write) 133768 133768 0 0.0
.bss 131656 131656 0 0.0
.data 2108 2108 0 0.0
.text 911232 911232 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014134 0 0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014134 1014134 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068459 0 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063075 1063075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661524 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583976 0 0.0
lock k32w061+release (read/write) 723452 723452 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645448 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925180 9925180 0 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473916 473916 0 0.0
.text 7910292 7910292 0 0.0
thermostat-no-ble arm64 (read only) 2578364 2578364 0 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174752 2174752 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439432 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1201883 0 0.0
bss 142862 142862 0 0.0
rodata 156108 156108 0 0.0
text 823984 823980 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149639 0 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796032 796032 0 0.0
p6 all-clusters-app default (read/write) 2555776 2555776 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514040 0 0.0
all-clusters-minimal-app default (read/write) 2501624 2501624 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1459888 0 0.0
light-app default (read/write) 2432384 2432384 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390648 0 0.0
lock-app default (read/write) 2453096 2453096 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792080 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561060 561058 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 811784 811784 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577520 577518 -2 -0.0

@markus-becker-tridonic-com
Copy link
Contributor Author

@woody-apple conflict free now.
@andy31415 linux test case seems fine after rebase, only cirque fails which looks unrelated.

@woody-apple woody-apple merged commit 5398d78 into project-chip:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants