-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the MoveToClosestFrequency command to the level control cluster XML. #19065
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-move-to-closest-frequency
Jun 2, 2022
Merged
Add the MoveToClosestFrequency command to the level control cluster XML. #19065
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-move-to-closest-frequency
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
LuDuda
June 1, 2022 17:44
pullapprove
bot
requested review from
vijs,
vivien-apple,
selissia,
wbschiller,
tecimovic,
woody-apple,
turon,
xylophone21 and
yufengwangca
June 1, 2022 17:44
bzbarsky-apple
force-pushed
the
add-move-to-closest-frequency
branch
from
June 1, 2022 17:46
923c742
to
dd906d7
Compare
tcarmelveilleux
approved these changes
Jun 1, 2022
yunhanw-google
approved these changes
Jun 1, 2022
PR #19065: Size comparison from 9c227de to dd906d7 Increases (4 builds for esp32, linux)
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
add-move-to-closest-frequency
branch
from
June 2, 2022 17:01
dd906d7
to
5fb5db0
Compare
PR #19065: Size comparison from 0bf3ba4 to 5fb5db0 Increases (4 builds for esp32, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 2, 2022
woody-apple
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Command is missing from XML.
Change overview
Add it.
Testing
Examined the generated code.
Fixes #19036