-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Add contains/excludes constraints to TestConstraints.yaml #19042
Merged
vivien-apple
merged 5 commits into
project-chip:master
from
vivien-apple:YAML_ContainsExcludesSimpleList
Jun 3, 2022
Merged
[YAML] Add contains/excludes constraints to TestConstraints.yaml #19042
vivien-apple
merged 5 commits into
project-chip:master
from
vivien-apple:YAML_ContainsExcludesSimpleList
Jun 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
changed the title
Yaml contains excludes simple list
[YAML] Add contains/excludes constraints to TestConstraints.yaml
Jun 1, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
June 1, 2022 09:54
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 1, 2022 09:54
PR #19042: Size comparison from 8ef608d to a36bb06 Increases (2 builds for linux)
Full report (34 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, p6, telink)
|
vivien-apple
force-pushed
the
YAML_ContainsExcludesSimpleList
branch
from
June 1, 2022 14:12
a36bb06
to
3d9df1d
Compare
PR #19042: Size comparison from 393b319 to 3d9df1d Increases (2 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mrjerryjohns
approved these changes
Jun 1, 2022
bzbarsky-apple
approved these changes
Jun 1, 2022
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
...les/darwin-framework-tool/templates/tests/partials/checks/maybeCheckExpectedConstraints.zapt
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jun 1, 2022
vivien-apple
force-pushed
the
YAML_ContainsExcludesSimpleList
branch
from
June 2, 2022 12:11
3d9df1d
to
bb95b59
Compare
PR #19042: Size comparison from 2f6de7b to bb95b59 Increases (2 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
force-pushed
the
YAML_ContainsExcludesSimpleList
branch
from
June 2, 2022 18:02
bb95b59
to
43c918a
Compare
PR #19042: Size comparison from 6c4b54e to 43c918a Increases (2 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no mechanism to specify a subset of a list to check of inclusion/exclusion.
Fix #18041
Change overview
contains
andexcludes
which applies to list elementsTesting
A test for both methods has been added in
TestConstraints.yaml