Enforce maximum NONCE #19037
Merged
Enforce maximum NONCE #19037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
|
PR #19037: Size comparison from 5148b5d to 410b41d Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #19037: Size comparison from 8ef608d to a27f13b Increases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
|
/rebase |
andy31415
reviewed
Jun 1, 2022
andy31415
reviewed
Jun 1, 2022
bzbarsky-apple
approved these changes
Jun 2, 2022
|
PR #19037: Size comparison from 55ab764 to 4216fb2 Increases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
emargolis
approved these changes
Jun 8, 2022
turon
reviewed
Jun 8, 2022
There was a problem hiding this comment.
Looks good, thanks for making simplifications to AdvanceAndConsume per discussed with @andy31415.
turon
approved these changes
Jun 8, 2022
|
PR #19037: Size comparison from 10f620e to 69d4868 Increases (18 builds for cc13x2_26x2, linux)
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
turon
reviewed
Jun 9, 2022
| @@ -29,7 +29,7 @@ namespace chip { | |||
|
|
|||
| void GlobalUnencryptedMessageCounter::Init() | |||
| { | |||
| mValue = Crypto::GetRandU32(); | |||
| mLastUsedValue = Crypto::GetRandU32(); | |||
There was a problem hiding this comment.
I noticed this after merge, but the spec has all counters initializing to: 1 to 2^28.
turon
reviewed
Jun 9, 2022
| @@ -29,7 +29,7 @@ namespace chip { | |||
|
|
|||
| void GlobalUnencryptedMessageCounter::Init() | |||
| { | |||
| mValue = Crypto::GetRandU32(); | |||
| mLastUsedValue = Crypto::GetRandU32(); | |||
There was a problem hiding this comment.
I noticed this after merge, but the spec has all counters initializing to: (0 to 2^28) + 1.
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
* Enforce maximum NONCE * Add test-case * Resove conversations, fix comments * Resolve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #19011
Change overview
Stop sending packet for a session if the counter is exhausted.
Testing
Added a unit-test for regression check