Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esp32] support CHIP project config #19015

Merged
merged 2 commits into from
Jun 3, 2022
Merged

[esp32] support CHIP project config #19015

merged 2 commits into from
Jun 3, 2022

Conversation

agners
Copy link
Contributor

@agners agners commented May 31, 2022

Problem

There is no option to set a custom CHIP project config file to define compile time CHIP stack configuration values.

Change overview

Add support to specify a project config header file similar to other platforms. This allows to add CONFIG_CHIP_PROJECT_CONFIG to a projects sdkconfig, which points to a config header file.

Testing

Locally tested by building ESP32 firmwares.

@boring-cyborg boring-cyborg bot added the config label May 31, 2022
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

PR #19015: Size comparison from eb3ac83 to 277fc91

Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 277fc91 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648187 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84267 84267 0 0.0
.text 563684 563684 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615027 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73659 73659 0 0.0
.text 541132 541132 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163092 163092 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96211 96211 0 0.0
.text 583036 583036 0 0.0
lock-mtd LP_CC2652R7 (read only) 629147 629147 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96099 96099 0 0.0
.text 532556 532556 0 0.0
pump-app LP_CC2652R7 (read only) 676167 676167 0 0.0
(read/write) 167824 167824 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88687 88687 0 0.0
.text 586996 586996 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654087 654087 0 0.0
(read/write) 189760 189760 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83423 83423 0 0.0
.text 570184 570184 0 0.0
shell LP_CC2652R7 (read only) 641194 641194 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81250 81250 0 0.0
.text 559712 559712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621790 0 0.0
.app_xip_area 525368 525368 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630498 0 0.0
.app_xip_area 535548 535548 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914500 914500 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914492 914492 0 0.0
BRD4161A+rpc (read only) 948736 948736 0 0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948728 948728 0 0.0
BRD4161A+rs911x (read only) 789360 789360 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789352 789352 0 0.0
lock-app BRD4161A+wf200 (read only) 954460 954460 0 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954452 954452 0 0.0
window-app BRD4161A (read only) 899428 899428 0 0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899420 899420 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005482 0 0.0
(read/write) 1479602 1479602 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210368 0 0.0
.flash.text 1005482 1005482 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060687 1060687 0 0.0
(read/write) 481816 481816 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 240948 0 0.0
.flash.text 1055303 1055303 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680932 680932 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 597048 0 0.0
lock k32w061+release (read/write) 732420 732420 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648136 0 0.0
linux all-clusters-app debug (read only) 2769745 2769745 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243677 0 0.0
.text 2352114 2352114 0 0.0
all-clusters-minimal-app debug (read only) 2646865 2646865 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2228706 2228706 0 0.0
bridge-app debug+rpc (read only) 2030057 2030057 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168768 0 0.0
.text 1704770 1704770 0 0.0
chip-tool debug (read only) 9669565 9669565 0 0.0
(read/write) 600848 600848 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569472 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496285 0 0.0
.text 7784261 7784261 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9413852 0 0.0
(read/write) 667105 667105 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604872 0 0.0
.dynamic 528 528 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 459972 0 0.0
.text 7429556 7429556 0 0.0
lighting-app debug+rpc (read only) 2319889 2319889 0 0.0
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 187720 0 0.0
.text 1966418 1966418 0 0.0
lock-app debug (read only) 2258649 2258649 0 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1897426 1897426 0 0.0
ota-provider-app debug (read only) 2067729 2067729 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180184 0 0.0
.text 1728450 1728450 0 0.0
ota-requestor-app debug (read only) 2096529 2096529 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176256 0 0.0
.text 1759714 1759714 0 0.0
shell debug (read only) 2573833 2573833 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223794 0 0.0
.text 2190594 2190594 0 0.0
thermostat-no-ble arm64 (read only) 2366708 2366708 0 0.0
(read/write) 177441 177441 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148164 0 0.0
.text 1988912 1988912 0 0.0
tv-app debug (read only) 2876433 2876433 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222112 0 0.0
.text 2471714 2471714 0 0.0
tv-casting-app debug (read only) 5434009 5434009 0 0.0
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339808 0 0.0
.text 4734562 4734562 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2425016 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186455 0 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814672 814672 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135171 0 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787672 787672 0 0.0
p6 all-clusters-app default (read/write) 2540960 2540960 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499224 0 0.0
all-clusters-minimal-app default (read/write) 2486928 2486928 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445192 0 0.0
light-app default (read/write) 2420872 2420872 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379136 0 0.0
lock-app default (read/write) 2438912 2438912 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397176 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779596 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551404 0 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799640 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568146 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking platform changes

@andy31415 andy31415 merged commit 84540b6 into project-chip:master Jun 3, 2022
@agners agners deleted the esp32-support-chip-project-config branch June 29, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
config fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agners @woody-apple @andy31415 @bzbarsky-apple