Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chip-tool] Add --repeat-count and --repeat-delay-ms to write commands #18999

Conversation

vivien-apple
Copy link
Contributor

Problem

Add --repeat-count and --repeat-delay-ms to write commands for chip-tool

Fix #18601

@bzbarsky-apple Similar to the YAML way. This is not exactly doing what the test step says in the sense that we don't really know if the "status response message" has been received but in practice it does the job...

Change overview

  • Add --repeat-count and --repeat-delay-ms to write commands for chip-tool

Testing

I tried to do:
./out/debug/standalone/chip-tool testcluster write timed-write-boolean false 0x12344321 1 --timedInteractionTimeoutMs 200 --repeat-count 1 --repeat-delay-ms 5000
./out/debug/standalone/chip-tool administratorcommissioning open-basic-commissioning-window 180 0x12344321 0 --timedInteractionTimeoutMs 200 --repeat-count 1 --repeat-delay-ms 5000

@github-actions
Copy link

github-actions bot commented May 31, 2022

PR #18999: Size comparison from 5121bf8 to e495469

Increases above 0.2%:

platform target config section 5121bf8 e495469 change % change
linux chip-tool debug (read only) 9681005 9703277 22272 0.2
.text 7791253 7813525 22272 0.3
Increases (2 builds for linux)
platform target config section 5121bf8 e495469 change % change
linux chip-tool debug (read only) 9681005 9703277 22272 0.2
.text 7791253 7813525 22272 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9424220 9441628 17408 0.2
.text 7435396 7452804 17408 0.2
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5121bf8 e495469 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648371 648371 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84267 84267 0 0.0
.text 563868 563868 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615211 615211 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73659 73659 0 0.0
.text 541316 541316 0 0.0
lock-ftd LP_CC2652R7 (read only) 679915 679915 0 0.0
(read/write) 162908 162908 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96211 96211 0 0.0
.text 583220 583220 0 0.0
lock-mtd LP_CC2652R7 (read only) 629331 629331 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96099 96099 0 0.0
.text 532740 532740 0 0.0
pump-app LP_CC2652R7 (read only) 676351 676351 0 0.0
(read/write) 167640 167640 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88687 88687 0 0.0
.text 587180 587180 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654271 654271 0 0.0
(read/write) 189576 189576 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83423 83423 0 0.0
.text 570368 570368 0 0.0
shell LP_CC2652R7 (read only) 641378 641378 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81250 81250 0 0.0
.text 559896 559896 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621958 621958 0 0.0
.app_xip_area 525536 525536 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630658 630658 0 0.0
.app_xip_area 535708 535708 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914900 914900 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914892 914892 0 0.0
BRD4161A+rpc (read only) 949152 949152 0 0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949144 949144 0 0.0
BRD4161A+rs911x (read only) 789360 789360 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789352 789352 0 0.0
lock-app BRD4161A+wf200 (read only) 954460 954460 0 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954452 954452 0 0.0
window-app BRD4161A (read only) 899828 899828 0 0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899820 899820 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005550 1005550 0 0.0
(read/write) 1479602 1479602 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210368 0 0.0
.flash.text 1005550 1005550 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060719 1060719 0 0.0
(read/write) 481816 481816 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 240948 0 0.0
.flash.text 1055335 1055335 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681124 681124 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597240 597240 0 0.0
lock k32w061+release (read/write) 732612 732612 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648328 648328 0 0.0
linux all-clusters-app debug (read only) 2769793 2769793 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243677 0 0.0
.text 2352162 2352162 0 0.0
all-clusters-minimal-app debug (read only) 2646913 2646913 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2228754 2228754 0 0.0
bridge-app debug+rpc (read only) 2030105 2030105 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168768 0 0.0
.text 1704818 1704818 0 0.0
chip-tool debug (read only) 9681005 9703277 22272 0.2
(read/write) 602736 602736 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571360 571360 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496317 496317 0 0.0
.text 7791253 7813525 22272 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9424220 9441628 17408 0.2
(read/write) 669009 669009 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606760 606760 0 0.0
.dynamic 528 528 0 0.0
.got 15008 15008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460036 460036 0 0.0
.text 7435396 7452804 17408 0.2
lighting-app debug+rpc (read only) 2318657 2318657 0 0.0
(read/write) 153504 153504 0 0.0
.bss 74720 74720 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187400 187400 0 0.0
.text 1965506 1965506 0 0.0
lock-app debug (read only) 2258713 2258713 0 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1897490 1897490 0 0.0
ota-provider-app debug (read only) 2067777 2067777 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180184 0 0.0
.text 1728498 1728498 0 0.0
ota-requestor-app debug (read only) 2096577 2096577 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176256 0 0.0
.text 1759762 1759762 0 0.0
shell debug (read only) 2573897 2573897 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223794 0 0.0
.text 2190658 2190658 0 0.0
thermostat-no-ble arm64 (read only) 2366756 2366756 0 0.0
(read/write) 177441 177441 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148164 0 0.0
.text 1988960 1988960 0 0.0
tv-app debug (read only) 2876481 2876481 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222112 0 0.0
.text 2471762 2471762 0 0.0
tv-casting-app debug (read only) 5438185 5438185 0 0.0
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339808 0 0.0
.text 4738738 4738738 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2425016 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186615 1186615 0 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814836 814836 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135331 1135331 0 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787836 787836 0 0.0
p6 all-clusters-app default (read/write) 2540960 2540960 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499224 0 0.0
all-clusters-minimal-app default (read/write) 2486928 2486928 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445192 0 0.0
light-app default (read/write) 2420872 2420872 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379136 0 0.0
lock-app default (read/write) 2438912 2438912 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397176 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779820 779820 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551624 551624 0 0.0
lighting-app tlsr9518adk80d (read/write) 799864 799864 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568366 568366 0 0.0

@andy31415 andy31415 merged commit d7b84a2 into project-chip:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TC-IDM-5.2]-Chip-tool needs to provide a way to set delayed write request to verify the step 3
3 participants