-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add --repeat-count and --repeat-delay-ms to write commands #18999
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_RepeatCountRepeatDelayMsWriteCommand
Jun 2, 2022
Merged
[chip-tool] Add --repeat-count and --repeat-delay-ms to write commands #18999
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_RepeatCountRepeatDelayMsWriteCommand
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel and
lazarkov
May 31, 2022 15:27
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple and
xylophone21
May 31, 2022 15:27
andy31415
reviewed
May 31, 2022
PR #18999: Size comparison from 5121bf8 to e495469 Increases above 0.2%:
Increases (2 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 2, 2022
andy31415
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add
--repeat-count
and--repeat-delay-ms
to write commands forchip-tool
Fix #18601
@bzbarsky-apple Similar to the YAML way. This is not exactly doing what the test step says in the sense that we don't really know if the "status response message" has been received but in practice it does the job...
Change overview
--repeat-count
and--repeat-delay-ms
to write commands forchip-tool
Testing
I tried to do:
./out/debug/standalone/chip-tool testcluster write timed-write-boolean false 0x12344321 1 --timedInteractionTimeoutMs 200 --repeat-count 1 --repeat-delay-ms 5000
./out/debug/standalone/chip-tool administratorcommissioning open-basic-commissioning-window 180 0x12344321 0 --timedInteractionTimeoutMs 200 --repeat-count 1 --repeat-delay-ms 5000