-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Allow hex: prefix for octet strings #18996
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_AllowHexPrefix
Jun 1, 2022
Merged
[YAML] Allow hex: prefix for octet strings #18996
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_AllowHexPrefix
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda and
mlepage-google
May 31, 2022 14:58
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 31, 2022 14:58
PR #18996: Size comparison from 5121bf8 to ffacd24 Increases (2 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 31, 2022
tcarmelveilleux
approved these changes
Jun 1, 2022
bzbarsky-apple
approved these changes
Jun 1, 2022
vivien-apple
force-pushed
the
YAML_AllowHexPrefix
branch
from
June 1, 2022 10:19
ffacd24
to
77045f9
Compare
PR #18996: Size comparison from 8ef608d to 77045f9 Increases (2 builds for linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
vivien-apple
force-pushed
the
YAML_AllowHexPrefix
branch
from
June 1, 2022 14:10
77045f9
to
925e5dd
Compare
PR #18996: Size comparison from 393b319 to 925e5dd Increases (2 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Octet strings can not be specified using the
hex:
notation.Change overview
hex:
prefix for octet stringsTesting
A test has been added to TestCluster.