-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] vscode and development container fix #18939
Merged
arkq
merged 7 commits into
project-chip:master
from
jlatusek:devcontainer-tizen-sdk-fix
May 31, 2022
Merged
[Tizen] vscode and development container fix #18939
arkq
merged 7 commits into
project-chip:master
from
jlatusek:devcontainer-tizen-sdk-fix
May 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
May 30, 2022 11:07
pullapprove
bot
requested review from
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
May 30, 2022 11:07
PR #18939: Size comparison from 4d84a4a to 738fec7 Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 30, 2022
arkq
approved these changes
May 30, 2022
andy31415
approved these changes
May 30, 2022
PR #18939: Size comparison from 4d84a4a to 3115bad Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
* Remove automatic certificate generation and security profiles with hardcoded passwords from docker images. * Describe building the Tizen lighting-app app with the author certificate and security profile generation process.
jlatusek
force-pushed
the
devcontainer-tizen-sdk-fix
branch
from
May 31, 2022 10:10
3115bad
to
5244626
Compare
jlatusek
changed the title
[Tizen] Devcontainer fix
[Tizen] vscode and development container fix
May 31, 2022
* update tizen app call to use the full path * describe regeneration of author certificates
jlatusek
force-pushed
the
devcontainer-tizen-sdk-fix
branch
from
May 31, 2022 12:42
6dbd436
to
5ab4c86
Compare
arkq
approved these changes
May 31, 2022
PR #18939: Size comparison from 6ef806b to 5ab4c86 Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The vscode container has the wrong order of environment variables and not all of them are created correctly. Certificates are generated with a hardcoded password.
The Tizen SDK has the wrong configuration in the devcontainer image.
Change overview
Testing
Build chip-build-vscode image