-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Only supply DelayActionTime field for busy status response #18912
Merged
tcarmelveilleux
merged 1 commit into
project-chip:master
from
carol-apple:ota_provider_delayactiontime_busy
May 28, 2022
Merged
[OTA] Only supply DelayActionTime field for busy status response #18912
tcarmelveilleux
merged 1 commit into
project-chip:master
from
carol-apple:ota_provider_delayactiontime_busy
May 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver and
robszewczyk
May 27, 2022 21:16
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
May 27, 2022 21:16
carol-apple
force-pushed
the
ota_provider_delayactiontime_busy
branch
from
May 27, 2022 21:18
b22f7c6
to
d41a307
Compare
isiu-apple
approved these changes
May 27, 2022
tcarmelveilleux
approved these changes
May 27, 2022
PR #18912: Size comparison from 67a9f1e to d41a307 Increases (1 build for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per spec change at https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5248, the language clearly states:
Change overview
Only include
DelayedActionTime
field when status is busyTesting
Available
, there is noDelayedActionTime
includedNotAvailable
, there is noDelayedActionTime
includedBusy
,DelayedActionTime
is included