Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTA] Only supply DelayActionTime field for busy status response #18912

Conversation

carol-apple
Copy link
Contributor

Problem

Per spec change at https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5248, the language clearly states:

The `DelayedActionTime` field SHALL only be present if the `Status` field is set to Busy.

Change overview

Only include DelayedActionTime field when status is busy

Testing

  • When status is Available, there is no DelayedActionTime included
  • When status is NotAvailable, there is no DelayedActionTime included
  • When status is Busy, DelayedActionTime is included

@carol-apple carol-apple force-pushed the ota_provider_delayactiontime_busy branch from b22f7c6 to d41a307 Compare May 27, 2022 21:18
@github-actions
Copy link

github-actions bot commented May 27, 2022

PR #18912: Size comparison from 67a9f1e to d41a307

Increases (1 build for linux)
platform target config section 67a9f1e d41a307e change % change
linux ota-provider-app debug (read only) 2066673 2066689 16 0.0
.text 1728146 1728162 16 0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 67a9f1e d41a307e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645159 645159 0 0.0
(read/write) 159168 159168 0 0.0
.bss 74852 74852 0 0.0
.data 3400 3400 0 0.0
.rodata 83799 83799 0 0.0
.text 561124 561124 0 0.0
lock-ftd LP_CC2652R7 (read only) 679455 679455 0 0.0
(read/write) 163640 163640 0 0.0
.bss 72876 72876 0 0.0
.data 3264 3264 0 0.0
.rodata 96087 96087 0 0.0
.text 582884 582884 0 0.0
lock-mtd LP_CC2652R7 (read only) 628855 628855 0 0.0
(read/write) 145992 145992 0 0.0
.bss 68612 68612 0 0.0
.data 3264 3264 0 0.0
.rodata 95967 95967 0 0.0
.text 532396 532396 0 0.0
pump-app LP_CC2652R7 (read only) 675883 675883 0 0.0
(read/write) 168380 168380 0 0.0
.bss 73276 73276 0 0.0
.data 3300 3300 0 0.0
.rodata 88563 88563 0 0.0
.text 586836 586836 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653811 653811 0 0.0
(read/write) 190308 190308 0 0.0
.bss 73132 73132 0 0.0
.data 3260 3260 0 0.0
.rodata 83307 83307 0 0.0
.text 570024 570024 0 0.0
shell LP_CC2652R7 (read only) 638166 638166 0 0.0
(read/write) 154724 154724 0 0.0
.bss 77204 77204 0 0.0
.data 3404 3404 0 0.0
.rodata 80774 80774 0 0.0
.text 557160 557160 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621682 621682 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 79376 79376 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630382 630382 0 0.0
.app_xip_area 535120 535120 0 0.0
.bss 77936 77936 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570758 0 0.0
.app_xip_area 465816 465816 0 0.0
.bss 87296 87296 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914168 914168 0 0.0
(read/write) 133464 133464 0 0.0
.bss 131368 131368 0 0.0
.data 2092 2092 0 0.0
.text 914160 914160 0 0.0
BRD4161A+rpc (read only) 948340 948340 0 0.0
(read/write) 150152 150152 0 0.0
.bss 147856 147856 0 0.0
.data 2296 2296 0 0.0
.text 948332 948332 0 0.0
BRD4161A+rs911x (read only) 788740 788740 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127636 127636 0 0.0
.data 2100 2100 0 0.0
.text 788732 788732 0 0.0
lock-app BRD4161A+wf200 (read only) 954024 954024 0 0.0
(read/write) 128508 128508 0 0.0
.bss 126444 126444 0 0.0
.data 2064 2064 0 0.0
.text 954016 954016 0 0.0
window-app BRD4161A (read only) 899112 899112 0 0.0
(read/write) 133520 133520 0 0.0
.bss 131432 131432 0 0.0
.data 2088 2088 0 0.0
.text 899104 899104 0 0.0
esp32 all-clusters-app c3devkit (read only) 1002368 1002368 0 0.0
(read/write) 1479378 1479378 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14640 14640 0 0.0
.flash.rodata 209888 209888 0 0.0
.flash.text 1002368 1002368 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057639 1057639 0 0.0
(read/write) 481632 481632 0 0.0
.dram0.bss 74944 74944 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240484 240484 0 0.0
.flash.text 1052255 1052255 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680892 680892 0 0.0
.bss 80440 80440 0 0.0
.data 2008 2008 0 0.0
.text 596740 596740 0 0.0
lock k32w061+release (read/write) 732244 732244 0 0.0
.bss 80872 80872 0 0.0
.data 1976 1976 0 0.0
.text 647692 647692 0 0.0
linux all-clusters-app debug (read only) 2751513 2751513 0 0.0
(read/write) 178336 178336 0 0.0
.bss 86528 86528 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83608 83608 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 242237 242237 0 0.0
.text 2335682 2335682 0 0.0
bridge-app debug+rpc (read only) 2024049 2024049 0 0.0
(read/write) 148024 148024 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65320 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168288 168288 0 0.0
.text 1699602 1699602 0 0.0
chip-tool debug (read only) 9680277 9680277 0 0.0
(read/write) 602512 602512 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571136 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497245 497245 0 0.0
.text 7790389 7790389 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423804 9423804 0 0.0
(read/write) 668833 668833 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606528 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460932 460932 0 0.0
.text 7434740 7434740 0 0.0
lighting-app debug+rpc (read only) 2314433 2314433 0 0.0
(read/write) 153632 153632 0 0.0
.bss 75008 75008 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70824 70824 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186984 186984 0 0.0
.text 1962082 1962082 0 0.0
lock-app debug (read only) 2253545 2253545 0 0.0
(read/write) 148728 148728 0 0.0
.bss 73696 73696 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67752 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200360 200360 0 0.0
.text 1893250 1893250 0 0.0
ota-provider-app debug (read only) 2066673 2066689 16 0.0
(read/write) 141456 141456 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60824 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179960 179960 0 0.0
.text 1728146 1728162 16 0.0
ota-requestor-app debug (read only) 2095921 2095921 0 0.0
(read/write) 144296 144296 0 0.0
.bss 73760 73760 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 62920 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176000 176000 0 0.0
.text 1759890 1759890 0 0.0
shell debug (read only) 2555873 2555873 0 0.0
(read/write) 201840 201840 0 0.0
.bss 117448 117448 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222418 222418 0 0.0
.text 2174370 2174370 0 0.0
thermostat-no-ble arm64 (read only) 2359852 2359852 0 0.0
(read/write) 177585 177585 0 0.0
.bss 88209 88209 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 80008 80008 0 0.0
.dynamic 560 560 0 0.0
.got 4808 4808 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147532 147532 0 0.0
.text 1982976 1982976 0 0.0
tv-app debug (read only) 2875185 2875185 0 0.0
(read/write) 280464 280464 0 0.0
.bss 191368 191368 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78152 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221888 221888 0 0.0
.text 2470882 2470882 0 0.0
tv-casting-app debug (read only) 5426129 5426129 0 0.0
(read/write) 226160 226160 0 0.0
.bss 78952 78952 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138576 138576 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339136 339136 0 0.0
.text 4728098 4728098 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2423984 2423984 0 0.0
.bss 202892 202892 0 0.0
.data 5872 5872 0 0.0
.text 1386628 1386628 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183455 1183455 0 0.0
bss 139552 139552 0 0.0
rodata 153128 153128 0 0.0
text 811896 811896 0 0.0
p6 all-clusters-app default (read/write) 2536840 2536840 0 0.0
.bss 137376 137376 0 0.0
.data 2800 2800 0 0.0
.text 1495104 1495104 0 0.0
light-app default (read/write) 2420096 2420096 0 0.0
.bss 129712 129712 0 0.0
.data 2600 2600 0 0.0
.text 1378360 1378360 0 0.0
lock-app default (read/write) 2438144 2438144 0 0.0
.bss 129520 129520 0 0.0
.data 2568 2568 0 0.0
.text 1396408 1396408 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779604 779604 0 0.0
bss 70840 70840 0 0.0
noinit 40416 40416 0 0.0
text 551264 551264 0 0.0
lighting-app tlsr9518adk80d (read/write) 799636 799636 0 0.0
bss 71100 71100 0 0.0
noinit 40416 40416 0 0.0
text 567998 567998 0 0.0

@tcarmelveilleux tcarmelveilleux merged commit 01a424f into project-chip:master May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants