-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MemoryInit and MemoryShutdown Platform APIs threadsafe #18854
Merged
woody-apple
merged 1 commit into
project-chip:master
from
harsha-rajendran:Make-MemoryInit-and-MemoryShutdown-APIs-threadsafe
Jun 2, 2022
Merged
Make MemoryInit and MemoryShutdown Platform APIs threadsafe #18854
woody-apple
merged 1 commit into
project-chip:master
from
harsha-rajendran:Make-MemoryInit-and-MemoryShutdown-APIs-threadsafe
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
May 26, 2022 17:42
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 26, 2022 17:42
PR #18854: Size comparison from 8338f25 to 4ce1415 Increases above 0.2%:
Increases (24 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cyw30739)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 26, 2022
harsha-rajendran
force-pushed
the
Make-MemoryInit-and-MemoryShutdown-APIs-threadsafe
branch
from
May 26, 2022 20:12
4ce1415
to
791c81e
Compare
PR #18854: Size comparison from 3956a9d to 791c81e Increases above 0.2%:
Increases (34 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cyw30739)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 2, 2022
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 3, 2022
…roject-chip#18854)" This reverts commit 19d826a. The PR causes esp32 to boot-loop. Fixes project-chip#19142
andy31415
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix #18675
Change overview
Lock the memory alloc/shutdown platform APIs properly to prevent race conditions as stated in 18675.
Testing
Sanity testing by ensuring OTA transfer works on Linux