-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Event Trigger implementation for General Diagnostics Cluster #18807
Merged
tehampson
merged 5 commits into
project-chip:master
from
tehampson:test-event-triggers-18322
May 26, 2022
Merged
Test Event Trigger implementation for General Diagnostics Cluster #18807
tehampson
merged 5 commits into
project-chip:master
from
tehampson:test-event-triggers-18322
May 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
commented
May 25, 2022
PR #18807: Size comparison from 054d820 to 4026716 Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18807: Size comparison from 054d820 to 0e93e8a Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 25, 2022
tcarmelveilleux
approved these changes
May 25, 2022
andy31415
reviewed
May 26, 2022
tehampson
force-pushed
the
test-event-triggers-18322
branch
from
May 26, 2022 13:32
a90eb40
to
b4a22b7
Compare
PR #18807: Size comparison from b5a967c to b4a22b7 Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
May 26, 2022 14:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Untested since it is an interface header file that is added