-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC: Add RPCs to ota-requester app on ESP32 #18760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
May 24, 2022 15:15
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
May 24, 2022 15:15
PR #18760: Size comparison from 09bb6fd to 3464049 Increases (3 builds for efr32, linux, mbed)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18760: Size comparison from 653f19f to e23edf6 Increases (3 builds for efr32, linux, mbed)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18760: Size comparison from 8c37a84 to f0a249c Increases (3 builds for efr32, linux, mbed)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18760: Size comparison from b5a967c to b133c4d Increases (3 builds for efr32, linux, mbed)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18760: Size comparison from 3956a9d to be6c4c3 Increases (3 builds for efr32, linux, mbed)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18760: Size comparison from 3956a9d to d45ed5c Increases (2 builds for linux, mbed)
Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18760: Size comparison from 700d92e to e6909ee Increases (2 builds for linux, mbed)
Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
- Add RPC target to the esp32 requester example. - Implement TriggerOta rpc which triggers the OTA request from the provider.
PR #18760: Size comparison from 393b319 to 6d9aee3 Increases (3 builds for efr32, linux, mbed)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jun 1, 2022
rgoliver
pushed a commit
to rgoliver/connectedhomeip
that referenced
this pull request
Jul 20, 2022
- Add RPC target to the esp32 requester example. - Implement TriggerOta rpc which triggers the OTA request from the provider.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 21, 2022
- Add RPC target to the esp32 requester example. - Implement TriggerOta rpc which triggers the OTA request from the provider.
cpagravel
added a commit
to nestlabs/connectedhomeip
that referenced
this pull request
Jul 22, 2022
…lds (#4) * RPC: Add RPCs to ota-requester app on ESP32 (project-chip#18760) - Add RPC target to the esp32 requester example. - Implement TriggerOta rpc which triggers the OTA request from the provider. * Add m5stack build configs for ota-requestor app (project-chip#19702) * Add m5stack build configs for ota-requestor app * Update build target testdata * Chef - Separate Chef build noip into separate step (project-chip#21011) * Software version string on nrf while doing automation testing (project-chip#20939) * Software version string on efr32 chef build while doing automation testing (project-chip#20982) Add new config['silabs-thread']['EFR32_BOARD'] in config.yaml * Chef - Add automated_test_stamp to Chef CD builds (project-chip#21059) Co-authored-by: rgoliver <[email protected]> Co-authored-by: Colin Tan <[email protected]> Co-authored-by: MtTsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TriggerOta RPC in the device service is unimplemented.
Change overview
Testing
Tested the included ESP32 requester example, commissioned and verified the TriggerOta RPC worked as expected.