Fix multiple subscriptions to the same attribute in chip-tool. #18758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the command object is the same for subscriptions to the same attribute, we were reusing the same mSubscribeClient unique_ptr for the new subscription, which killed off the old one. The changes here are as follows: 1) Keep track of a list of subscribe clients in InteractionModelReports. 2) To fix a (pre-existing) issue where we would crash on exit from interactive mode if we had alive subscription, introduce a Cleanup function on CHIPCommand which is called either immediately after Shutdown or when we exit interactive mode, depending on what the command wants. 3) Rearrange the attribute/event read/report commands to make sure we handle cleanup correctly and don't leak ReadClients (even temporarily, in the error cases). Fixes project-chip#18245
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
vivien-apple
approved these changes
May 24, 2022
|
PR #18758: Size comparison from 7582608 to 7e30c37 Increases above 0.2%:
Increases (2 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the command object is the same for subscriptions to the same attribute, we were reusing the same mSubscribeClient unique_ptr for the new subscription, which killed off the old one.
The changes here are as follows:
interactive mode if we had alive subscription, introduce a Cleanup
function on CHIPCommand which is called either immediately after
Shutdown or when we exit interactive mode, depending on what the
command wants.
handle cleanup correctly and don't leak ReadClients (even
temporarily, in the error cases).
Fixes #18245
Problem
See above.
Change overview
See above.
Testing
Used steps from #18245.