-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the model command destination id. #18704
Merged
isiu-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:destination-id-docs
May 21, 2022
Merged
Add documentation for the model command destination id. #18704
isiu-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:destination-id-docs
May 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the documentation explains what it is, rename from the unwieldy "node-id/group-id" to "destination-id".
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran and
isiu-apple
May 21, 2022 02:15
pullapprove
bot
requested review from
mlepage-google,
turon,
vijs,
msandstedt,
mspang,
robszewczyk,
vivien-apple,
sagar-apple,
wbschiller,
saurabhst,
woody-apple,
selissia,
xylophone21,
tecimovic and
yufengwangca
May 21, 2022 02:15
PR #18704: Size comparison from 55ef609 to 5c9b150 Increases (2 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
May 21, 2022
isiu-apple
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the documentation explains what it is, rename from the unwieldy
"node-id/group-id" to "destination-id".
Problem
No docs.
Change overview
Add docs.
Testing
Ran a command without sufficient args, saw the help text.