Implement sending message from the linux layer of the android tv-app::platform-app to the tv-app::content-app #18696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #18696: Size comparison from 55ef609 to 22ba274 Full report (35 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #18696: Size comparison from 55ef609 to 0b796aa Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chrisdecenzo
approved these changes
May 21, 2022
examples/tv-app/android/include/content-launcher/AppContentLauncherManager.cpp
Show resolved
Hide resolved
nicelyjust
reviewed
May 23, 2022
…:platform-app to the tv-app::content-app. Resolving conflicts
…l checks for hardcoded sample apps.
commit bde9a1b Author: Restyled.io <[email protected]> Date: Fri May 20 22:25:44 2022 +0000 Restyled by clang-format commit 27c0f3d Author: Restyled.io <[email protected]> Date: Fri May 20 22:25:33 2022 +0000 Restyled by google-java-format commit 56bb8b4 Author: Restyled.io <[email protected]> Date: Fri May 20 22:25:15 2022 +0000 Restyled by whitespace commit 22ba274 Author: Amit Jain <[email protected]> Date: Fri May 20 15:15:45 2022 -0700 Implement sending message from the linux layer of the android tv-app::platform-app to the tv-app::content-app.
|
PR #18696: Size comparison from 653f19f to 34b5936 Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Messages coming to the tv-app::platform-app were not being forwarded to the content-app. They worked only for the endpoint 1 and not for the content app endpoints.
Change overview
Created the required JNI channels to get the message to the java layer and then on to the content app using the intent mechanism introduced earlier. Also modified the discovery mechanism to add the content apps discovered to the ContentAppPlatform of the core matter SDK which would enable these apps having their own endpoints which can be targeted.
Testing
Manually tested using the UI affordances built in the tv-app::platform-app. Introduced a mechanism to invoke the full message communication from the command handlers to the content app using that UI.