Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZAP to fix incoming/outgoing command lists. #18674

Merged
merged 1 commit into from
May 20, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

We had some response commands flagged as incoming commands, because
they had the wrong flags mask.

Fixes #17809

Fixes #17688

Fixes #18002

Fixes #18121

Problem

See above.

Change overview

Pull an updated ZAP.

Testing

Examined the generated code changes.

We had some response commands flagged as incoming commands, because
they had the wrong flags mask.

Fixes project-chip#17809

Fixes project-chip#17688

Fixes project-chip#18002

Fixes project-chip#18121
@andy31415
Copy link
Contributor

fast track: automated changes and 3rd party repo update only.

@github-actions
Copy link

github-actions bot commented May 20, 2022

PR #18674: Size comparison from 3e40014 to 262454b

Increases (2 builds for cc13x2_26x2)
platform target config section 3e40014 262454b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 184204 184220 16 0.0
shell LP_CC2652R7 (read/write) 186684 186700 16 0.0
Decreases (7 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)
platform target config section 3e40014 262454b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666483 666467 -16 -0.0
.rodata 99611 99595 -16 -0.0
shell LP_CC2652R7 (read only) 659562 659546 -16 -0.0
.rodata 96578 96562 -16 -0.0
esp32 all-clusters-app c3devkit (read/write) 1477442 1477426 -16 -0.0
.flash.rodata 209136 209120 -16 -0.0
m5stack (read/write) 479452 479436 -16 -0.0
.flash.rodata 239504 239488 -16 -0.0
linux thermostat-no-ble arm64 (read only) 2354116 2354108 -8 -0.0
.rodata 147332 147324 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180075 1180063 -12 -0.0
rodata 152340 152328 -12 -0.0
p6 all-clusters-app default (read/write) 2537888 2537880 -8 -0.0
.text 1496152 1496144 -8 -0.0
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3e40014 262454b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666483 666467 -16 -0.0
(read/write) 184204 184220 16 0.0
.bss 73668 73668 0 0.0
.data 3404 3404 0 0.0
.rodata 99611 99595 -16 -0.0
.text 566644 566644 0 0.0
lock-ftd LP_CC2652R7 (read only) 676315 676315 0 0.0
(read/write) 166340 166340 0 0.0
.bss 72692 72692 0 0.0
.data 3236 3236 0 0.0
.rodata 94379 94379 0 0.0
.text 581452 581452 0 0.0
lock-mtd LP_CC2652R7 (read only) 625139 625139 0 0.0
(read/write) 145524 145524 0 0.0
.bss 68428 68428 0 0.0
.data 3236 3236 0 0.0
.rodata 94267 94267 0 0.0
.text 530380 530380 0 0.0
pump-app LP_CC2652R7 (read only) 659595 659595 0 0.0
(read/write) 184340 184340 0 0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 79371 79371 0 0.0
.text 579744 579744 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654083 654083 0 0.0
(read/write) 189660 189660 0 0.0
.bss 73012 73012 0 0.0
.data 3232 3232 0 0.0
.rodata 83475 83475 0 0.0
.text 570128 570128 0 0.0
shell LP_CC2652R7 (read only) 659562 659546 -16 -0.0
(read/write) 186684 186700 16 0.0
.bss 76028 76028 0 0.0
.data 3408 3408 0 0.0
.rodata 96578 96562 -16 -0.0
.text 562760 562760 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624306 624306 0 0.0
.app_xip_area 527920 527920 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627126 627126 0 0.0
.app_xip_area 532196 532196 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571030 571030 0 0.0
.app_xip_area 466384 466384 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916652 916652 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 916644 916644 0 0.0
BRD4161A+rpc (read only) 950824 950824 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 950816 950816 0 0.0
BRD4161A+rs911x (read only) 790084 790084 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 790076 790076 0 0.0
lock-app BRD4161A+wf200 (read only) 946204 946204 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 946196 946196 0 0.0
window-app BRD4161A (read only) 897924 897924 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897916 897916 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000454 1000454 0 0.0
(read/write) 1477442 1477426 -16 -0.0
.dram0.bss 68232 68232 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 209136 209120 -16 -0.0
.flash.text 1000454 1000454 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1055815 1055815 0 0.0
(read/write) 479452 479436 -16 -0.0
.dram0.bss 73752 73752 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 239504 239488 -16 -0.0
.flash.text 1050431 1050431 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682204 682204 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 598260 598260 0 0.0
lock k32w061+release (read/write) 728352 728352 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 644016 644016 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9196052 9196052 0 0.0
(read/write) 645297 645297 0 0.0
.bss 42225 42225 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583048 583048 0 0.0
.dynamic 560 560 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 446036 446036 0 0.0
.text 7288116 7288116 0 0.0
thermostat-no-ble arm64 (read only) 2354116 2354108 -8 -0.0
(read/write) 176321 176321 0 0.0
.bss 87617 87617 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147332 147324 -8 -0.0
.text 1977904 1977904 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418432 2418432 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1381076 1381076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180075 1180063 -12 -0.0
bss 138400 138400 0 0.0
rodata 152340 152328 -12 -0.0
text 810484 810484 0 0.0
p6 all-clusters-app default (read/write) 2537888 2537880 -8 -0.0
.bss 136200 136200 0 0.0
.data 2808 2808 0 0.0
.text 1496152 1496144 -8 -0.0
light-app default (read/write) 2424104 2424104 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1382368 1382368 0 0.0
lock-app default (read/write) 2434792 2434792 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1393056 1393056 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781564 781564 0 0.0
bss 70616 70616 0 0.0
noinit 40416 40416 0 0.0
text 552934 552934 0 0.0
lighting-app tlsr9518adk80d (read/write) 801644 801644 0 0.0
bss 70872 70872 0 0.0
noinit 40416 40416 0 0.0
text 569700 569700 0 0.0

@andy31415 andy31415 merged commit 64129bb into project-chip:master May 20, 2022
@bzbarsky-apple bzbarsky-apple deleted the update-zap branch May 20, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants