Fix clusterStateCache dataVersion bug #18593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton and
jepenven-silabs
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #18593: Size comparison from 70e259c to 29dd861 Increases (1 build for linux)
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
force-pushed
the
feature/not_cache_if_specific_attribute
branch
from
29dd861 to
60f5883
Compare
|
PR #18593: Size comparison from 3ef81a8 to 60f5883 Increases (3 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
--if there exists any path in the request that references a specific attribute, remove affacted wildcard cluster attribute in requestPathSet used in cached so that we would not cache the dataVersion for all clusters affected by that attribute.
yunhanw-google
force-pushed
the
feature/not_cache_if_specific_attribute
branch
from
232201a to
5893403
Compare
yunhanw-google
force-pushed
the
feature/not_cache_if_specific_attribute
branch
from
5893403 to
b958468
Compare
bzbarsky-apple
approved these changes
May 20, 2022
|
PR #18593: Size comparison from fd84c37 to b958468 Increases (1 build for linux)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
approved these changes
May 20, 2022
yufengwangca
approved these changes
May 20, 2022
|
PR #18593: Size comparison from fd84c37 to cf60e94 Increases above 0.2%:
Increases (1 build for linux)
Decreases (5 builds for cyw30739, esp32, telink)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We cannot handle dataVersion cache for two paths: (E1, C1, wildcard), (wildcard, C1, A1).
Change overview
if there exists any path in the request that references a specific attribute, remove affacted wildcard cluster attribute in requestPathSet used in cached so that we would not cache the dataVersion for all clusters affected by that attribute.
note: in the worst case, referencing a global attribute in any path in the request with wildcard for cluster would effectively disable all data version caching
Testing
Add the test with paths (E1, C1, wildcard), (wildcard, C1, A1), we would not cache the version for E1C1