Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include what you use: add direct includes in files #18570

Merged
merged 12 commits into from
May 19, 2022
Merged

Include what you use: add direct includes in files #18570

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9118e7c
Add missing include in chip-zcl-zpro-codec.h
wendythewan May 18, 2022
37a6cef
Add missing include in AttributePathIB.h
wendythewan May 18, 2022
1e604e5
Add missing include in ClusterPathIB.h
wendythewan May 18, 2022
efecefc
Add missing include in EventFilterIB.h
wendythewan May 18, 2022
89ad787
Add direct include in EventPathIB.h
wendythewan May 18, 2022
e390b93
Add direct include in DefaultStorageKeyAllocator.h
wendythewan May 18, 2022
39cc7b9
Add direct include in sf-structs.h
wendythewan May 18, 2022
a688aad
Add used include
wendythewan May 18, 2022
86572f6
Update af-structs.h
wendythewan May 18, 2022
fb4ae71
Update af-structs.zapt
wendythewan May 18, 2022
c614fb2
Merge branch 'project-chip:master' into missing_includes
wendythewan May 18, 2022
4991d87
Ran zap regen
andy31415 May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/MessageDef/AttributePathIB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <app/util/basic-types.h>
#include <lib/core/CHIPCore.h>
#include <lib/core/CHIPTLV.h>
#include <lib/core/NodeId.h>
#include <lib/support/CodeUtils.h>
#include <lib/support/logging/CHIPLogging.h>

Expand Down
1 change: 1 addition & 0 deletions src/app/MessageDef/ClusterPathIB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <app/util/basic-types.h>
#include <lib/core/CHIPCore.h>
#include <lib/core/CHIPTLV.h>
#include <lib/core/NodeId.h>
#include <lib/support/CodeUtils.h>
#include <lib/support/logging/CHIPLogging.h>

Expand Down
1 change: 1 addition & 0 deletions src/app/MessageDef/EventFilterIB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <app/util/basic-types.h>
#include <lib/core/CHIPCore.h>
#include <lib/core/CHIPTLV.h>
#include <lib/core/NodeId.h>
#include <lib/support/CodeUtils.h>
#include <lib/support/logging/CHIPLogging.h>

Expand Down
1 change: 1 addition & 0 deletions src/app/MessageDef/EventPathIB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <app/util/basic-types.h>
#include <lib/core/CHIPCore.h>
#include <lib/core/CHIPTLV.h>
#include <lib/core/NodeId.h>
#include <lib/support/CodeUtils.h>
#include <lib/support/logging/CHIPLogging.h>

Expand Down
1 change: 1 addition & 0 deletions src/app/chip-zcl-zpro-codec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#pragma once

#include <app/util/basic-types.h>
#include <lib/core/GroupId.h>
#include <lib/support/BufferWriter.h>

typedef uint16_t EmberApsOption;
Expand Down
2 changes: 2 additions & 0 deletions src/app/zap-templates/templates/app/af-structs.zapt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
#include <stdint.h>

#include <app/util/basic-types.h>
#include <lib/core/GroupId.h>
#include <lib/core/NodeId.h>
#include <lib/support/Span.h>
#include <protocols/interaction_model/Constants.h>

Expand Down
1 change: 1 addition & 0 deletions src/lib/support/DefaultStorageKeyAllocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <app/ConcreteAttributePath.h>
#include <app/util/basic-types.h>
#include <lib/core/CHIPPersistentStorageDelegate.h>
#include <lib/core/GroupId.h>
#include <lib/support/EnforceFormat.h>
#include <lib/support/logging/Constants.h>
#include <string.h>
Expand Down