All clusters app enable general diagnostics feature map attribute

[vivien-apple]

Problem

The FeatureMap attribute of the General Diagnostics cluster is not enabled for the all-clusters-app...

Fix #18324

Change overview

• Enable it

Testing

./out/debug/standalone/chip-tool generaldiagnostics read feature-map 0x12344321 0

[bzbarsky-apple]

I'm still hoping we can come up with a better setup for these (see discussion in #18213), but for now for this one specific app, fine.

[github-actions]

PR #18554: Size comparison from 2cfa5f8 to 4d72249

Increases (8 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)

platform	target	config	section	2cfa5f8	4d72249	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	692639	692655	16	0.0
			.rodata	103911	103927	16	0.0
	shell	LP_CC2652R7	(read only)	687002	687018	16	0.0
			.bss	77156	77164	8	0.0
			.rodata	101458	101474	16	0.0
esp32	all-clusters-app	c3devkit	(read/write)	1478082	1478106	24	0.0
			.dram0.bss	68200	68208	8	0.0
			.flash.rodata	209824	209848	24	0.0
		m5stack	(read/write)	480084	480100	16	0.0
			.flash.rodata	240168	240184	16	0.0
linux	all-clusters-app	debug	(read only)	2750689	2750745	56	0.0
			(read/write)	175872	175904	32	0.0
			.data.rel.ro	82584	82616	32	0.0
			.rodata	240701	240733	32	0.0
	shell	debug	(read only)	2566481	2566537	56	0.0
			(read/write)	199768	199800	32	0.0
			.data.rel.ro	76872	76904	32	0.0
			.rodata	221714	221746	32	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180859	1180879	20	0.0
			bss	138372	138376	4	0.0
			rodata	153044	153064	20	0.0
p6	all-clusters-app	default	(read/write)	2538928	2538944	16	0.0
			.bss	136168	136176	8	0.0
			.text	1497192	1497208	16	0.0

Decreases (2 builds for cc13x2_26x2)

platform	target	config	section	2cfa5f8	4d72249	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read/write)	158912	158896	-16	-0.0
	shell	LP_CC2652R7	(read/write)	160372	160364	-8	-0.0

Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	2cfa5f8	4d72249	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	692639	692655	16	0.0
			(read/write)	158912	158896	-16	-0.0
			.bss	74532	74532	0	0.0
			.data	3412	3412	0	0.0
			.rodata	103911	103927	16	0.0
			.text	588248	588248	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	677367	677367	0	0.0
			(read/write)	165288	165288	0	0.0
			.bss	72692	72692	0	0.0
			.data	3236	3236	0	0.0
			.rodata	95055	95055	0	0.0
			.text	581828	581828	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	626175	626175	0	0.0
			(read/write)	145524	145524	0	0.0
			.bss	68428	68428	0	0.0
			.data	3236	3236	0	0.0
			.rodata	94943	94943	0	0.0
			.text	530740	530740	0	0.0
	pump-app	LP_CC2652R7	(read only)	660867	660867	0	0.0
			(read/write)	183068	183068	0	0.0
			.bss	72948	72948	0	0.0
			.data	3268	3268	0	0.0
			.rodata	80555	80555	0	0.0
			.text	579832	579832	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	654043	654043	0	0.0
			(read/write)	189700	189700	0	0.0
			.bss	73012	73012	0	0.0
			.data	3232	3232	0	0.0
			.rodata	83659	83659	0	0.0
			.text	569904	569904	0	0.0
	shell	LP_CC2652R7	(read only)	687002	687018	16	0.0
			(read/write)	160372	160364	-8	-0.0
			.bss	77156	77164	8	0.0
			.data	3416	3416	0	0.0
			.rodata	101458	101474	16	0.0
			.text	585060	585060	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	625446	625446	0	0.0
			.app_xip_area	529060	529060	0	0.0
			.bss	79028	79028	0	0.0
			.data	708	708	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	628402	628402	0	0.0
			.app_xip_area	533472	533472	0	0.0
			.bss	77604	77604	0	0.0
			.data	672	672	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	572786	572786	0	0.0
			.app_xip_area	468140	468140	0	0.0
			.bss	87024	87024	0	0.0
			.data	584	584	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	917564	917564	0	0.0
			(read/write)	133244	133244	0	0.0
			.bss	131184	131184	0	0.0
			.data	2060	2060	0	0.0
			.text	917556	917556	0	0.0
		BRD4161A+rpc	(read only)	951752	951752	0	0.0
			(read/write)	149928	149928	0	0.0
			.bss	147664	147664	0	0.0
			.data	2264	2264	0	0.0
			.text	951744	951744	0	0.0
		BRD4161A+rs911x	(read only)	791004	791004	0	0.0
			(read/write)	129512	129512	0	0.0
			.bss	127444	127444	0	0.0
			.data	2068	2068	0	0.0
			.text	790996	790996	0	0.0
	lock-app	BRD4161A+wf200	(read only)	946904	946904	0	0.0
			(read/write)	123996	123996	0	0.0
			.bss	121972	121972	0	0.0
			.data	2024	2024	0	0.0
			.text	946896	946896	0	0.0
	window-app	BRD4161A	(read only)	897684	897684	0	0.0
			(read/write)	133304	133304	0	0.0
			.bss	131256	131256	0	0.0
			.data	2048	2048	0	0.0
			.text	897676	897676	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	1000800	1000800	0	0.0
			(read/write)	1478082	1478106	24	0.0
			.dram0.bss	68200	68208	8	0.0
			.dram0.data	14624	14624	0	0.0
			.flash.rodata	209824	209848	24	0.0
			.flash.text	1000800	1000800	0	0.0
			.iram0.text	62954	62954	0	0.0
		m5stack	(read only)	1055971	1055971	0	0.0
			(read/write)	480084	480100	16	0.0
			.dram0.bss	73720	73720	0	0.0
			.dram0.data	34200	34200	0	0.0
			.flash.rodata	240168	240184	16	0.0
			.flash.text	1050587	1050587	0	0.0
			.iram0.text	123267	123267	0	0.0
k32w	light	k32w061+release	(read/write)	682956	682956	0	0.0
			.bss	80224	80224	0	0.0
			.data	2016	2016	0	0.0
			.text	599012	599012	0	0.0
	lock	k32w061+release	(read/write)	729476	729476	0	0.0
			.bss	80656	80656	0	0.0
			.data	1976	1976	0	0.0
			.text	645140	645140	0	0.0
linux	all-clusters-app	debug	(read only)	2750689	2750745	56	0.0
			(read/write)	175872	175904	32	0.0
			.bss	85056	85056	0	0.0
			.data	2064	2064	0	0.0
			.data.rel.ro	82584	82616	32	0.0
			.dynamic	608	608	0	0.0
			.got	4496	4496	0	0.0
			.init	27	27	0	0.0
			.init_array	1016	1016	0	0.0
			.rodata	240701	240733	32	0.0
			.text	2333682	2333682	0	0.0
	bridge-app	debug+rpc	(read only)	2032305	2032305	0	0.0
			(read/write)	147736	147736	0	0.0
			.bss	72832	72832	0	0.0
			.data	3936	3936	0	0.0
			.data.rel.ro	65384	65384	0	0.0
			.dynamic	592	592	0	0.0
			.got	4272	4272	0	0.0
			.init	27	27	0	0.0
			.init_array	688	688	0	0.0
			.rodata	168873	168873	0	0.0
			.text	1705234	1705234	0	0.0
	chip-tool	debug	(read only)	9307589	9307589	0	0.0
			(read/write)	580048	580048	0	0.0
			.bss	23936	23936	0	0.0
			.data	1152	1152	0	0.0
			.data.rel.ro	548672	548672	0	0.0
			.dynamic	624	624	0	0.0
			.got	5000	5000	0	0.0
			.init	27	27	0	0.0
			.init_array	648	648	0	0.0
			.rodata	479869	479869	0	0.0
			.text	7498725	7498725	0	0.0
	chip-tool-no-interactive-ipv6only	arm64	(read only)	9077172	9077172	0	0.0
			(read/write)	646161	646161	0	0.0
			.bss	42209	42209	0	0.0
			.data	1192	1192	0	0.0
			.data.rel.ro	583912	583912	0	0.0
			.dynamic	560	560	0	0.0
			.got	15008	15008	0	0.0
			.init	24	24	0	0.0
			.init_array	184	184	0	0.0
			.rodata	444980	444980	0	0.0
			.text	7168052	7168052	0	0.0
	lighting-app	debug+rpc	(read only)	2326833	2326833	0	0.0
			(read/write)	153184	153184	0	0.0
			.bss	74624	74624	0	0.0
			.data	2048	2048	0	0.0
			.data.rel.ro	70744	70744	0	0.0
			.dynamic	608	608	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	792	792	0	0.0
			.rodata	187913	187913	0	0.0
			.text	1971490	1971490	0	0.0
	lock-app	debug	(read only)	2240417	2240417	0	0.0
			(read/write)	147864	147864	0	0.0
			.bss	73312	73312	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	67272	67272	0	0.0
			.dynamic	592	592	0	0.0
			.got	4336	4336	0	0.0
			.init	27	27	0	0.0
			.init_array	752	752	0	0.0
			.rodata	198585	198585	0	0.0
			.text	1880722	1880722	0	0.0
	ota-provider-app	debug	(read only)	2061001	2061001	0	0.0
			(read/write)	140944	140944	0	0.0
			.bss	72768	72768	0	0.0
			.data	1768	1768	0	0.0
			.data.rel.ro	60616	60616	0	0.0
			.dynamic	608	608	0	0.0
			.got	4504	4504	0	0.0
			.init	27	27	0	0.0
			.init_array	648	648	0	0.0
			.rodata	178944	178944	0	0.0
			.text	1723442	1723442	0	0.0
	ota-requestor-app	debug	(read only)	2090193	2090193	0	0.0
			(read/write)	143720	143720	0	0.0
			.bss	73440	73440	0	0.0
			.data	1992	1992	0	0.0
			.data.rel.ro	62648	62648	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	672	672	0	0.0
			.rodata	175008	175008	0	0.0
			.text	1755106	1755106	0	0.0
	shell	debug	(read only)	2566481	2566537	56	0.0
			(read/write)	199768	199800	32	0.0
			.bss	115752	115752	0	0.0
			.data	1376	1376	0	0.0
			.data.rel.ro	76872	76904	32	0.0
			.dynamic	608	608	0	0.0
			.got	4192	4192	0	0.0
			.init	27	27	0	0.0
			.init_array	936	936	0	0.0
			.rodata	221714	221746	32	0.0
			.text	2181842	2181842	0	0.0
	thermostat-no-ble	arm64	(read only)	2352604	2352604	0	0.0
			(read/write)	176289	176289	0	0.0
			.bss	87585	87585	0	0.0
			.data	1520	1520	0	0.0
			.data.rel.ro	79384	79384	0	0.0
			.dynamic	560	560	0	0.0
			.got	4768	4768	0	0.0
			.init	24	24	0	0.0
			.init_array	376	376	0	0.0
			.rodata	147148	147148	0	0.0
			.text	1975440	1975440	0	0.0
	tv-app	debug	(read only)	2852489	2852489	0	0.0
			(read/write)	278720	278720	0	0.0
			.bss	190712	190712	0	0.0
			.data	4672	4672	0	0.0
			.data.rel.ro	77080	77080	0	0.0
			.dynamic	592	592	0	0.0
			.got	4720	4720	0	0.0
			.init	27	27	0	0.0
			.init_array	928	928	0	0.0
			.rodata	221105	221105	0	0.0
			.text	2447890	2447890	0	0.0
	tv-casting-app	debug	(read only)	5414817	5414817	0	0.0
			(read/write)	224992	224992	0	0.0
			.bss	78328	78328	0	0.0
			.data	2368	2368	0	0.0
			.data.rel.ro	138072	138072	0	0.0
			.dynamic	608	608	0	0.0
			.got	4728	4728	0	0.0
			.init	27	27	0	0.0
			.init_array	864	864	0	0.0
			.rodata	339521	339521	0	0.0
			.text	4714770	4714770	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2420568	2420568	0	0.0
			.bss	202668	202668	0	0.0
			.data	5872	5872	0	0.0
			.text	1383212	1383212	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180859	1180879	20	0.0
			bss	138372	138376	4	0.0
			rodata	153044	153064	20	0.0
			text	810568	810568	0	0.0
p6	all-clusters-app	default	(read/write)	2538928	2538944	16	0.0
			.bss	136168	136176	8	0.0
			.data	2808	2808	0	0.0
			.text	1497192	1497208	16	0.0
	light-app	default	(read/write)	2425376	2425376	0	0.0
			.bss	129488	129488	0	0.0
			.data	2608	2608	0	0.0
			.text	1383640	1383640	0	0.0
	lock-app	default	(read/write)	2436096	2436096	0	0.0
			.bss	129304	129304	0	0.0
			.data	2568	2568	0	0.0
			.text	1394360	1394360	0	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	782600	782600	0	0.0
			bss	70608	70608	0	0.0
			noinit	40416	40416	0	0.0
			text	553408	553408	0	0.0
	lighting-app	tlsr9518adk80d	(read/write)	802692	802692	0	0.0
			bss	70864	70864	0	0.0
			noinit	40416	40416	0	0.0
			text	570174	570174	0	0.0