Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop calling OnPairingComplete on CASE session establishment. #18524

Merged
merged 3 commits into from
May 18, 2022
Merged

Stop calling OnPairingComplete on CASE session establishment. #18524

merged 3 commits into from
May 18, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

OnPairingComplete is documented as indicating the end of PASE
establishment, but our implementation calls it for some CASE
sessions as well: only the ones we kick off from UpdateDevice.

This is unexpected by API consumers, and we should not be doing it.

Fixes #18230

Problem

See above.

Change overview

See above.

Testing

Should be covered by existing tests.

@restyled-io restyled-io bot mentioned this pull request May 17, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

PR #18524: Size comparison from d79a0e3 to 4d761a3

Decreases (1 build for linux)
platform target config section d79a0e3 4d761a3 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058548 -208 -0.0
.text 7149732 7149524 -208 -0.0
Full report (11 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section d79a0e3 4d761a3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624766 0 0.0
.app_xip_area 528396 528396 0 0.0
.bss 79012 79012 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627826 627826 0 0.0
.app_xip_area 532912 532912 0 0.0
.bss 77588 77588 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572266 0 0.0
.app_xip_area 467636 467636 0 0.0
.bss 87008 87008 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 682516 682516 0 0.0
.bss 80200 80200 0 0.0
.data 2016 2016 0 0.0
.text 598596 598596 0 0.0
lock k32w061+release (read/write) 729012 729012 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 644700 644700 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058548 -208 -0.0
(read/write) 644993 644993 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583864 583864 0 0.0
.dynamic 560 560 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445124 445124 0 0.0
.text 7149732 7149524 -208 -0.0
thermostat-no-ble arm64 (read only) 2343780 2343780 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86465 86465 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147108 147108 0 0.0
.text 1966848 1966848 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2418784 0 0.0
.bss 201588 201588 0 0.0
.data 5872 5872 0 0.0
.text 1381428 1381428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180243 0 0.0
bss 138356 138356 0 0.0
rodata 152956 152956 0 0.0
text 810160 810160 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782116 782116 0 0.0
bss 70592 70592 0 0.0
noinit 40416 40416 0 0.0
text 553028 553028 0 0.0
lighting-app tlsr9518adk80d (read/write) 802208 802208 0 0.0
bss 70848 70848 0 0.0
noinit 40416 40416 0 0.0
text 569794 569794 0 0.0

@bzbarsky-apple
Stop calling OnPairingComplete on CASE session establishment.
3a63d6a 
OnPairingComplete is documented as indicating the end of PASE
establishment, but our implementation calls it for _some_ CASE
sessions as well: only the ones we kick off from UpdateDevice.

This is unexpected by API consumers, and we should not be doing it.

Fixes project-chip#18230
@bzbarsky-apple bzbarsky-apple force-pushed the stop-incorrect-pairing-delegate-bits branch from 4d761a3 to 3a63d6a Compare May 17, 2022 20:05
@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

PR #18524: Size comparison from 9acc5cb to 3a63d6a

Decreases (3 builds for linux)
platform target config section 9acc5cb 3a63d6a change % change
linux chip-tool debug (read only) 9282453 9282165 -288 -0.0
.text 7474613 7474325 -288 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058548 -208 -0.0
.text 7149732 7149524 -208 -0.0
tv-app debug (read only) 2841185 2840913 -272 -0.0
.text 2438562 2438290 -272 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9acc5cb 3a63d6a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692151 692151 0 0.0
(read/write) 159384 159384 0 0.0
.bss 74516 74516 0 0.0
.data 3412 3412 0 0.0
.rodata 103823 103823 0 0.0
.text 587848 587848 0 0.0
lock-ftd LP_CC2652R7 (read only) 676863 676863 0 0.0
(read/write) 165776 165776 0 0.0
.bss 72676 72676 0 0.0
.data 3236 3236 0 0.0
.rodata 94967 94967 0 0.0
.text 581412 581412 0 0.0
lock-mtd LP_CC2652R7 (read only) 625695 625695 0 0.0
(read/write) 145508 145508 0 0.0
.bss 68412 68412 0 0.0
.data 3236 3236 0 0.0
.rodata 94855 94855 0 0.0
.text 530348 530348 0 0.0
pump-app LP_CC2652R7 (read only) 660387 660387 0 0.0
(read/write) 183532 183532 0 0.0
.bss 72932 72932 0 0.0
.data 3268 3268 0 0.0
.rodata 80467 80467 0 0.0
.text 579440 579440 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 190172 190172 0 0.0
.bss 72996 72996 0 0.0
.data 3232 3232 0 0.0
.rodata 83571 83571 0 0.0
.text 569504 569504 0 0.0
shell LP_CC2652R7 (read only) 686538 686538 0 0.0
(read/write) 160820 160820 0 0.0
.bss 77140 77140 0 0.0
.data 3416 3416 0 0.0
.rodata 101370 101370 0 0.0
.text 584684 584684 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624766 0 0.0
.app_xip_area 528396 528396 0 0.0
.bss 79012 79012 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627826 627826 0 0.0
.app_xip_area 532912 532912 0 0.0
.bss 77588 77588 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572266 0 0.0
.app_xip_area 467636 467636 0 0.0
.bss 87008 87008 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915068 915068 0 0.0
(read/write) 133220 133220 0 0.0
.bss 131160 131160 0 0.0
.data 2060 2060 0 0.0
.text 915060 915060 0 0.0
BRD4161A+rpc (read only) 949304 949304 0 0.0
(read/write) 149904 149904 0 0.0
.bss 147640 147640 0 0.0
.data 2264 2264 0 0.0
.text 949296 949296 0 0.0
BRD4161A+rs911x (read only) 784416 784416 0 0.0
(read/write) 128444 128444 0 0.0
.bss 126372 126372 0 0.0
.data 2068 2068 0 0.0
.text 784408 784408 0 0.0
lock-app BRD4161A+wf200 (read only) 945156 945156 0 0.0
(read/write) 122924 122924 0 0.0
.bss 120900 120900 0 0.0
.data 2024 2024 0 0.0
.text 945148 945148 0 0.0
window-app BRD4161A (read only) 895188 895188 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131232 131232 0 0.0
.data 2048 2048 0 0.0
.text 895180 895180 0 0.0
esp32 all-clusters-app c3devkit (read only) 998376 998376 0 0.0
(read/write) 1477026 1477026 0 0.0
.dram0.bss 67128 67128 0 0.0
.dram0.data 14576 14576 0 0.0
.flash.rodata 209888 209888 0 0.0
.flash.text 998376 998376 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053635 1053635 0 0.0
(read/write) 479024 479024 0 0.0
.dram0.bss 72656 72656 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 240188 240188 0 0.0
.flash.text 1048251 1048251 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682516 682516 0 0.0
.bss 80200 80200 0 0.0
.data 2016 2016 0 0.0
.text 598596 598596 0 0.0
lock k32w061+release (read/write) 729012 729012 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 644700 644700 0 0.0
linux all-clusters-app debug (read only) 2738905 2738905 0 0.0
(read/write) 174624 174624 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82488 82488 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 238877 238877 0 0.0
.text 2323938 2323938 0 0.0
bridge-app debug+rpc (read only) 2021385 2021385 0 0.0
(read/write) 146552 146552 0 0.0
.bss 71744 71744 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167401 167401 0 0.0
.text 1696002 1696002 0 0.0
chip-tool debug (read only) 9282453 9282165 -288 -0.0
(read/write) 578864 578864 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 548608 548608 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 479061 479061 0 0.0
.text 7474613 7474325 -288 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058548 -208 -0.0
(read/write) 644993 644993 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583864 583864 0 0.0
.dynamic 560 560 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445124 445124 0 0.0
.text 7149732 7149524 -208 -0.0
lighting-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 152000 152000 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186473 186473 0 0.0
.text 1961522 1961522 0 0.0
lock-app debug (read only) 2228937 2228937 0 0.0
(read/write) 146680 146680 0 0.0
.bss 72224 72224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 197049 197049 0 0.0
.text 1870994 1870994 0 0.0
ota-provider-app debug (read only) 2049873 2049873 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177267 177267 0 0.0
.text 1714210 1714210 0 0.0
ota-requestor-app debug (read only) 2079201 2079201 0 0.0
(read/write) 142568 142568 0 0.0
.bss 72352 72352 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173468 173468 0 0.0
.text 1745874 1745874 0 0.0
shell debug (read only) 2555289 2555289 0 0.0
(read/write) 198552 198552 0 0.0
.bss 114632 114632 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76776 76776 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 220050 220050 0 0.0
.text 2172530 2172530 0 0.0
thermostat-no-ble arm64 (read only) 2343780 2343780 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86465 86465 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147108 147108 0 0.0
.text 1966848 1966848 0 0.0
tv-app debug (read only) 2841185 2840913 -272 -0.0
(read/write) 277472 277472 0 0.0
.bss 189592 189592 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219345 219345 0 0.0
.text 2438562 2438290 -272 -0.0
tv-casting-app debug (read only) 5403545 5403545 0 0.0
(read/write) 223776 223776 0 0.0
.bss 77240 77240 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337921 337921 0 0.0
.text 4705314 4705314 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2418784 0 0.0
.bss 201588 201588 0 0.0
.data 5872 5872 0 0.0
.text 1381428 1381428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180243 0 0.0
bss 138356 138356 0 0.0
rodata 152956 152956 0 0.0
text 810168 810168 0 0.0
p6 all-clusters-app default (read/write) 2532168 2532168 0 0.0
.bss 135096 135096 0 0.0
.data 2808 2808 0 0.0
.text 1490432 1490432 0 0.0
light-app default (read/write) 2418776 2418776 0 0.0
.bss 128416 128416 0 0.0
.data 2608 2608 0 0.0
.text 1377040 1377040 0 0.0
lock-app default (read/write) 2429424 2429424 0 0.0
.bss 128232 128232 0 0.0
.data 2568 2568 0 0.0
.text 1387688 1387688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782124 782124 0 0.0
bss 70592 70592 0 0.0
noinit 40416 40416 0 0.0
text 553036 553036 0 0.0
lighting-app tlsr9518adk80d (read/write) 802216 802216 0 0.0
bss 70848 70848 0 0.0
noinit 40416 40416 0 0.0
text 569802 569802 0 0.0

@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

PR #18524: Size comparison from 9acc5cb to 9d4ef65

Decreases (3 builds for linux)
platform target config section 9acc5cb 9d4ef65 change % change
linux chip-tool debug (read only) 9282453 9282021 -432 -0.0
.rodata 479061 478965 -96 -0.0
.text 7474613 7474277 -336 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058436 -320 -0.0
.rodata 445124 445060 -64 -0.0
.text 7149732 7149476 -256 -0.0
tv-app debug (read only) 2841185 2840801 -384 -0.0
.rodata 219345 219281 -64 -0.0
.text 2438562 2438242 -320 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9acc5cb 9d4ef65 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692151 692151 0 0.0
(read/write) 159384 159384 0 0.0
.bss 74516 74516 0 0.0
.data 3412 3412 0 0.0
.rodata 103823 103823 0 0.0
.text 587848 587848 0 0.0
lock-ftd LP_CC2652R7 (read only) 676863 676863 0 0.0
(read/write) 165776 165776 0 0.0
.bss 72676 72676 0 0.0
.data 3236 3236 0 0.0
.rodata 94967 94967 0 0.0
.text 581412 581412 0 0.0
lock-mtd LP_CC2652R7 (read only) 625695 625695 0 0.0
(read/write) 145508 145508 0 0.0
.bss 68412 68412 0 0.0
.data 3236 3236 0 0.0
.rodata 94855 94855 0 0.0
.text 530348 530348 0 0.0
pump-app LP_CC2652R7 (read only) 660387 660387 0 0.0
(read/write) 183532 183532 0 0.0
.bss 72932 72932 0 0.0
.data 3268 3268 0 0.0
.rodata 80467 80467 0 0.0
.text 579440 579440 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 190172 190172 0 0.0
.bss 72996 72996 0 0.0
.data 3232 3232 0 0.0
.rodata 83571 83571 0 0.0
.text 569504 569504 0 0.0
shell LP_CC2652R7 (read only) 686538 686538 0 0.0
(read/write) 160820 160820 0 0.0
.bss 77140 77140 0 0.0
.data 3416 3416 0 0.0
.rodata 101370 101370 0 0.0
.text 584684 584684 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624766 0 0.0
.app_xip_area 528396 528396 0 0.0
.bss 79012 79012 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627826 627826 0 0.0
.app_xip_area 532912 532912 0 0.0
.bss 77588 77588 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572266 0 0.0
.app_xip_area 467636 467636 0 0.0
.bss 87008 87008 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915068 915068 0 0.0
(read/write) 133220 133220 0 0.0
.bss 131160 131160 0 0.0
.data 2060 2060 0 0.0
.text 915060 915060 0 0.0
BRD4161A+rpc (read only) 949304 949304 0 0.0
(read/write) 149904 149904 0 0.0
.bss 147640 147640 0 0.0
.data 2264 2264 0 0.0
.text 949296 949296 0 0.0
BRD4161A+rs911x (read only) 784416 784416 0 0.0
(read/write) 128444 128444 0 0.0
.bss 126372 126372 0 0.0
.data 2068 2068 0 0.0
.text 784408 784408 0 0.0
lock-app BRD4161A+wf200 (read only) 945156 945156 0 0.0
(read/write) 122924 122924 0 0.0
.bss 120900 120900 0 0.0
.data 2024 2024 0 0.0
.text 945148 945148 0 0.0
window-app BRD4161A (read only) 895188 895188 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131232 131232 0 0.0
.data 2048 2048 0 0.0
.text 895180 895180 0 0.0
esp32 all-clusters-app c3devkit (read only) 998376 998376 0 0.0
(read/write) 1477026 1477026 0 0.0
.dram0.bss 67128 67128 0 0.0
.dram0.data 14576 14576 0 0.0
.flash.rodata 209888 209888 0 0.0
.flash.text 998376 998376 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053635 1053635 0 0.0
(read/write) 479024 479024 0 0.0
.dram0.bss 72656 72656 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 240188 240188 0 0.0
.flash.text 1048251 1048251 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682516 682516 0 0.0
.bss 80200 80200 0 0.0
.data 2016 2016 0 0.0
.text 598596 598596 0 0.0
lock k32w061+release (read/write) 729012 729012 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 644700 644700 0 0.0
linux all-clusters-app debug (read only) 2738905 2738905 0 0.0
(read/write) 174624 174624 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82488 82488 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 238877 238877 0 0.0
.text 2323938 2323938 0 0.0
bridge-app debug+rpc (read only) 2021385 2021385 0 0.0
(read/write) 146552 146552 0 0.0
.bss 71744 71744 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167401 167401 0 0.0
.text 1696002 1696002 0 0.0
chip-tool debug (read only) 9282453 9282021 -432 -0.0
(read/write) 578864 578864 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 548608 548608 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 479061 478965 -96 -0.0
.text 7474613 7474277 -336 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058436 -320 -0.0
(read/write) 644993 644993 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583864 583864 0 0.0
.dynamic 560 560 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445124 445060 -64 -0.0
.text 7149732 7149476 -256 -0.0
lighting-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 152000 152000 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186473 186473 0 0.0
.text 1961522 1961522 0 0.0
lock-app debug (read only) 2228937 2228937 0 0.0
(read/write) 146680 146680 0 0.0
.bss 72224 72224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 197049 197049 0 0.0
.text 1870994 1870994 0 0.0
ota-provider-app debug (read only) 2049873 2049873 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177267 177267 0 0.0
.text 1714210 1714210 0 0.0
ota-requestor-app debug (read only) 2079201 2079201 0 0.0
(read/write) 142568 142568 0 0.0
.bss 72352 72352 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173468 173468 0 0.0
.text 1745874 1745874 0 0.0
shell debug (read only) 2555289 2555289 0 0.0
(read/write) 198552 198552 0 0.0
.bss 114632 114632 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76776 76776 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 220050 220050 0 0.0
.text 2172530 2172530 0 0.0
thermostat-no-ble arm64 (read only) 2343780 2343780 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86465 86465 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147108 147108 0 0.0
.text 1966848 1966848 0 0.0
tv-app debug (read only) 2841185 2840801 -384 -0.0
(read/write) 277472 277472 0 0.0
.bss 189592 189592 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219345 219281 -64 -0.0
.text 2438562 2438242 -320 -0.0
tv-casting-app debug (read only) 5403545 5403545 0 0.0
(read/write) 223776 223776 0 0.0
.bss 77240 77240 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337921 337921 0 0.0
.text 4705314 4705314 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2418784 0 0.0
.bss 201588 201588 0 0.0
.data 5872 5872 0 0.0
.text 1381428 1381428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180243 0 0.0
bss 138356 138356 0 0.0
rodata 152956 152956 0 0.0
text 810168 810168 0 0.0
p6 all-clusters-app default (read/write) 2532168 2532168 0 0.0
.bss 135096 135096 0 0.0
.data 2808 2808 0 0.0
.text 1490432 1490432 0 0.0
light-app default (read/write) 2418776 2418776 0 0.0
.bss 128416 128416 0 0.0
.data 2608 2608 0 0.0
.text 1377040 1377040 0 0.0
lock-app default (read/write) 2429424 2429424 0 0.0
.bss 128232 128232 0 0.0
.data 2568 2568 0 0.0
.text 1387688 1387688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782124 782124 0 0.0
bss 70592 70592 0 0.0
noinit 40416 40416 0 0.0
text 553036 553036 0 0.0
lighting-app tlsr9518adk80d (read/write) 802216 802216 0 0.0
bss 70848 70848 0 0.0
noinit 40416 40416 0 0.0
text 569802 569802 0 0.0

@bzbarsky-apple
Stop calling UpdateDevice from the Python controller.
eb2f006 
Use GetConnectedDevice instead, so we don't have to rely on global callbacks.
@github-actions
Copy link

github-actions bot commented May 18, 2022 •
edited
Loading

PR #18524: Size comparison from 9acc5cb to eb2f006

Increases above 0.2%:

platform target config section 9acc5cb eb2f006 change % change
efr32 lighting-app BRD4161A+rs911x (read only) 784416 788388 3972 0.5
(read/write) 128444 129512 1068 0.8
.bss 126372 127444 1072 0.8
.text 784408 788380 3972 0.5
lock-app BRD4161A+wf200 (read/write) 122924 123996 1072 0.9
.bss 120900 121972 1072 0.9
esp32 all-clusters-app c3devkit .dram0.bss 67128 68200 1072 1.6
m5stack .dram0.bss 72656 73728 1072 1.5
linux all-clusters-app debug (read only) 2738905 2748449 9544 0.3
(read/write) 174624 175872 1248 0.7
.bss 83904 85056 1152 1.4
.text 2323938 2333330 9392 0.4
bridge-app debug+rpc (read only) 2021385 2030385 9000 0.4
(read/write) 146552 147736 1184 0.8
.bss 71744 72832 1088 1.5
.text 1696002 1704882 8880 0.5
chip-tool debug (read only) 9282453 9307853 25400 0.3
(read/write) 578864 580976 2112 0.4
.bss 22816 23936 1120 4.9
.data 1136 1152 16 1.4
.rodata 479061 480437 1376 0.3
.text 7474613 7496261 21648 0.3
chip-tool-no-interactive-ipv6only arm64 (read/write) 644993 647105 2112 0.3
.bss 41105 42209 1104 2.7
.rodata 445124 446404 1280 0.3
lighting-app debug+rpc (read only) 2315209 2324945 9736 0.4
(read/write) 152000 153184 1184 0.8
.bss 73536 74624 1088 1.5
.text 1961522 1971138 9616 0.5
lock-app debug (read only) 2228937 2238353 9416 0.4
(read/write) 146680 147864 1184 0.8
.bss 72224 73312 1088 1.5
.text 1870994 1880354 9360 0.5
ota-provider-app debug (read only) 2049873 2058873 9000 0.4
(read/write) 139728 140944 1216 0.9
.bss 71680 72768 1088 1.5
.data.rel.ro 60488 60616 128 0.2
.text 1714210 1723074 8864 0.5
ota-requestor-app debug (read only) 2079201 2088193 8992 0.4
(read/write) 142568 143720 1152 0.8
.bss 72352 73440 1088 1.5
.text 1745874 1754738 8864 0.5
shell debug (read only) 2555289 2564321 9032 0.4
(read/write) 198552 199768 1216 0.6
.bss 114632 115752 1120 1.0
.text 2172530 2181410 8880 0.4
thermostat-no-ble arm64 (read only) 2343780 2352044 8264 0.4
(read/write) 175121 176289 1168 0.7
.bss 86465 87585 1120 1.3
.text 1966848 1975104 8256 0.4
tv-app debug (read only) 2841185 2850121 8936 0.3
(read/write) 277472 278720 1248 0.4
.bss 189592 190712 1120 0.6
.text 2438562 2447058 8496 0.3
tv-casting-app debug (read/write) 223776 224992 1216 0.5
.bss 77240 78328 1088 1.4
mbed lock-app CY8CPROTO_062_4343W+release .bss 201588 202668 1080 0.5
p6 all-clusters-app default .bss 135096 136168 1072 0.8
.text 1490432 1494392 3960 0.3
light-app default .bss 128416 129488 1072 0.8
.text 1377040 1381024 3984 0.3
lock-app default .bss 128232 129304 1072 0.8
.text 1387688 1391672 3984 0.3
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9acc5cb eb2f006 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692151 692359 208 0.0
.bss 74516 74532 16 0.0
.text 587848 588056 208 0.0
lock-ftd LP_CC2652R7 (read only) 676863 677071 208 0.0
.bss 72676 72692 16 0.0
.text 581412 581620 208 0.0
lock-mtd LP_CC2652R7 (read only) 625695 625903 208 0.0
(read/write) 145508 145524 16 0.0
.bss 68412 68428 16 0.0
.text 530348 530556 208 0.0
pump-app LP_CC2652R7 (read only) 660387 660571 184 0.0
.bss 72932 72948 16 0.0
.text 579440 579624 184 0.0
pump-controller-app LP_CC2652R7 (read only) 653555 653739 184 0.0
.bss 72996 73012 16 0.0
.text 569504 569688 184 0.0
shell LP_CC2652R7 (read only) 686538 686722 184 0.0
.bss 77140 77156 16 0.0
.text 584684 584868 184 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624974 208 0.0
.app_xip_area 528396 528588 192 0.0
.bss 79012 79028 16 0.0
lock cyw930739m2evb_01 (read/write) 627826 628018 192 0.0
.app_xip_area 532912 533088 176 0.0
.bss 77588 77604 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572474 208 0.0
.app_xip_area 467636 467828 192 0.0
.bss 87008 87024 16 0.0
efr32 lighting-app BRD4161A (read/write) 133220 133244 24 0.0
.bss 131160 131184 24 0.0
BRD4161A+rpc (read/write) 149904 149928 24 0.0
.bss 147640 147664 24 0.0
BRD4161A+rs911x (read only) 784416 788388 3972 0.5
(read/write) 128444 129512 1068 0.8
.bss 126372 127444 1072 0.8
.text 784408 788380 3972 0.5
lock-app BRD4161A+wf200 (read only) 945156 946640 1484 0.2
(read/write) 122924 123996 1072 0.9
.bss 120900 121972 1072 0.9
.text 945148 946632 1484 0.2
window-app BRD4161A (read/write) 133280 133304 24 0.0
.bss 131232 131256 24 0.0
esp32 all-clusters-app c3devkit (read only) 998376 1000736 2360 0.2
(read/write) 1477026 1477874 848 0.1
.dram0.bss 67128 68200 1072 1.6
.dram0.data 14576 14608 32 0.2
.flash.text 998376 1000736 2360 0.2
m5stack (read only) 1053635 1055679 2044 0.2
(read/write) 479024 479888 864 0.2
.dram0.bss 72656 73728 1072 1.5
.flash.text 1048251 1050295 2044 0.2
k32w light k32w061+release (read/write) 682516 682748 232 0.0
.bss 80200 80224 24 0.0
.text 598596 598804 208 0.0
lock k32w061+release (read/write) 729012 729228 216 0.0
.bss 80632 80656 24 0.0
.text 644700 644892 192 0.0
linux all-clusters-app debug (read only) 2738905 2748449 9544 0.3
(read/write) 174624 175872 1248 0.7
.bss 83904 85056 1152 1.4
.data.rel.ro 82488 82584 96 0.1
.text 2323938 2333330 9392 0.4
bridge-app debug+rpc (read only) 2021385 2030385 9000 0.4
(read/write) 146552 147736 1184 0.8
.bss 71744 72832 1088 1.5
.data.rel.ro 65288 65384 96 0.1
.text 1696002 1704882 8880 0.5
chip-tool debug (read only) 9282453 9307853 25400 0.3
(read/write) 578864 580976 2112 0.4
.bss 22816 23936 1120 4.9
.data 1136 1152 16 1.4
.data.rel.ro 548608 549600 992 0.2
.rodata 479061 480437 1376 0.3
.text 7474613 7496261 21648 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9079188 20432 0.2
(read/write) 644993 647105 2112 0.3
.bss 41105 42209 1104 2.7
.data.rel.ro 583864 584840 976 0.2
.got 14992 15016 24 0.2
.rodata 445124 446404 1280 0.3
.text 7149732 7166468 16736 0.2
lighting-app debug+rpc (read only) 2315209 2324945 9736 0.4
(read/write) 152000 153184 1184 0.8
.bss 73536 74624 1088 1.5
.data.rel.ro 70664 70744 80 0.1
.text 1961522 1971138 9616 0.5
lock-app debug (read only) 2228937 2238353 9416 0.4
(read/write) 146680 147864 1184 0.8
.bss 72224 73312 1088 1.5
.data.rel.ro 67192 67272 80 0.1
.text 1870994 1880354 9360 0.5
ota-provider-app debug (read only) 2049873 2058873 9000 0.4
(read/write) 139728 140944 1216 0.9
.bss 71680 72768 1088 1.5
.data.rel.ro 60488 60616 128 0.2
.text 1714210 1723074 8864 0.5
ota-requestor-app debug (read only) 2079201 2088193 8992 0.4
(read/write) 142568 143720 1152 0.8
.bss 72352 73440 1088 1.5
.data.rel.ro 62584 62648 64 0.1
.text 1745874 1754738 8864 0.5
shell debug (read only) 2555289 2564321 9032 0.4
(read/write) 198552 199768 1216 0.6
.bss 114632 115752 1120 1.0
.data.rel.ro 76776 76872 96 0.1
.text 2172530 2181410 8880 0.4
thermostat-no-ble arm64 (read only) 2343780 2352044 8264 0.4
(read/write) 175121 176289 1168 0.7
.bss 86465 87585 1120 1.3
.data.rel.ro 79336 79384 48 0.1
.text 1966848 1975104 8256 0.4
tv-app debug (read only) 2841185 2850121 8936 0.3
(read/write) 277472 278720 1248 0.4
.bss 189592 190712 1120 0.6
.data.rel.ro 76960 77080 120 0.2
.rodata 219345 219569 224 0.1
.text 2438562 2447058 8496 0.3
tv-casting-app debug (read only) 5403545 5412689 9144 0.2
(read/write) 223776 224992 1216 0.5
.bss 77240 78328 1088 1.4
.data.rel.ro 137952 138072 120 0.1
.text 4705314 4714338 9024 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418784 2420288 1504 0.1
.bss 201588 202668 1080 0.5
.text 1381428 1382932 1504 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180611 368 0.0
bss 138356 138372 16 0.0
text 810168 810400 232 0.0
p6 all-clusters-app default (read/write) 2532168 2536128 3960 0.2
.bss 135096 136168 1072 0.8
.text 1490432 1494392 3960 0.3
light-app default (read/write) 2418776 2422760 3984 0.2
.bss 128416 129488 1072 0.8
.text 1377040 1381024 3984 0.3
lock-app default (read/write) 2429424 2433408 3984 0.2
.bss 128232 129304 1072 0.8
.text 1387688 1391672 3984 0.3
telink light-switch-app tlsr9518adk80d (read/write) 782124 782388 264 0.0
bss 70592 70608 16 0.0
text 553036 553284 248 0.0
lighting-app tlsr9518adk80d (read/write) 802216 802480 264 0.0
bss 70848 70864 16 0.0
text 569802 570050 248 0.0
Decreases (19 builds for cc13x2_26x2, efr32, esp32, linux)
platform target config section 9acc5cb eb2f006 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159384 159192 -192 -0.1
lock-ftd LP_CC2652R7 (read/write) 165776 165584 -192 -0.1
pump-app LP_CC2652R7 (read/write) 183532 183364 -168 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190172 190004 -168 -0.1
shell LP_CC2652R7 (read/write) 160820 160652 -168 -0.1
efr32 lighting-app BRD4161A (read only) 915068 914908 -160 -0.0
.text 915060 914900 -160 -0.0
BRD4161A+rpc (read only) 949304 949096 -208 -0.0
.text 949296 949088 -208 -0.0
window-app BRD4161A (read only) 895188 895028 -160 -0.0
.text 895180 895020 -160 -0.0
esp32 all-clusters-app c3devkit .flash.rodata 209888 209632 -256 -0.1
m5stack .flash.rodata 240188 239980 -208 -0.1
linux all-clusters-app debug .rodata 238877 238813 -64 -0.0
bridge-app debug+rpc .rodata 167401 167305 -96 -0.1
lighting-app debug+rpc .rodata 186473 186377 -96 -0.1
lock-app debug .rodata 197049 196889 -160 -0.1
ota-provider-app debug .rodata 177267 177184 -83 -0.0
ota-requestor-app debug .rodata 173468 173376 -92 -0.1
shell debug .rodata 220050 219986 -64 -0.0
thermostat-no-ble arm64 .rodata 147108 146924 -184 -0.1
tv-casting-app debug .rodata 337921 337825 -96 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9acc5cb eb2f006 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692151 692359 208 0.0
(read/write) 159384 159192 -192 -0.1
.bss 74516 74532 16 0.0
.data 3412 3412 0 0.0
.rodata 103823 103823 0 0.0
.text 587848 588056 208 0.0
lock-ftd LP_CC2652R7 (read only) 676863 677071 208 0.0
(read/write) 165776 165584 -192 -0.1
.bss 72676 72692 16 0.0
.data 3236 3236 0 0.0
.rodata 94967 94967 0 0.0
.text 581412 581620 208 0.0
lock-mtd LP_CC2652R7 (read only) 625695 625903 208 0.0
(read/write) 145508 145524 16 0.0
.bss 68412 68428 16 0.0
.data 3236 3236 0 0.0
.rodata 94855 94855 0 0.0
.text 530348 530556 208 0.0
pump-app LP_CC2652R7 (read only) 660387 660571 184 0.0
(read/write) 183532 183364 -168 -0.1
.bss 72932 72948 16 0.0
.data 3268 3268 0 0.0
.rodata 80467 80467 0 0.0
.text 579440 579624 184 0.0
pump-controller-app LP_CC2652R7 (read only) 653555 653739 184 0.0
(read/write) 190172 190004 -168 -0.1
.bss 72996 73012 16 0.0
.data 3232 3232 0 0.0
.rodata 83571 83571 0 0.0
.text 569504 569688 184 0.0
shell LP_CC2652R7 (read only) 686538 686722 184 0.0
(read/write) 160820 160652 -168 -0.1
.bss 77140 77156 16 0.0
.data 3416 3416 0 0.0
.rodata 101370 101370 0 0.0
.text 584684 584868 184 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624974 208 0.0
.app_xip_area 528396 528588 192 0.0
.bss 79012 79028 16 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627826 628018 192 0.0
.app_xip_area 532912 533088 176 0.0
.bss 77588 77604 16 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572474 208 0.0
.app_xip_area 467636 467828 192 0.0
.bss 87008 87024 16 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915068 914908 -160 -0.0
(read/write) 133220 133244 24 0.0
.bss 131160 131184 24 0.0
.data 2060 2060 0 0.0
.text 915060 914900 -160 -0.0
BRD4161A+rpc (read only) 949304 949096 -208 -0.0
(read/write) 149904 149928 24 0.0
.bss 147640 147664 24 0.0
.data 2264 2264 0 0.0
.text 949296 949088 -208 -0.0
BRD4161A+rs911x (read only) 784416 788388 3972 0.5
(read/write) 128444 129512 1068 0.8
.bss 126372 127444 1072 0.8
.data 2068 2068 0 0.0
.text 784408 788380 3972 0.5
lock-app BRD4161A+wf200 (read only) 945156 946640 1484 0.2
(read/write) 122924 123996 1072 0.9
.bss 120900 121972 1072 0.9
.data 2024 2024 0 0.0
.text 945148 946632 1484 0.2
window-app BRD4161A (read only) 895188 895028 -160 -0.0
(read/write) 133280 133304 24 0.0
.bss 131232 131256 24 0.0
.data 2048 2048 0 0.0
.text 895180 895020 -160 -0.0
esp32 all-clusters-app c3devkit (read only) 998376 1000736 2360 0.2
(read/write) 1477026 1477874 848 0.1
.dram0.bss 67128 68200 1072 1.6
.dram0.data 14576 14608 32 0.2
.flash.rodata 209888 209632 -256 -0.1
.flash.text 998376 1000736 2360 0.2
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053635 1055679 2044 0.2
(read/write) 479024 479888 864 0.2
.dram0.bss 72656 73728 1072 1.5
.dram0.data 34184 34184 0 0.0
.flash.rodata 240188 239980 -208 -0.1
.flash.text 1048251 1050295 2044 0.2
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682516 682748 232 0.0
.bss 80200 80224 24 0.0
.data 2016 2016 0 0.0
.text 598596 598804 208 0.0
lock k32w061+release (read/write) 729012 729228 216 0.0
.bss 80632 80656 24 0.0
.data 1976 1976 0 0.0
.text 644700 644892 192 0.0
linux all-clusters-app debug (read only) 2738905 2748449 9544 0.3
(read/write) 174624 175872 1248 0.7
.bss 83904 85056 1152 1.4
.data 2064 2064 0 0.0
.data.rel.ro 82488 82584 96 0.1
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 238877 238813 -64 -0.0
.text 2323938 2333330 9392 0.4
bridge-app debug+rpc (read only) 2021385 2030385 9000 0.4
(read/write) 146552 147736 1184 0.8
.bss 71744 72832 1088 1.5
.data 3936 3936 0 0.0
.data.rel.ro 65288 65384 96 0.1
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167401 167305 -96 -0.1
.text 1696002 1704882 8880 0.5
chip-tool debug (read only) 9282453 9307853 25400 0.3
(read/write) 578864 580976 2112 0.4
.bss 22816 23936 1120 4.9
.data 1136 1152 16 1.4
.data.rel.ro 548608 549600 992 0.2
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 479061 480437 1376 0.3
.text 7474613 7496261 21648 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9079188 20432 0.2
(read/write) 644993 647105 2112 0.3
.bss 41105 42209 1104 2.7
.data 1192 1192 0 0.0
.data.rel.ro 583864 584840 976 0.2
.dynamic 560 560 0 0.0
.got 14992 15016 24 0.2
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445124 446404 1280 0.3
.text 7149732 7166468 16736 0.2
lighting-app debug+rpc (read only) 2315209 2324945 9736 0.4
(read/write) 152000 153184 1184 0.8
.bss 73536 74624 1088 1.5
.data 2048 2048 0 0.0
.data.rel.ro 70664 70744 80 0.1
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186473 186377 -96 -0.1
.text 1961522 1971138 9616 0.5
lock-app debug (read only) 2228937 2238353 9416 0.4
(read/write) 146680 147864 1184 0.8
.bss 72224 73312 1088 1.5
.data 1568 1568 0 0.0
.data.rel.ro 67192 67272 80 0.1
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 197049 196889 -160 -0.1
.text 1870994 1880354 9360 0.5
ota-provider-app debug (read only) 2049873 2058873 9000 0.4
(read/write) 139728 140944 1216 0.9
.bss 71680 72768 1088 1.5
.data 1768 1768 0 0.0
.data.rel.ro 60488 60616 128 0.2
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177267 177184 -83 -0.0
.text 1714210 1723074 8864 0.5
ota-requestor-app debug (read only) 2079201 2088193 8992 0.4
(read/write) 142568 143720 1152 0.8
.bss 72352 73440 1088 1.5
.data 1992 1992 0 0.0
.data.rel.ro 62584 62648 64 0.1
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173468 173376 -92 -0.1
.text 1745874 1754738 8864 0.5
shell debug (read only) 2555289 2564321 9032 0.4
(read/write) 198552 199768 1216 0.6
.bss 114632 115752 1120 1.0
.data 1376 1376 0 0.0
.data.rel.ro 76776 76872 96 0.1
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 220050 219986 -64 -0.0
.text 2172530 2181410 8880 0.4
thermostat-no-ble arm64 (read only) 2343780 2352044 8264 0.4
(read/write) 175121 176289 1168 0.7
.bss 86465 87585 1120 1.3
.data 1520 1520 0 0.0
.data.rel.ro 79336 79384 48 0.1
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147108 146924 -184 -0.1
.text 1966848 1975104 8256 0.4
tv-app debug (read only) 2841185 2850121 8936 0.3
(read/write) 277472 278720 1248 0.4
.bss 189592 190712 1120 0.6
.data 4672 4672 0 0.0
.data.rel.ro 76960 77080 120 0.2
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219345 219569 224 0.1
.text 2438562 2447058 8496 0.3
tv-casting-app debug (read only) 5403545 5412689 9144 0.2
(read/write) 223776 224992 1216 0.5
.bss 77240 78328 1088 1.4
.data 2368 2368 0 0.0
.data.rel.ro 137952 138072 120 0.1
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337921 337825 -96 -0.0
.text 4705314 4714338 9024 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2420288 1504 0.1
.bss 201588 202668 1080 0.5
.data 5872 5872 0 0.0
.text 1381428 1382932 1504 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180611 368 0.0
bss 138356 138372 16 0.0
rodata 152956 152956 0 0.0
text 810168 810400 232 0.0
p6 all-clusters-app default (read/write) 2532168 2536128 3960 0.2
.bss 135096 136168 1072 0.8
.data 2808 2808 0 0.0
.text 1490432 1494392 3960 0.3
light-app default (read/write) 2418776 2422760 3984 0.2
.bss 128416 129488 1072 0.8
.data 2608 2608 0 0.0
.text 1377040 1381024 3984 0.3
lock-app default (read/write) 2429424 2433408 3984 0.2
.bss 128232 129304 1072 0.8
.data 2568 2568 0 0.0
.text 1387688 1391672 3984 0.3
telink light-switch-app tlsr9518adk80d (read/write) 782124 782388 264 0.0
bss 70592 70608 16 0.0
noinit 40416 40416 0 0.0
text 553036 553284 248 0.0
lighting-app tlsr9518adk80d (read/write) 802216 802480 264 0.0
bss 70848 70864 16 0.0
noinit 40416 40416 0 0.0
text 569802 570050 248 0.0

@andy31415 andy31415 merged commit 5f05a6f into project-chip:master May 18, 2022
@bzbarsky-apple bzbarsky-apple deleted the stop-incorrect-pairing-delegate-bits branch May 18, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagar-apple sagar-apple sagar-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@kghost kghost kghost approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pairing Delegates get repeated calls to OnPairingComplete
5 participants
@bzbarsky-apple @kghost @mrjerryjohns @sagar-apple @andy31415