Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esp32] fix empty is_debug value when debug disabled #18502

Merged
merged 1 commit into from
May 17, 2022

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented May 17, 2022

Problem

is_debug value will be empty if debug is disabled on ESP32, causing the build to fail.

Change overview

Add is_debug false value.

Testing

Build with debug disabled.

@github-actions
Copy link

github-actions bot commented May 17, 2022

PR #18502: Size comparison from f59e7e6 to 957d94d

Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f59e7e6 957d94d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689463 689463 0 0.0
(read/write) 162072 162072 0 0.0
.bss 74516 74516 0 0.0
.data 3412 3412 0 0.0
.rodata 103247 103247 0 0.0
.text 585736 585736 0 0.0
lock-ftd LP_CC2652R7 (read only) 676847 676847 0 0.0
(read/write) 165792 165792 0 0.0
.bss 72676 72676 0 0.0
.data 3236 3236 0 0.0
.rodata 94967 94967 0 0.0
.text 581396 581396 0 0.0
lock-mtd LP_CC2652R7 (read only) 625679 625679 0 0.0
(read/write) 145508 145508 0 0.0
.bss 68412 68412 0 0.0
.data 3236 3236 0 0.0
.rodata 94855 94855 0 0.0
.text 530332 530332 0 0.0
pump-app LP_CC2652R7 (read only) 660355 660355 0 0.0
(read/write) 183564 183564 0 0.0
.bss 72932 72932 0 0.0
.data 3268 3268 0 0.0
.rodata 80467 80467 0 0.0
.text 579408 579408 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653539 653539 0 0.0
(read/write) 190188 190188 0 0.0
.bss 72996 72996 0 0.0
.data 3232 3232 0 0.0
.rodata 83571 83571 0 0.0
.text 569488 569488 0 0.0
shell LP_CC2652R7 (read only) 683826 683826 0 0.0
(read/write) 163532 163532 0 0.0
.bss 77140 77140 0 0.0
.data 3416 3416 0 0.0
.rodata 100794 100794 0 0.0
.text 582548 582548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624734 624734 0 0.0
.app_xip_area 528364 528364 0 0.0
.bss 79012 79012 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627794 627794 0 0.0
.app_xip_area 532880 532880 0 0.0
.bss 77588 77588 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572226 572226 0 0.0
.app_xip_area 467596 467596 0 0.0
.bss 87008 87008 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915052 915052 0 0.0
(read/write) 133220 133220 0 0.0
.bss 131160 131160 0 0.0
.data 2060 2060 0 0.0
.text 915044 915044 0 0.0
BRD4161A+rpc (read only) 949288 949288 0 0.0
(read/write) 149904 149904 0 0.0
.bss 147640 147640 0 0.0
.data 2264 2264 0 0.0
.text 949280 949280 0 0.0
BRD4161A+rs911x (read only) 784400 784400 0 0.0
(read/write) 128444 128444 0 0.0
.bss 126372 126372 0 0.0
.data 2068 2068 0 0.0
.text 784392 784392 0 0.0
lock-app BRD4161A+wf200 (read only) 945140 945140 0 0.0
(read/write) 122924 122924 0 0.0
.bss 120900 120900 0 0.0
.data 2024 2024 0 0.0
.text 945132 945132 0 0.0
window-app BRD4161A (read only) 895172 895172 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131232 131232 0 0.0
.data 2048 2048 0 0.0
.text 895164 895164 0 0.0
esp32 all-clusters-app c3devkit (read only) 996592 996592 0 0.0
(read/write) 1476426 1476426 0 0.0
.dram0.bss 67128 67128 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209288 209288 0 0.0
.flash.text 996592 996592 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1052099 1052099 0 0.0
(read/write) 478448 478448 0 0.0
.dram0.bss 72656 72656 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239612 239612 0 0.0
.flash.text 1046715 1046715 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682468 682468 0 0.0
.bss 80200 80200 0 0.0
.data 2016 2016 0 0.0
.text 598548 598548 0 0.0
lock k32w061+release (read/write) 728980 728980 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 644668 644668 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9044964 9044964 0 0.0
(read/write) 644065 644065 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582936 582936 0 0.0
.dynamic 560 560 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444532 444532 0 0.0
.text 7138724 7138724 0 0.0
thermostat-no-ble arm64 (read only) 2343716 2343716 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86465 86465 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147092 147092 0 0.0
.text 1966800 1966800 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2418784 0 0.0
.bss 201588 201588 0 0.0
.data 5872 5872 0 0.0
.text 1381428 1381428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177075 1177075 0 0.0
bss 138352 138352 0 0.0
rodata 152380 152380 0 0.0
text 807568 807568 0 0.0
p6 all-clusters-app default (read/write) 2529824 2529824 0 0.0
.bss 135088 135088 0 0.0
.data 2808 2808 0 0.0
.text 1488088 1488088 0 0.0
light-app default (read/write) 2418760 2418760 0 0.0
.bss 128416 128416 0 0.0
.data 2608 2608 0 0.0
.text 1377024 1377024 0 0.0
lock-app default (read/write) 2429408 2429408 0 0.0
.bss 128232 128232 0 0.0
.data 2568 2568 0 0.0
.text 1387672 1387672 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782076 782076 0 0.0
bss 70592 70592 0 0.0
noinit 40416 40416 0 0.0
text 552992 552992 0 0.0
lighting-app tlsr9518adk80d (read/write) 802168 802168 0 0.0
bss 70848 70848 0 0.0
noinit 40416 40416 0 0.0
text 569758 569758 0 0.0

@Damian-Nordic Damian-Nordic merged commit 3127d23 into project-chip:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants