-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some useless chip::Platform::MakeUnique in src/app/tests/suite… #18473
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Useless_MakeUnique
May 16, 2022
Merged
Remove some useless chip::Platform::MakeUnique in src/app/tests/suite… #18473
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Useless_MakeUnique
May 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/commands/interaction_model/InteractionModel.h
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
May 16, 2022 13:16
pullapprove
bot
requested review from
jtung-apple,
yufengwangca,
kghost,
yunhanw-google,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple and
xylophone21
May 16, 2022 13:16
Damian-Nordic
approved these changes
May 16, 2022
PR #18473: Size comparison from 04b4f07 to 17b6ca9 Decreases (2 builds for linux)
Full report (36 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
May 16, 2022
andy31415
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s/commands/interaction_model/InteractionModel.h
Problem
From some comments from #18375 (comment) for adding group commands to the darwin Framework, it looks like some of group command code for
chip-tool
/YAML
needs to be updated as well.Change overview