Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some useless chip::Platform::MakeUnique in src/app/tests/suite… #18473

Merged
merged 1 commit into from
May 16, 2022

Conversation

vivien-apple
Copy link
Contributor

…s/commands/interaction_model/InteractionModel.h

Problem

From some comments from #18375 (comment) for adding group commands to the darwin Framework, it looks like some of group command code for chip-tool/YAML needs to be updated as well.

Change overview

  • Remove make_unique calls.

…s/commands/interaction_model/InteractionModel.h
@github-actions
Copy link

github-actions bot commented May 16, 2022

PR #18473: Size comparison from 04b4f07 to 17b6ca9

Decreases (2 builds for linux)
platform target config section 04b4f07 17b6ca9 change % change
linux chip-tool debug (read only) 9266501 9227381 -39120 -0.4
.text 7465061 7425941 -39120 -0.5
chip-tool-no-interactive-ipv6only arm64 (read only) 9060036 9006564 -53472 -0.6
.text 7157156 7103684 -53472 -0.7
Full report (36 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 04b4f07 17b6ca9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689019 689019 0 0.0
(read/write) 163260 163260 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103099 103099 0 0.0
.text 585440 585440 0 0.0
lock-ftd LP_CC2652R7 (read only) 676363 676363 0 0.0
(read/write) 167004 167004 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94811 94811 0 0.0
.text 581068 581068 0 0.0
lock-mtd LP_CC2652R7 (read only) 625179 625179 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94691 0 0.0
.text 529996 529996 0 0.0
pump-app LP_CC2652R7 (read only) 659951 659951 0 0.0
(read/write) 184704 184704 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80351 80351 0 0.0
.text 579120 579120 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653115 653115 0 0.0
(read/write) 191340 191340 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83451 83451 0 0.0
.text 569184 569184 0 0.0
shell LP_CC2652R7 (read only) 683406 683406 0 0.0
(read/write) 164696 164696 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100646 100646 0 0.0
.text 582276 582276 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 625226 625226 0 0.0
.app_xip_area 527880 527880 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572946 572946 0 0.0
.app_xip_area 467340 467340 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914572 914572 0 0.0
(read/write) 134436 134436 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 914564 914564 0 0.0
BRD4161A+rpc (read only) 948744 948744 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 948736 948736 0 0.0
BRD4161A+rs911x (read only) 783552 783552 0 0.0
(read/write) 129660 129660 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 783544 783544 0 0.0
lock-app BRD4161A+wf200 (read only) 944364 944364 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 944356 944356 0 0.0
window-app BRD4161A (read only) 894828 894828 0 0.0
(read/write) 134496 134496 0 0.0
.bss 132448 132448 0 0.0
.data 2048 2048 0 0.0
.text 894820 894820 0 0.0
esp32 all-clusters-app c3devkit (read only) 996224 996224 0 0.0
(read/write) 1477522 1477522 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209168 209168 0 0.0
.flash.text 996224 996224 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1051639 1051639 0 0.0
(read/write) 479560 479560 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239508 239508 0 0.0
.flash.text 1046255 1046255 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683140 683140 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 598244 598244 0 0.0
lock k32w061+release (read/write) 729512 729512 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 644224 644224 0 0.0
linux all-clusters-app debug (read only) 2728897 2728897 0 0.0
(read/write) 174456 174456 0 0.0
.bss 83808 83808 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237533 237533 0 0.0
.text 2315490 2315490 0 0.0
bridge-app debug+rpc (read only) 1897417 1897417 0 0.0
(read/write) 120984 120984 0 0.0
.bss 71424 71424 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161913 161913 0 0.0
.text 1612146 1612146 0 0.0
chip-tool debug (read only) 9266501 9227381 -39120 -0.4
(read/write) 577008 577008 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 546752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 476981 476981 0 0.0
.text 7465061 7425941 -39120 -0.5
chip-tool-no-interactive-ipv6only arm64 (read only) 9060036 9006564 -53472 -0.6
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157156 7103684 -53472 -0.7
lighting-app debug+rpc (read only) 2310617 2310617 0 0.0
(read/write) 151904 151904 0 0.0
.bss 73440 73440 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185897 185897 0 0.0
.text 1957506 1957506 0 0.0
lock-app debug (read only) 2224441 2224441 0 0.0
(read/write) 146552 146552 0 0.0
.bss 72096 72096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196601 196601 0 0.0
.text 1866946 1866946 0 0.0
ota-provider-app debug (read only) 2045377 2045377 0 0.0
(read/write) 139632 139632 0 0.0
.bss 71584 71584 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176851 176851 0 0.0
.text 1710130 1710130 0 0.0
ota-requestor-app debug (read only) 2075265 2075265 0 0.0
(read/write) 142440 142440 0 0.0
.bss 72224 72224 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172956 172956 0 0.0
.text 1742450 1742450 0 0.0
shell debug (read only) 2545241 2545241 0 0.0
(read/write) 198256 198256 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218706 218706 0 0.0
.text 2164050 2164050 0 0.0
thermostat-no-ble arm64 (read only) 2339956 2339956 0 0.0
(read/write) 175009 175009 0 0.0
.bss 86353 86353 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1963152 1963152 0 0.0
tv-app debug (read only) 2834417 2834417 0 0.0
(read/write) 277376 277376 0 0.0
.bss 189528 189528 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218897 218897 0 0.0
.text 2432290 2432290 0 0.0
tv-casting-app debug (read only) 5399369 5399369 0 0.0
(read/write) 223680 223680 0 0.0
.bss 77144 77144 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337537 337537 0 0.0
.text 4701522 4701522 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418176 2418176 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1380820 1380820 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177955 1177955 0 0.0
bss 139568 139568 0 0.0
rodata 152268 152268 0 0.0
text 807288 807288 0 0.0
p6 all-clusters-app default (read/write) 2528904 2528904 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1487168 1487168 0 0.0
light-app default (read/write) 2417800 2417800 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1376064 1376064 0 0.0
lock-app default (read/write) 2428448 2428448 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1386712 1386712 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 802764 802764 0 0.0
bss 72064 72064 0 0.0
noinit 40416 40416 0 0.0
text 569258 569258 0 0.0

@andy31415 andy31415 merged commit 0ddaa8b into project-chip:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants