Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FastWriter for TlvJson #18456

Merged
merged 1 commit into from
May 17, 2022
Merged

Use FastWriter for TlvJson #18456

merged 1 commit into from
May 17, 2022

Conversation

CodeChronos928
Copy link
Contributor

@CodeChronos928 CodeChronos928 commented May 14, 2022 •
edited
Loading

TlvJson now outputs a compact machine-readable string, instead of one that's human-readable.

Problem

I'm using TlvJson to generate attribute values in JSON format, and I want the string to be compact. It's currently outputting human-readable JSON that's full of extra white space.

I don't believe this library was meant for debug purposes only, so I propose to change the TlvJson behavior rather than re-formatting the JSON on the app side. Folks that are using it to debug can always run it through python -m json.tool

Change overview

Adjust TlvJson to output a compact machine-readable JSON format.

Before
{
   "value" : {
      "0" : 20,
      "1" : true,
      "2" : 0,
      "3" : "AQIDBP/+mYjdzQ==",
      "4" : "hello",
      "5" : 0,
      "6" : 1.0,
      "7" : 1.0
   }
}
After
{"value":{"0":20,"1":true,"2":0,"3":"AQIDBP/+mYjdzQ==","4":"hello","5":0,"6":1.0,"7":1.0}}

Testing

  • Successfully ran ninja -v -k 0 check
  • Verified that the output is the compact format that was desired.

@boring-cyborg boring-cyborg bot added the lib label May 14, 2022
@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18456: Size comparison from e4782f6 to ca71036

Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e4782f6 ca71036 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692347 0 0.0
(read/write) 159932 159932 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588600 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686734 0 0.0
(read/write) 161368 161368 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000174 0 0.0
(read/write) 1477650 1477650 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209256 209256 0 0.0
.flash.text 1000174 1000174 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054103 1054103 0 0.0
(read/write) 479552 479552 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239500 239500 0 0.0
.flash.text 1048719 1048719 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181131 1181131 0 0.0
bss 139560 139560 0 0.0
rodata 152428 152428 0 0.0
text 810316 810316 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806400 806400 0 0.0
bss 72056 72056 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18456: Size comparison from b4509f3 to 2243bfd

Full report (11 builds for cyw30739, linux, mbed, nrfconnect, p6, telink)
platform target config section b4509f3 2243bfd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181131 1181131 0 0.0
bss 139560 139560 0 0.0
rodata 152428 152428 0 0.0
text 810316 810316 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806400 806400 0 0.0
bss 72056 72056 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18456: Size comparison from b4509f3 to ad6a1c4

Full report (33 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b4509f3 ad6a1c4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692347 0 0.0
(read/write) 159932 159932 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588600 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686734 0 0.0
(read/write) 161368 161368 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux all-clusters-app debug (read only) 2750953 2750953 0 0.0
(read/write) 174552 174552 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237541 237541 0 0.0
.text 2337538 2337538 0 0.0
bridge-app debug+rpc (read only) 1897337 1897337 0 0.0
(read/write) 121080 121080 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161753 161753 0 0.0
.text 1612226 1612226 0 0.0
chip-tool debug (read only) 9266261 9266261 0 0.0
(read/write) 577008 577008 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 546752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 476789 476789 0 0.0
.text 7465013 7465013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
lighting-app debug+rpc (read only) 2330953 2330953 0 0.0
(read/write) 152032 152032 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185913 185913 0 0.0
.text 1977826 1977826 0 0.0
lock-app debug (read only) 2246681 2246681 0 0.0
(read/write) 146648 146648 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196617 196617 0 0.0
.text 1889170 1889170 0 0.0
ota-provider-app debug (read only) 2067569 2067569 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176819 176819 0 0.0
.text 1732354 1732354 0 0.0
ota-requestor-app debug (read only) 2097473 2097473 0 0.0
(read/write) 142536 142536 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172956 172956 0 0.0
.text 1764658 1764658 0 0.0
shell debug (read only) 2569809 2569809 0 0.0
(read/write) 198288 198288 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4208 4208 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218706 218706 0 0.0
.text 2188322 2188322 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
tv-app debug (read only) 2855657 2855657 0 0.0
(read/write) 277472 277472 0 0.0
.bss 189624 189624 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218891 218891 0 0.0
.text 2453538 2453538 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181131 1181131 0 0.0
bss 139560 139560 0 0.0
rodata 152428 152428 0 0.0
text 810316 810316 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806400 806400 0 0.0
bss 72056 72056 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@CodeChronos928
Copy link
Contributor Author

CodeChronos928 commented May 14, 2022 •
edited
Loading

@mrjerryjohns - I removed your "#if 0" block, as I believe I achieved your original goal. Instead of comparing Json::Values though, I normalized the reference string to be in the format expected from the library. This ensures the library is generating the expected format, and also removes white-space requirements in the reference strings. I left your reference strings as-is since they are easier to read when examining a test failure or writing new tests.

@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18456: Size comparison from b4509f3 to 48bac1e

Full report (33 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b4509f3 48bac1e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692347 0 0.0
(read/write) 159932 159932 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588600 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686734 0 0.0
(read/write) 161368 161368 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux all-clusters-app debug (read only) 2750953 2750953 0 0.0
(read/write) 174552 174552 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237541 237541 0 0.0
.text 2337538 2337538 0 0.0
bridge-app debug+rpc (read only) 1897337 1897337 0 0.0
(read/write) 121080 121080 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161753 161753 0 0.0
.text 1612226 1612226 0 0.0
chip-tool debug (read only) 9266261 9266261 0 0.0
(read/write) 577008 577008 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 546752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 476789 476789 0 0.0
.text 7465013 7465013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
lighting-app debug+rpc (read only) 2330953 2330953 0 0.0
(read/write) 152032 152032 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185913 185913 0 0.0
.text 1977826 1977826 0 0.0
lock-app debug (read only) 2246681 2246681 0 0.0
(read/write) 146648 146648 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196617 196617 0 0.0
.text 1889170 1889170 0 0.0
ota-provider-app debug (read only) 2067569 2067569 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176819 176819 0 0.0
.text 1732354 1732354 0 0.0
ota-requestor-app debug (read only) 2097473 2097473 0 0.0
(read/write) 142536 142536 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172956 172956 0 0.0
.text 1764658 1764658 0 0.0
shell debug (read only) 2569809 2569809 0 0.0
(read/write) 198288 198288 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4208 4208 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218706 218706 0 0.0
.text 2188322 2188322 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
tv-app debug (read only) 2855657 2855657 0 0.0
(read/write) 277472 277472 0 0.0
.bss 189624 189624 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218891 218891 0 0.0
.text 2453538 2453538 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181131 1181131 0 0.0
bss 139560 139560 0 0.0
rodata 152428 152428 0 0.0
text 810316 810316 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806400 806400 0 0.0
bss 72056 72056 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@CodeChronos928
Use FastWriter for TlvJson
7219797 
TlvJson now outputs a more RPC-friendly string, instead of a
human-readable string.
@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18456: Size comparison from f829356 to 7219797

Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f829356 7219797 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692347 0 0.0
(read/write) 159932 159932 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588600 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686734 0 0.0
(read/write) 161368 161368 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000174 0 0.0
(read/write) 1477650 1477650 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209256 209256 0 0.0
.flash.text 1000174 1000174 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054103 1054103 0 0.0
(read/write) 479552 479552 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239500 239500 0 0.0
.flash.text 1048719 1048719 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181131 1181131 0 0.0
bss 139560 139560 0 0.0
rodata 152428 152428 0 0.0
text 810316 810316 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806400 806400 0 0.0
bss 72056 72056 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

turon
turon approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tcarmelveilleux tcarmelveilleux merged commit 84a3783 into project-chip:master May 17, 2022
@CodeChronos928 CodeChronos928 deleted the PR2 branch June 1, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@arkq arkq Awaiting requested review from arkq

@turon turon Awaiting requested review from turon

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CodeChronos928 @turon @mrjerryjohns @arkq @tcarmelveilleux