Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for UDCClientState #18449

Merged
merged 11 commits into from
May 17, 2022
Merged

Add unit tests for UDCClientState #18449

merged 11 commits into from
May 17, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

Change overview

Add unit tests for the UDCClientState object

Testing

  • unit tests perform a basic sanity check of the getters and setters of the UDCClientState object

@chrisdecenzo chrisdecenzo changed the title Add unit tests for UDCClientState DRAFT - Add unit tests for UDCClientState May 13, 2022
@github-actions
Copy link

github-actions bot commented May 13, 2022 •
edited
Loading

PR #18449: Size comparison from c337eef to bbc37b4

Decreases (1 build for linux)
platform target config section c337eef bbc37b4 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060052 9060036 -16 -0.0
.text 7157172 7157156 -16 -0.0
Full report (7 builds for cyw30739, linux, mbed, nrfconnect)
platform target config section c337eef bbc37b4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 628454 628454 0 0.0
.app_xip_area 531012 531012 0 0.0
.bss 80084 80084 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628390 628390 0 0.0
.app_xip_area 532404 532404 0 0.0
.bss 78660 78660 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576154 576154 0 0.0
.app_xip_area 470452 470452 0 0.0
.bss 88080 88080 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060052 9060036 -16 -0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157172 7157156 -16 -0.0
thermostat-no-ble arm64 (read only) 2370244 2370244 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1993376 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421692 2421692 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1384292 1384292 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181283 0 0.0
bss 139680 139680 0 0.0
rodata 152436 152436 0 0.0
text 810324 810324 0 0.0

@restyled-io restyled-io bot mentioned this pull request May 13, 2022
Merged
@chrisdecenzo chrisdecenzo changed the title DRAFT - Add unit tests for UDCClientState Add unit tests for UDCClientState May 13, 2022
@github-actions
Copy link

github-actions bot commented May 13, 2022 •
edited
Loading

PR #18449: Size comparison from c337eef to 95ed81c

Decreases (3 builds for esp32, mbed)
platform target config section c337eef 95ed81c change % change
esp32 all-clusters-app c3devkit (read only) 1000182 1000174 -8 -0.0
(read/write) 1477794 1477650 -144 -0.0
.dram0.bss 68472 68352 -120 -0.2
.flash.rodata 209272 209256 -16 -0.0
.flash.text 1000182 1000174 -8 -0.0
m5stack (read only) 1054183 1054103 -80 -0.0
(read/write) 479680 479552 -128 -0.0
.dram0.bss 73992 73872 -120 -0.2
.flash.rodata 239508 239500 -8 -0.0
.flash.text 1048799 1048719 -80 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2421692 2421684 -8 -0.0
.bss 205820 205436 -384 -0.2
.text 1384292 1384284 -8 -0.0
Full report (3 builds for esp32, mbed)
platform target config section c337eef 95ed81c change % change
esp32 all-clusters-app c3devkit (read only) 1000182 1000174 -8 -0.0
(read/write) 1477794 1477650 -144 -0.0
.dram0.bss 68472 68352 -120 -0.2
.dram0.data 14568 14568 0 0.0
.flash.rodata 209272 209256 -16 -0.0
.flash.text 1000182 1000174 -8 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054183 1054103 -80 -0.0
(read/write) 479680 479552 -128 -0.0
.dram0.bss 73992 73872 -120 -0.2
.dram0.data 34184 34184 0 0.0
.flash.rodata 239508 239500 -8 -0.0
.flash.text 1048799 1048719 -80 -0.0
.iram0.text 123267 123267 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421692 2421684 -8 -0.0
.bss 205820 205436 -384 -0.2
.data 5872 5872 0 0.0
.text 1384292 1384284 -8 -0.0

@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18449: Size comparison from 9f755f9 to b18243c

Full report (7 builds for cyw30739, mbed, p6)
platform target config section 9f755f9 b18243c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0

@restyled-io restyled-io bot mentioned this pull request May 17, 2022
Merged
@chrisdecenzo chrisdecenzo merged commit 05a20b1 into master May 17, 2022
@chrisdecenzo chrisdecenzo deleted the tv-apps-android6 branch May 17, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@andy31415 andy31415 Awaiting requested review from andy31415

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@msandstedt msandstedt Awaiting requested review from msandstedt

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisdecenzo @andy31415 @msandstedt @bzbarsky-apple