-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-app:content-app to tv-app:platform-app service binding and command response support #18353
Merged
chrisdecenzo
merged 2 commits into
project-chip:master
from
amitnj:tv-app-service-binding
May 12, 2022
Merged
tv-app:content-app to tv-app:platform-app service binding and command response support #18353
chrisdecenzo
merged 2 commits into
project-chip:master
from
amitnj:tv-app-service-binding
May 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitnj
force-pushed
the
tv-app-service-binding
branch
from
May 12, 2022 00:31
a96a51c
to
03d788b
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
May 12, 2022 00:31
pullapprove
bot
requested review from
LuDuda,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
May 12, 2022 00:31
chrisdecenzo
approved these changes
May 12, 2022
PR #18353: Size comparison from f59dbe1 to 03d788b Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
lazarkov
approved these changes
May 12, 2022
hawk248
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current implementation of the example for the platform-app and content-app do not support sending a response for a matter command. It also limits discovery of content apps to static mode where the clusters are defined in a manifest file. Couple of other problems were, it was only working on <25 API version android system because of requirement to get PACKAGE_ADDED/REMOVED updates.
Change overview
Introduced a service binding mechanism to enable content-app to talk to platform-app. Also introduced a pending-intent when sending matter commands to content app which it can use to send back responses. Fixed the issue with package updates not coming for latest android versions.
Testing
How was this tested? (at least one bullet point required)
Tested manually on an emulator by running the platform-app and content-app.