Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add a test for successful OTA transfer #18344

Merged
merged 2 commits into from
May 18, 2022
Merged

[CI] Add a test for successful OTA transfer #18344

merged 2 commits into from
May 18, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

There is currently no CI test for a basic successful OTA transfer

Change overview

  • Add a simple test for successful OTA transfer
  • Requires ota-provider-app and ota-requestor-app to be built and passed into run_test_suite.py
  • Map the default app to launch in this test to be ota-requestor-app
  • Add ability to pass in OTA-specific arguments to SystemCommands:Start
  • Add helper script to create an OTA image
  • Add helper script to compare to files for verification purpose
  • Add a generic function to wait for a particular message for verification purpose

Testing

  • Ran this locally and verified that the test passes:
./scripts/tests/run_test_suite.py --target OTA_SuccessfulTransfer --chip-tool out/chip-tool/chip-tool --log-level debug run --iterations 1 --all-clusters-app out/all-clusters/chip-all-clusters-app --lock-app out/lock/chip-lock-app --ota-provider-app out/ota-provider/chip-ota-provider-app --ota-requestor-app out/ota-requestor/chip-ota-requestor-app --tv-app out/tv/chip-tv-app

@carol-apple carol-apple force-pushed the ci_test_suite_ota_successful branch from 52438b6 to 8d24867 Compare May 13, 2022 21:25
@github-actions
Copy link

github-actions bot commented May 13, 2022 •
edited
Loading

PR #18344: Size comparison from d588937 to 8d24867

Increases above 0.2%:

platform target config section d588937 8d24867 change % change
linux chip-tool debug .rodata 476789 478101 1312 0.3
Increases (2 builds for linux)
platform target config section d588937 8d24867 change % change
linux chip-tool debug (read only) 9266421 9282581 16160 0.2
(read/write) 577008 577936 928 0.2
.data.rel.ro 546752 547680 928 0.2
.rodata 476789 478101 1312 0.3
.text 7465173 7477861 12688 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9060052 9072068 12016 0.1
(read/write) 643121 644065 944 0.1
.data.rel.ro 582008 582936 928 0.2
.got 14976 14984 8 0.1
.rodata 443348 444452 1104 0.2
.text 7157172 7165908 8736 0.1
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d588937 8d24867 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692379 692379 0 0.0
(read/write) 159972 159972 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588632 588632 0 0.0
lock-ftd LP_CC2652R7 (read only) 679755 679755 0 0.0
(read/write) 163684 163684 0 0.0
.bss 73476 73476 0 0.0
.data 3236 3236 0 0.0
.rodata 94987 94987 0 0.0
.text 584284 584284 0 0.0
lock-mtd LP_CC2652R7 (read only) 628579 628579 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94867 94867 0 0.0
.text 533220 533220 0 0.0
pump-app LP_CC2652R7 (read only) 663303 663303 0 0.0
(read/write) 181424 181424 0 0.0
.bss 73740 73740 0 0.0
.data 3268 3268 0 0.0
.rodata 80527 80527 0 0.0
.text 582296 582296 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656495 656495 0 0.0
(read/write) 188032 188032 0 0.0
.bss 73796 73796 0 0.0
.data 3232 3232 0 0.0
.rodata 83615 83615 0 0.0
.text 572400 572400 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628454 628454 0 0.0
.app_xip_area 531012 531012 0 0.0
.bss 80084 80084 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628390 628390 0 0.0
.app_xip_area 532404 532404 0 0.0
.bss 78660 78660 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576154 576154 0 0.0
.app_xip_area 470452 470452 0 0.0
.bss 88080 88080 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918728 918728 0 0.0
(read/write) 134560 134560 0 0.0
.bss 132496 132496 0 0.0
.data 2060 2060 0 0.0
.text 918720 918720 0 0.0
BRD4161A+rpc (read only) 952932 952932 0 0.0
(read/write) 151240 151240 0 0.0
.bss 148976 148976 0 0.0
.data 2264 2264 0 0.0
.text 952924 952924 0 0.0
BRD4161A+rs911x (read only) 787724 787724 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787716 787716 0 0.0
lock-app BRD4161A+wf200 (read only) 947696 947696 0 0.0
(read/write) 124260 124260 0 0.0
.bss 122236 122236 0 0.0
.data 2024 2024 0 0.0
.text 947688 947688 0 0.0
window-app BRD4161A (read only) 899032 899032 0 0.0
(read/write) 134504 134504 0 0.0
.bss 132456 132456 0 0.0
.data 2048 2048 0 0.0
.text 899024 899024 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000182 1000182 0 0.0
(read/write) 1477794 1477794 0 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209272 209272 0 0.0
.flash.text 1000182 1000182 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054183 1054183 0 0.0
(read/write) 479680 479680 0 0.0
.dram0.bss 73992 73992 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239508 239508 0 0.0
.flash.text 1048799 1048799 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686376 686376 0 0.0
.bss 81272 81272 0 0.0
.data 2016 2016 0 0.0
.text 601384 601384 0 0.0
lock k32w061+release (read/write) 732736 732736 0 0.0
.bss 81704 81704 0 0.0
.data 1976 1976 0 0.0
.text 647352 647352 0 0.0
linux all-clusters-app debug (read only) 2751065 2751065 0 0.0
(read/write) 174552 174552 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237541 237541 0 0.0
.text 2337650 2337650 0 0.0
bridge-app debug+rpc (read only) 1897449 1897449 0 0.0
(read/write) 121080 121080 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161753 161753 0 0.0
.text 1612338 1612338 0 0.0
chip-tool debug (read only) 9266421 9282581 16160 0.2
(read/write) 577008 577936 928 0.2
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 547680 928 0.2
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 476789 478101 1312 0.3
.text 7465173 7477861 12688 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9060052 9072068 12016 0.1
(read/write) 643121 644065 944 0.1
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582936 928 0.2
.dynamic 560 560 0 0.0
.got 14976 14984 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 444452 1104 0.2
.text 7157172 7165908 8736 0.1
lighting-app debug+rpc (read only) 2331065 2331065 0 0.0
(read/write) 152032 152032 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185913 185913 0 0.0
.text 1977938 1977938 0 0.0
lock-app debug (read only) 2246793 2246793 0 0.0
(read/write) 146648 146648 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196617 196617 0 0.0
.text 1889282 1889282 0 0.0
ota-provider-app debug (read only) 2067713 2067713 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176851 176851 0 0.0
.text 1732466 1732466 0 0.0
ota-requestor-app debug (read only) 2097585 2097585 0 0.0
(read/write) 142536 142536 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172956 172956 0 0.0
.text 1764770 1764770 0 0.0
shell debug (read only) 2569921 2569921 0 0.0
(read/write) 198288 198288 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4208 4208 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218706 218706 0 0.0
.text 2188434 2188434 0 0.0
thermostat-no-ble arm64 (read only) 2370244 2370244 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1993376 0 0.0
tv-app debug (read only) 2855801 2855801 0 0.0
(read/write) 277472 277472 0 0.0
.bss 189624 189624 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218891 218891 0 0.0
.text 2453682 2453682 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421692 2421692 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1384292 1384292 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181283 0 0.0
bss 139680 139680 0 0.0
rodata 152436 152436 0 0.0
text 810324 810324 0 0.0
p6 all-clusters-app default (read/write) 2533064 2533064 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1491328 1491328 0 0.0
light-app default (read/write) 2422016 2422016 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1380280 0 0.0
lock-app default (read/write) 2432664 2432664 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1390928 1390928 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806528 806528 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@carol-apple carol-apple force-pushed the ci_test_suite_ota_successful branch from 8d24867 to 10676df Compare May 14, 2022 02:59
@github-actions
Copy link

github-actions bot commented May 14, 2022 •
edited
Loading

PR #18344: Size comparison from 9f755f9 to 10676df

Increases above 0.2%:

platform target config section 9f755f9 10676df change % change
linux chip-tool debug .rodata 476789 478101 1312 0.3
Increases (2 builds for linux)
platform target config section 9f755f9 10676df change % change
linux chip-tool debug (read only) 9266261 9282421 16160 0.2
(read/write) 577008 577936 928 0.2
.data.rel.ro 546752 547680 928 0.2
.rodata 476789 478101 1312 0.3
.text 7465013 7477701 12688 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9071988 11984 0.1
(read/write) 643121 644065 944 0.1
.data.rel.ro 582008 582936 928 0.2
.got 14976 14984 8 0.1
.rodata 443348 444436 1088 0.2
.text 7157124 7165844 8720 0.1
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9f755f9 10676df change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692347 0 0.0
(read/write) 159932 159932 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588600 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686734 0 0.0
(read/write) 161368 161368 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000174 0 0.0
(read/write) 1477650 1477650 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209256 209256 0 0.0
.flash.text 1000174 1000174 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054103 1054103 0 0.0
(read/write) 479552 479552 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239500 239500 0 0.0
.flash.text 1048719 1048719 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux all-clusters-app debug (read only) 2750953 2750953 0 0.0
(read/write) 174552 174552 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237541 237541 0 0.0
.text 2337538 2337538 0 0.0
bridge-app debug+rpc (read only) 1897337 1897337 0 0.0
(read/write) 121080 121080 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161753 161753 0 0.0
.text 1612226 1612226 0 0.0
chip-tool debug (read only) 9266261 9282421 16160 0.2
(read/write) 577008 577936 928 0.2
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 547680 928 0.2
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 476789 478101 1312 0.3
.text 7465013 7477701 12688 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9071988 11984 0.1
(read/write) 643121 644065 944 0.1
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582936 928 0.2
.dynamic 560 560 0 0.0
.got 14976 14984 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 444436 1088 0.2
.text 7157124 7165844 8720 0.1
lighting-app debug+rpc (read only) 2330953 2330953 0 0.0
(read/write) 152032 152032 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185913 185913 0 0.0
.text 1977826 1977826 0 0.0
lock-app debug (read only) 2246681 2246681 0 0.0
(read/write) 146648 146648 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196617 196617 0 0.0
.text 1889170 1889170 0 0.0
ota-provider-app debug (read only) 2067569 2067569 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176819 176819 0 0.0
.text 1732354 1732354 0 0.0
ota-requestor-app debug (read only) 2097473 2097473 0 0.0
(read/write) 142536 142536 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172956 172956 0 0.0
.text 1764658 1764658 0 0.0
shell debug (read only) 2569809 2569809 0 0.0
(read/write) 198288 198288 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4208 4208 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218706 218706 0 0.0
.text 2188322 2188322 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
tv-app debug (read only) 2855657 2855657 0 0.0
(read/write) 277472 277472 0 0.0
.bss 189624 189624 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218891 218891 0 0.0
.text 2453538 2453538 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181131 1181131 0 0.0
bss 139560 139560 0 0.0
rodata 152428 152428 0 0.0
text 810316 810316 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806400 806400 0 0.0
bss 72056 72056 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@carol-apple carol-apple force-pushed the ci_test_suite_ota_successful branch from 10676df to d40b832 Compare May 15, 2022 03:17
@github-actions
Copy link

github-actions bot commented May 15, 2022 •
edited
Loading

PR #18344: Size comparison from 25e241e to d40b832

Increases (1 build for linux)
platform target config section 25e241e d40b832 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9071988 11984 0.1
(read/write) 643121 644065 944 0.1
.data.rel.ro 582008 582936 928 0.2
.got 14976 14984 8 0.1
.rodata 443348 444436 1088 0.2
.text 7157124 7165844 8720 0.1
Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 25e241e d40b832 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692347 0 0.0
(read/write) 159932 159932 0 0.0
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588600 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686734 0 0.0
(read/write) 161368 161368 0 0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000174 0 0.0
(read/write) 1477650 1477650 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209256 209256 0 0.0
.flash.text 1000174 1000174 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054103 1054103 0 0.0
(read/write) 479552 479552 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239500 239500 0 0.0
.flash.text 1048719 1048719 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9071988 11984 0.1
(read/write) 643121 644065 944 0.1
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582936 928 0.2
.dynamic 560 560 0 0.0
.got 14976 14984 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 444436 1088 0.2
.text 7157124 7165844 8720 0.1
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181283 0 0.0
bss 139568 139568 0 0.0
rodata 152428 152428 0 0.0
text 810452 810452 0 0.0
p6 all-clusters-app default (read/write) 2533016 2533016 0 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491280 0 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806568 806568 0 0.0
bss 72064 72064 0 0.0
noinit 40416 40416 0 0.0
text 572918 572918 0 0.0

tcarmelveilleux
tcarmelveilleux requested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment •
edited by carol-apple
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing documentation in several critical places
  • Requires justification of timeout changes on all of CI

@carol-apple
[CI] Add a test for successful OTA transfer
5937207
@carol-apple
Address code review comments
340a702 
- Revert time bumps
- Add a main function to all the newly added python scripts
- Add documentation on WaitForMessage API
@carol-apple carol-apple force-pushed the ci_test_suite_ota_successful branch from d40b832 to 340a702 Compare May 17, 2022 18:01
@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

PR #18344: Size comparison from 05a20b1 to 340a702

Increases above 0.2%:

platform target config section 05a20b1 340a702 change % change
linux chip-tool debug .rodata 479061 480309 1248 0.3
Increases (2 builds for linux)
platform target config section 05a20b1 340a702 change % change
linux chip-tool debug (read only) 9282453 9298549 16096 0.2
(read/write) 578864 579792 928 0.2
.data.rel.ro 548608 549536 928 0.2
.rodata 479061 480309 1248 0.3
.text 7474613 7487301 12688 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9070756 12000 0.1
(read/write) 644993 645937 944 0.1
.data.rel.ro 583864 584792 928 0.2
.got 14992 15000 8 0.1
.rodata 445124 446228 1104 0.2
.text 7149732 7158452 8720 0.1
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 05a20b1 340a702 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692151 692151 0 0.0
(read/write) 159384 159384 0 0.0
.bss 74516 74516 0 0.0
.data 3412 3412 0 0.0
.rodata 103823 103823 0 0.0
.text 587848 587848 0 0.0
lock-ftd LP_CC2652R7 (read only) 676863 676863 0 0.0
(read/write) 165776 165776 0 0.0
.bss 72676 72676 0 0.0
.data 3236 3236 0 0.0
.rodata 94967 94967 0 0.0
.text 581412 581412 0 0.0
lock-mtd LP_CC2652R7 (read only) 625695 625695 0 0.0
(read/write) 145508 145508 0 0.0
.bss 68412 68412 0 0.0
.data 3236 3236 0 0.0
.rodata 94855 94855 0 0.0
.text 530348 530348 0 0.0
pump-app LP_CC2652R7 (read only) 660387 660387 0 0.0
(read/write) 183532 183532 0 0.0
.bss 72932 72932 0 0.0
.data 3268 3268 0 0.0
.rodata 80467 80467 0 0.0
.text 579440 579440 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 190172 190172 0 0.0
.bss 72996 72996 0 0.0
.data 3232 3232 0 0.0
.rodata 83571 83571 0 0.0
.text 569504 569504 0 0.0
shell LP_CC2652R7 (read only) 686538 686538 0 0.0
(read/write) 160820 160820 0 0.0
.bss 77140 77140 0 0.0
.data 3416 3416 0 0.0
.rodata 101370 101370 0 0.0
.text 584684 584684 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624766 0 0.0
.app_xip_area 528396 528396 0 0.0
.bss 79012 79012 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627826 627826 0 0.0
.app_xip_area 532912 532912 0 0.0
.bss 77588 77588 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572266 0 0.0
.app_xip_area 467636 467636 0 0.0
.bss 87008 87008 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915068 915068 0 0.0
(read/write) 133220 133220 0 0.0
.bss 131160 131160 0 0.0
.data 2060 2060 0 0.0
.text 915060 915060 0 0.0
BRD4161A+rpc (read only) 949304 949304 0 0.0
(read/write) 149904 149904 0 0.0
.bss 147640 147640 0 0.0
.data 2264 2264 0 0.0
.text 949296 949296 0 0.0
BRD4161A+rs911x (read only) 784416 784416 0 0.0
(read/write) 128444 128444 0 0.0
.bss 126372 126372 0 0.0
.data 2068 2068 0 0.0
.text 784408 784408 0 0.0
lock-app BRD4161A+wf200 (read only) 945156 945156 0 0.0
(read/write) 122924 122924 0 0.0
.bss 120900 120900 0 0.0
.data 2024 2024 0 0.0
.text 945148 945148 0 0.0
window-app BRD4161A (read only) 895188 895188 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131232 131232 0 0.0
.data 2048 2048 0 0.0
.text 895180 895180 0 0.0
esp32 all-clusters-app c3devkit (read only) 998376 998376 0 0.0
(read/write) 1477026 1477026 0 0.0
.dram0.bss 67128 67128 0 0.0
.dram0.data 14576 14576 0 0.0
.flash.rodata 209888 209888 0 0.0
.flash.text 998376 998376 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053635 1053635 0 0.0
(read/write) 479024 479024 0 0.0
.dram0.bss 72656 72656 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 240188 240188 0 0.0
.flash.text 1048251 1048251 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682516 682516 0 0.0
.bss 80200 80200 0 0.0
.data 2016 2016 0 0.0
.text 598596 598596 0 0.0
lock k32w061+release (read/write) 729012 729012 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 644700 644700 0 0.0
linux all-clusters-app debug (read only) 2738905 2738905 0 0.0
(read/write) 174624 174624 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82488 82488 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 238877 238877 0 0.0
.text 2323938 2323938 0 0.0
bridge-app debug+rpc (read only) 2021385 2021385 0 0.0
(read/write) 146552 146552 0 0.0
.bss 71744 71744 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167401 167401 0 0.0
.text 1696002 1696002 0 0.0
chip-tool debug (read only) 9282453 9298549 16096 0.2
(read/write) 578864 579792 928 0.2
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 548608 549536 928 0.2
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 479061 480309 1248 0.3
.text 7474613 7487301 12688 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9070756 12000 0.1
(read/write) 644993 645937 944 0.1
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583864 584792 928 0.2
.dynamic 560 560 0 0.0
.got 14992 15000 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445124 446228 1104 0.2
.text 7149732 7158452 8720 0.1
lighting-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 152000 152000 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186473 186473 0 0.0
.text 1961522 1961522 0 0.0
lock-app debug (read only) 2228937 2228937 0 0.0
(read/write) 146680 146680 0 0.0
.bss 72224 72224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 197049 197049 0 0.0
.text 1870994 1870994 0 0.0
ota-provider-app debug (read only) 2049873 2049873 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177267 177267 0 0.0
.text 1714210 1714210 0 0.0
ota-requestor-app debug (read only) 2079201 2079201 0 0.0
(read/write) 142568 142568 0 0.0
.bss 72352 72352 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173468 173468 0 0.0
.text 1745874 1745874 0 0.0
shell debug (read only) 2555289 2555289 0 0.0
(read/write) 198552 198552 0 0.0
.bss 114632 114632 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76776 76776 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 220050 220050 0 0.0
.text 2172530 2172530 0 0.0
thermostat-no-ble arm64 (read only) 2343780 2343780 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86465 86465 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147108 147108 0 0.0
.text 1966848 1966848 0 0.0
tv-app debug (read only) 2841185 2841185 0 0.0
(read/write) 277472 277472 0 0.0
.bss 189592 189592 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219345 219345 0 0.0
.text 2438562 2438562 0 0.0
tv-casting-app debug (read only) 5403545 5403545 0 0.0
(read/write) 223776 223776 0 0.0
.bss 77240 77240 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337921 337921 0 0.0
.text 4705314 4705314 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2418784 0 0.0
.bss 201588 201588 0 0.0
.data 5872 5872 0 0.0
.text 1381428 1381428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180243 0 0.0
bss 138356 138356 0 0.0
rodata 152956 152956 0 0.0
text 810160 810160 0 0.0
p6 all-clusters-app default (read/write) 2532168 2532168 0 0.0
.bss 135096 135096 0 0.0
.data 2808 2808 0 0.0
.text 1490432 1490432 0 0.0
light-app default (read/write) 2418776 2418776 0 0.0
.bss 128416 128416 0 0.0
.data 2608 2608 0 0.0
.text 1377040 1377040 0 0.0
lock-app default (read/write) 2429424 2429424 0 0.0
.bss 128232 128232 0 0.0
.data 2568 2568 0 0.0
.text 1387688 1387688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782116 782116 0 0.0
bss 70592 70592 0 0.0
noinit 40416 40416 0 0.0
text 553028 553028 0 0.0
lighting-app tlsr9518adk80d (read/write) 802208 802208 0 0.0
bss 70848 70848 0 0.0
noinit 40416 40416 0 0.0
text 569794 569794 0 0.0

@carol-apple carol-apple merged commit e7af420 into project-chip:master May 18, 2022
This was referenced May 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

Assignees
No one assigned
Labels
app github review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carol-apple @tcarmelveilleux @bzbarsky-apple @isiu-apple