-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chip_enable_group_messaging_tests option #18338
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Build_Removechip_enable_group_messaging_tests
May 11, 2022
Merged
Remove chip_enable_group_messaging_tests option #18338
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Build_Removechip_enable_group_messaging_tests
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
May 11, 2022 18:07
pullapprove
bot
requested review from
jmartinez-silabs,
woody-apple,
jtung-apple,
kghost,
xylophone21,
kpschoedel,
yunhanw-google,
lazarkov,
LuDuda,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs and
wbschiller
May 11, 2022 18:08
jepenven-silabs
approved these changes
May 11, 2022
PR #18338: Size comparison from ba0692c to 5403239 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip_enable_group_messaging_tests
seems unused now.Change overview