Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18158 Followup on fabricTable: DeviceController Setup after Shutdown #18337

Merged
merged 1 commit into from
May 11, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

  • If DeviceControllerFactory SetupController/Commissioner is called after Controller.Shutdown(), a new fabricTable will be created even when a specific fabric table was passed in to the original DeviceControllerFactory.InitSystemState method.

Change overview

  • Keep track of whether to use a new fabricTable or an existing one in the DeviceControllerSystemState object

Testing

  • Tested using tv-app, tv-casting-app and chip-tool

@github-actions
Copy link

github-actions bot commented May 11, 2022

PR #18337: Size comparison from de2831b to e478a7f

Full report (4 builds for esp32, mbed, nrfconnect)
platform target config section de2831b5 e478a7f change % change
esp32 all-clusters-app c3devkit (read only) 1001170 1001170 0 0.0
(read/write) 1475770 1475770 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208416 208416 0 0.0
.flash.text 1001170 1001170 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056055 1056055 0 0.0
(read/write) 478184 478184 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238180 238180 0 0.0
.flash.text 1050671 1050671 0 0.0
.iram0.text 123107 123107 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420020 2420020 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382620 1382620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179911 1179911 0 0.0
bss 139680 139680 0 0.0
rodata 151640 151640 0 0.0
text 809884 809884 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 2af01dc into master May 11, 2022
@bzbarsky-apple bzbarsky-apple deleted the tv-apps-android4 branch May 11, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants