-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Get TestGroupMessaging to work under darwin when the fire… #18311
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
vivien-apple:Tests_GroupMessagingDarwinLocal
May 13, 2022
Merged
[chip-tool] Get TestGroupMessaging to work under darwin when the fire… #18311
jepenven-silabs
merged 1 commit into
project-chip:master
from
vivien-apple:Tests_GroupMessagingDarwinLocal
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
May 11, 2022 10:36
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 11, 2022 10:36
PR #18311: Size comparison from 603efe6 to ae11992 Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 12, 2022
jepenven-silabs
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…wall is active
Problem
On darwin, when the firewall is active,
TestGroupMessaging
triggers a popup sincechip-all-clusters-app
is trying to listen to a multicast address. That is unpractical, especially if you can not / do not want to disable the firewall.Change overview
Testing
./scripts/tests/run_test_suite.py --chip-tool out/debug/standalone/chip-tool --target TestGroupMessaging --log-level debug run --iterations 1 --all-clusters-app out/debug/standalone/chip-all-clusters-app --lock-app out/debug/standalone/chip-lock-app --tv-app out/debug/standalone/chip-tv-app