-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Darwin framework APIs for generating root/ICA certificates. #18237
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:add-Darwin-cert-APIs
May 12, 2022
Merged
Add Darwin framework APIs for generating root/ICA certificates. #18237
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:add-Darwin-cert-APIs
May 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
May 10, 2022 04:53
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 10, 2022 04:53
PR #18237: Size comparison from c766af7 to 342e2dc Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
add-Darwin-cert-APIs
branch
from
May 11, 2022 04:31
342e2dc
to
8f4cd1f
Compare
bzbarsky-apple
force-pushed
the
add-Darwin-cert-APIs
branch
from
May 11, 2022 04:52
8f4cd1f
to
0b97eb6
Compare
PR #18237: Size comparison from f60be7f to 0b97eb6 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 11, 2022
andy31415
approved these changes
May 11, 2022
bzbarsky-apple
force-pushed
the
add-Darwin-cert-APIs
branch
from
May 12, 2022 03:00
0b97eb6
to
ea8527a
Compare
bzbarsky-apple
force-pushed
the
add-Darwin-cert-APIs
branch
from
May 12, 2022 03:09
ea8527a
to
c1a49e2
Compare
PR #18237: Size comparison from f59dbe1 to c1a49e2 Full report (27 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
add-Darwin-cert-APIs
branch
from
May 12, 2022 04:03
c1a49e2
to
96d7eac
Compare
PR #18237: Size comparison from f59dbe1 to 96d7eac Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We'll want to have APIs that take certificates as arguments, and while it's possible to do the right things "by hand" (DER encoding, etc), we might as well expose some convenience methods that we can use both inside the Darwin framework and from its consumers.
Change overview
Add public API for generating root and ICA certs.
Testing
Some basic unit tests added. A PR on top of this one will exercise the root certificate bits a lot more. Still need to figure out how to really test the ICA bits.