-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-cert] Added AuthorizedPAAList Support to the Generate CD Command. #18228
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
emargolis:emargolis/feature/chip-cert-tool-support-authorized-paa
May 11, 2022
Merged
[chip-cert] Added AuthorizedPAAList Support to the Generate CD Command. #18228
bzbarsky-apple
merged 3 commits into
project-chip:master
from
emargolis:emargolis/feature/chip-cert-tool-support-authorized-paa
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
May 9, 2022 21:19
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 9, 2022 21:19
PR #18228: Size comparison from e41bcd2 to 4239550 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
May 10, 2022
emargolis
force-pushed
the
emargolis/feature/chip-cert-tool-support-authorized-paa
branch
from
May 10, 2022 18:23
4239550
to
d4d16e7
Compare
PR #18228: Size comparison from 395375d to d4d16e7 Full report (27 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
reviewed
May 10, 2022
msandstedt
reviewed
May 10, 2022
msandstedt
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor critiques inline. Else looks good.
Co-authored-by: Michael Sandstedt <[email protected]>
Co-authored-by: Michael Sandstedt <[email protected]>
PR #18228: Size comparison from 395375d to 393bdd8 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (29 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to add AuthorizedPAAList support to the CD Generate command.
Ticket: #18061
Change overview
Added
Testing
existing tests