Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: use proper certs for Alice and Bob #18207

Merged
merged 1 commit into from
May 11, 2022
Merged

Tests: use proper certs for Alice and Bob #18207

merged 1 commit into from
May 11, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented May 9, 2022

Problem

Certs for Alice and Bob in out unit-tests are wrong, they are belonged to different fabrics.

Change overview

Use new test-certs for Alice and Bob

Testing

Passed unit-tests

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR #18207: Size comparison from 44dd01b to c3b0247

Increases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, telink)
platform target config section 44dd01b c3b0247 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 690951 16 0.0
.text 587468 587484 16 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678531 24 0.0
.text 583256 583280 24 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627283 24 0.0
.text 532120 532144 24 0.0
pump-app LP_CC2652R7 (read only) 663035 663059 24 0.0
.text 581580 581604 24 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655967 24 0.0
.text 571548 571572 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627610 24 0.0
.app_xip_area 530176 530200 24 0.0
lock cyw930739m2evb_01 (read/write) 626474 626498 24 0.0
.app_xip_area 530520 530544 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575258 24 0.0
.app_xip_area 469564 469588 24 0.0
efr32 lighting-app BRD4161A (read only) 910096 910176 80 0.0
.text 910088 910168 80 0.0
BRD4161A+rpc (read only) 944440 944520 80 0.0
.text 944432 944512 80 0.0
BRD4161A+rs911x (read only) 787676 787772 96 0.0
.text 787668 787764 96 0.0
lock-app BRD4161A+wf200 (read only) 946768 946784 16 0.0
.text 946760 946776 16 0.0
window-app BRD4161A (read only) 890408 890488 80 0.0
.text 890400 890480 80 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001132 42 0.0
.flash.text 1001090 1001132 42 0.0
m5stack (read only) 1056031 1056055 24 0.0
.flash.text 1050647 1050671 24 0.0
k32w light k32w061+release (read/write) 685136 685152 16 0.0
.text 600164 600180 16 0.0
lock k32w061+release (read/write) 730468 730500 32 0.0
.text 645104 645136 32 0.0
linux all-clusters-app debug (read only) 2740441 2740473 32 0.0
.text 2328882 2328914 32 0.0
bridge-app debug+rpc (read only) 1894545 1894561 16 0.0
.text 1610098 1610114 16 0.0
chip-tool debug (read only) 9093941 9093957 16 0.0
.text 7301429 7301445 16 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8914548 8914612 64 0.0
.text 7019108 7019172 64 0.0
lighting-app debug+rpc (read only) 2328625 2328641 16 0.0
.text 1976194 1976210 16 0.0
lock-app debug (read only) 2235921 2235937 16 0.0
.text 1880098 1880114 16 0.0
ota-provider-app debug (read only) 2064249 2064265 16 0.0
.text 1729890 1729906 16 0.0
ota-requestor-app debug (read only) 2095425 2095441 16 0.0
.text 1763250 1763266 16 0.0
shell debug (read only) 2565417 2565449 32 0.0
.text 2185506 2185538 32 0.0
thermostat-no-ble arm64 (read only) 2368620 2368684 64 0.0
.text 1992032 1992096 64 0.0
tv-app debug (read only) 2852865 2852881 16 0.0
.text 2451778 2451794 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179803 16 0.0
text 809856 809876 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806064 40 0.0
text 572426 572468 42 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section 44dd01b c3b0247 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161416 161400 -16 -0.0
lock-ftd LP_CC2652R7 (read/write) 164948 164924 -24 -0.0
pump-app LP_CC2652R7 (read/write) 181708 181684 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188600 188576 -24 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 44dd01b c3b0247 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 690951 16 0.0
(read/write) 161416 161400 -16 -0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587484 16 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678531 24 0.0
(read/write) 164948 164924 -24 -0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583280 24 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627283 24 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532144 24 0.0
pump-app LP_CC2652R7 (read only) 663035 663059 24 0.0
(read/write) 181708 181684 -24 -0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581604 24 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655967 24 0.0
(read/write) 188600 188576 -24 -0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571572 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627610 24 0.0
.app_xip_area 530176 530200 24 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626498 24 0.0
.app_xip_area 530520 530544 24 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575258 24 0.0
.app_xip_area 469564 469588 24 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910176 80 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910168 80 0.0
BRD4161A+rpc (read only) 944440 944520 80 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944512 80 0.0
BRD4161A+rs911x (read only) 787676 787772 96 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787668 787764 96 0.0
lock-app BRD4161A+wf200 (read only) 946768 946784 16 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946760 946776 16 0.0
window-app BRD4161A (read only) 890408 890488 80 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890400 890480 80 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001132 42 0.0
(read/write) 1475658 1475658 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208304 208304 0 0.0
.flash.text 1001090 1001132 42 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056055 24 0.0
(read/write) 478088 478088 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238084 238084 0 0.0
.flash.text 1050647 1050671 24 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685136 685152 16 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600180 16 0.0
lock k32w061+release (read/write) 730468 730500 32 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645136 32 0.0
linux all-clusters-app debug (read only) 2740441 2740473 32 0.0
(read/write) 174488 174488 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82392 82392 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236357 236357 0 0.0
.text 2328882 2328914 32 0.0
bridge-app debug+rpc (read only) 1894545 1894561 16 0.0
(read/write) 120984 120984 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40648 40648 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161593 161593 0 0.0
.text 1610098 1610114 16 0.0
chip-tool debug (read only) 9093941 9093957 16 0.0
(read/write) 576944 576944 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546728 546728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 468693 468693 0 0.0
.text 7301429 7301445 16 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8914548 8914612 64 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582024 582024 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 436164 436164 0 0.0
.text 7019108 7019172 64 0.0
lighting-app debug+rpc (read only) 2328625 2328641 16 0.0
(read/write) 151936 151936 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70568 70568 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185721 185721 0 0.0
.text 1976194 1976210 16 0.0
lock-app debug (read only) 2235921 2235937 16 0.0
(read/write) 146520 146520 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67080 67080 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195465 195465 0 0.0
.text 1880098 1880114 16 0.0
ota-provider-app debug (read only) 2064249 2064265 16 0.0
(read/write) 139632 139632 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176467 176467 0 0.0
.text 1729890 1729906 16 0.0
ota-requestor-app debug (read only) 2095425 2095441 16 0.0
(read/write) 142440 142440 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62504 62504 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172796 172796 0 0.0
.text 1763250 1763266 16 0.0
shell debug (read only) 2565417 2565449 32 0.0
(read/write) 198160 198160 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76656 76656 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217810 217810 0 0.0
.text 2185506 2185538 32 0.0
thermostat-no-ble arm64 (read only) 2368620 2368684 64 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992096 64 0.0
tv-app debug (read only) 2852865 2852881 16 0.0
(read/write) 277248 277248 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218411 218411 0 0.0
.text 2451778 2451794 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179803 16 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809876 20 0.0
p6 all-clusters-app default (read/write) 2531536 2531536 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489800 0 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806064 40 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572468 42 0.0

@github-actions
Copy link

github-actions bot commented May 10, 2022 •
edited
Loading

PR #18207: Size comparison from 2580fb3 to e3fdfb8

Increases (21 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, telink)
platform target config section 2580fb3 e3fdfb8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691023 691039 16 0.0
.text 587468 587484 16 0.0
lock-ftd LP_CC2652R7 (read only) 678547 678571 24 0.0
.text 583256 583280 24 0.0
lock-mtd LP_CC2652R7 (read only) 627299 627323 24 0.0
.text 532120 532144 24 0.0
pump-app LP_CC2652R7 (read only) 663043 663067 24 0.0
.text 581580 581604 24 0.0
pump-controller-app LP_CC2652R7 (read only) 655951 655975 24 0.0
.text 571548 571572 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627602 627626 24 0.0
.app_xip_area 530192 530216 24 0.0
lock cyw930739m2evb_01 (read/write) 626514 626538 24 0.0
.app_xip_area 530560 530584 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575242 575266 24 0.0
.app_xip_area 469572 469596 24 0.0
efr32 lighting-app BRD4161A (read only) 910112 910192 80 0.0
.text 910104 910184 80 0.0
BRD4161A+rpc (read only) 944456 944536 80 0.0
.text 944448 944528 80 0.0
BRD4161A+rs911x (read only) 787692 787788 96 0.0
.text 787684 787780 96 0.0
lock-app BRD4161A+wf200 (read only) 946808 946824 16 0.0
.text 946800 946816 16 0.0
window-app BRD4161A (read only) 890416 890496 80 0.0
.text 890408 890488 80 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001132 42 0.0
.flash.text 1001090 1001132 42 0.0
m5stack (read only) 1056031 1056055 24 0.0
.flash.text 1050647 1050671 24 0.0
k32w light k32w061+release (read/write) 685152 685168 16 0.0
.text 600180 600196 16 0.0
lock k32w061+release (read/write) 730508 730540 32 0.0
.text 645144 645176 32 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8924668 8924732 64 0.0
.text 7026644 7026708 64 0.0
thermostat-no-ble arm64 (read only) 2368692 2368756 64 0.0
.text 1992032 1992096 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179879 1179895 16 0.0
text 809856 809876 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 806040 806080 40 0.0
text 572426 572468 42 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section 2580fb3 e3fdfb8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161328 161312 -16 -0.0
lock-ftd LP_CC2652R7 (read/write) 164908 164884 -24 -0.0
pump-app LP_CC2652R7 (read/write) 181700 181676 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188592 188568 -24 -0.0
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2580fb3 e3fdfb8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691023 691039 16 0.0
(read/write) 161328 161312 -16 -0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103071 103071 0 0.0
.text 587468 587484 16 0.0
lock-ftd LP_CC2652R7 (read only) 678547 678571 24 0.0
(read/write) 164908 164884 -24 -0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94811 94811 0 0.0
.text 583256 583280 24 0.0
lock-mtd LP_CC2652R7 (read only) 627299 627323 24 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94691 0 0.0
.text 532120 532144 24 0.0
pump-app LP_CC2652R7 (read only) 663043 663067 24 0.0
(read/write) 181700 181676 -24 -0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80979 80979 0 0.0
.text 581580 581604 24 0.0
pump-controller-app LP_CC2652R7 (read only) 655951 655975 24 0.0
(read/write) 188592 188568 -24 -0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83919 83919 0 0.0
.text 571548 571572 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627602 627626 24 0.0
.app_xip_area 530192 530216 24 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626514 626538 24 0.0
.app_xip_area 530560 530584 24 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575242 575266 24 0.0
.app_xip_area 469572 469596 24 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910112 910192 80 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910104 910184 80 0.0
BRD4161A+rpc (read only) 944456 944536 80 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944448 944528 80 0.0
BRD4161A+rs911x (read only) 787692 787788 96 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787684 787780 96 0.0
lock-app BRD4161A+wf200 (read only) 946808 946824 16 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946800 946816 16 0.0
window-app BRD4161A (read only) 890416 890496 80 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890408 890488 80 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001132 42 0.0
(read/write) 1475746 1475746 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208392 208392 0 0.0
.flash.text 1001090 1001132 42 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056055 24 0.0
(read/write) 478176 478176 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238172 238172 0 0.0
.flash.text 1050647 1050671 24 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685152 685168 16 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600180 600196 16 0.0
lock k32w061+release (read/write) 730508 730540 32 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645144 645176 32 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8924668 8924732 64 0.0
(read/write) 643089 643089 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582000 582000 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 438764 438764 0 0.0
.text 7026644 7026708 64 0.0
thermostat-no-ble arm64 (read only) 2368692 2368756 64 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146868 146868 0 0.0
.text 1992032 1992096 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420124 2420124 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382724 1382724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179879 1179895 16 0.0
bss 139680 139680 0 0.0
rodata 151624 151624 0 0.0
text 809856 809876 20 0.0
p6 all-clusters-app default (read/write) 2531632 2531632 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489896 1489896 0 0.0
light-app default (read/write) 2421608 2421608 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379872 1379872 0 0.0
lock-app default (read/write) 2431136 2431136 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389400 1389400 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806040 806080 40 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572468 42 0.0

bzbarsky-apple
bzbarsky-apple approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably no worse than what we had before, but the invariant violation is just waiting to blow up in our faces.... In particular, any time someone uses a (public key, fabric id) to identify a fabric, not a fabric index, things will break in weird ways....

@kghost
Copy link
Contributor Author

kghost commented May 11, 2022

@bzbarsky-apple The root problem is that the FabricInfo structure in our code, doesn't represent the Fabirc in spec. It is something like a tuple of <Fabric, Local Node in that fabric>, rather than juse fabric.

@kghost kghost merged commit 2ae1d5a into project-chip:master May 11, 2022
@kghost kghost deleted the test-certs branch May 11, 2022 17:07
@bzbarsky-apple
Copy link
Contributor

Yes, but the invariant in the spec is that a given stack instance has a unique node id in a given fabric, which is why the data structure looks like it does. The tests are just violating that invariant....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @bzbarsky-apple @msandstedt