Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature flags logic in media clusters & TV app #18191

Merged
merged 5 commits into from
May 16, 2022
Merged

Update feature flags logic in media clusters & TV app #18191

merged 5 commits into from
May 16, 2022

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented May 8, 2022

Problem

  • default values for feature map media clusters is always 1. certain clusters have to have higher values, to reflect the available features.

Change overview

see above

Issue(s) fixed:

17749
17737

Testing

Run ./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "

@restyled-io restyled-io bot mentioned this pull request May 8, 2022
Closed
@lazarkov lazarkov force-pushed the feature/update-feature-flags-tv-matter-media branch from 25d274d to ce66350 Compare May 8, 2022 17:46
@github-actions
Copy link

github-actions bot commented May 8, 2022 •
edited
Loading

PR #18191: Size comparison from 11587f5 to 8cbd38c

Increases (5 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 11587f5 8cbd38c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 691031 96 0.0
.text 587468 587564 96 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001192 102 0.0
.flash.text 1001090 1001192 102 0.0
m5stack (read only) 1056031 1056107 76 0.0
.flash.text 1050647 1050723 76 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179867 80 0.0
text 809856 809944 88 0.0
p6 all-clusters-app default (read/write) 2531536 2531616 80 0.0
.text 1489800 1489880 80 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 11587f5 8cbd38c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161416 161320 -96 -0.1
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 11587f5 8cbd38c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 691031 96 0.0
(read/write) 161416 161320 -96 -0.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587564 96 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678507 0 0.0
(read/write) 164948 164948 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627259 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663035 663035 0 0.0
(read/write) 181708 181708 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581580 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188600 188600 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627586 0 0.0
.app_xip_area 530176 530176 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626474 0 0.0
.app_xip_area 530520 530520 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575234 0 0.0
.app_xip_area 469564 469564 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 946768 946768 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946760 946760 0 0.0
window-app BRD4161A (read only) 890408 890408 0 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890400 890400 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001192 102 0.0
(read/write) 1475658 1475658 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208304 208304 0 0.0
.flash.text 1001090 1001192 102 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056107 76 0.0
(read/write) 478088 478088 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238084 238084 0 0.0
.flash.text 1050647 1050723 76 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685136 685136 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730468 730468 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645104 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8914548 8914548 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582024 582024 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 436164 436164 0 0.0
.text 7019108 7019108 0 0.0
thermostat-no-ble arm64 (read only) 2368620 2368620 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992032 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179867 80 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809944 88 0.0
p6 all-clusters-app default (read/write) 2531536 2531616 80 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489880 80 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806024 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572426 0 0.0

@lazarkov lazarkov force-pushed the feature/update-feature-flags-tv-matter-media branch from 5143936 to 004ef68 Compare May 9, 2022 07:55
@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR #18191: Size comparison from 04c85c7 to 004ef68

Increases (3 builds for cc13x2_26x2, nrfconnect, p6)
platform target config section 04c85c7 004ef68 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 691031 96 0.0
.text 587468 587564 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179867 80 0.0
text 809856 809944 88 0.0
p6 all-clusters-app default (read/write) 2531536 2531616 80 0.0
.text 1489800 1489880 80 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 04c85c7 004ef68 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161416 161320 -96 -0.1
Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 04c85c7 004ef68 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 691031 96 0.0
(read/write) 161416 161320 -96 -0.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587564 96 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678507 0 0.0
(read/write) 164948 164948 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627259 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663035 663035 0 0.0
(read/write) 181708 181708 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581580 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188600 188600 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627586 0 0.0
.app_xip_area 530176 530176 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626474 0 0.0
.app_xip_area 530520 530520 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575234 0 0.0
.app_xip_area 469564 469564 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 685136 685136 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730468 730468 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645104 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8914548 8914548 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582024 582024 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 436164 436164 0 0.0
.text 7019108 7019108 0 0.0
thermostat-no-ble arm64 (read only) 2368620 2368620 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992032 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179867 80 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809944 88 0.0
p6 all-clusters-app default (read/write) 2531536 2531616 80 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489880 80 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806024 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572426 0 0.0

@lazarkov lazarkov force-pushed the feature/update-feature-flags-tv-matter-media branch from 004ef68 to 37df305 Compare May 9, 2022 08:46
@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR #18191: Size comparison from 04c85c7 to 37df305

Increases (5 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 04c85c7 37df305 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 691031 96 0.0
.text 587468 587564 96 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001192 102 0.0
.flash.text 1001090 1001192 102 0.0
m5stack (read only) 1056031 1056107 76 0.0
.flash.text 1050647 1050723 76 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179867 80 0.0
text 809856 809944 88 0.0
p6 all-clusters-app default (read/write) 2531536 2531616 80 0.0
.text 1489800 1489880 80 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 04c85c7 37df305 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161416 161320 -96 -0.1
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 04c85c7 37df305 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 691031 96 0.0
(read/write) 161416 161320 -96 -0.1
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587564 96 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678507 0 0.0
(read/write) 164948 164948 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627259 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663035 663035 0 0.0
(read/write) 181708 181708 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581580 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188600 188600 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627586 0 0.0
.app_xip_area 530176 530176 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626474 0 0.0
.app_xip_area 530520 530520 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575234 0 0.0
.app_xip_area 469564 469564 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 946768 946768 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946760 946760 0 0.0
window-app BRD4161A (read only) 890408 890408 0 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890400 890400 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001192 102 0.0
(read/write) 1475658 1475658 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208304 208304 0 0.0
.flash.text 1001090 1001192 102 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056107 76 0.0
(read/write) 478088 478088 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238084 238084 0 0.0
.flash.text 1050647 1050723 76 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685136 685136 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730468 730468 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645104 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8914548 8914548 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582024 582024 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 436164 436164 0 0.0
.text 7019108 7019108 0 0.0
thermostat-no-ble arm64 (read only) 2368620 2368620 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992032 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179867 80 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809944 88 0.0
p6 all-clusters-app default (read/write) 2531536 2531616 80 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489880 80 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806024 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572426 0 0.0

@lazarkov lazarkov force-pushed the feature/update-feature-flags-tv-matter-media branch from 37df305 to 85cee77 Compare May 15, 2022 09:33
@github-actions
Copy link

github-actions bot commented May 15, 2022 •
edited
Loading

PR #18191: Size comparison from 25e241e to 85cee77

Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 25e241e 85cee77 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692443 96 0.0
.text 588600 588696 96 0.0
shell LP_CC2652R7 (read only) 686734 686830 96 0.0
.text 585436 585532 96 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000276 102 0.0
.flash.text 1000174 1000276 102 0.0
m5stack (read only) 1054103 1054179 76 0.0
.flash.text 1048719 1048795 76 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181379 96 0.0
text 810452 810544 92 0.0
p6 all-clusters-app default (read/write) 2533016 2533112 96 0.0
.text 1491280 1491376 96 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 25e241e 85cee77 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159932 159836 -96 -0.1
shell LP_CC2652R7 (read/write) 161368 161272 -96 -0.1
Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 25e241e 85cee77 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692443 96 0.0
(read/write) 159932 159836 -96 -0.1
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588696 96 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686830 96 0.0
(read/write) 161368 161272 -96 -0.1
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585532 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000276 102 0.0
(read/write) 1477650 1477650 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209256 209256 0 0.0
.flash.text 1000174 1000276 102 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054103 1054179 76 0.0
(read/write) 479552 479552 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239500 239500 0 0.0
.flash.text 1048719 1048795 76 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181379 96 0.0
bss 139568 139568 0 0.0
rodata 152428 152428 0 0.0
text 810452 810544 92 0.0
p6 all-clusters-app default (read/write) 2533016 2533112 96 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491376 96 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806568 806568 0 0.0
bss 72064 72064 0 0.0
noinit 40416 40416 0 0.0
text 572918 572918 0 0.0

@restyled-io restyled-io bot mentioned this pull request May 16, 2022
Closed
@lazarkov lazarkov force-pushed the feature/update-feature-flags-tv-matter-media branch from 5526282 to 54ff326 Compare May 16, 2022 08:46
@github-actions
Copy link

github-actions bot commented May 16, 2022 •
edited
Loading

PR #18191: Size comparison from 25e241e to 54ff326

Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 25e241e 54ff326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692443 96 0.0
.text 588600 588696 96 0.0
shell LP_CC2652R7 (read only) 686734 686814 80 0.0
.text 585436 585516 80 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000248 74 0.0
.flash.text 1000174 1000248 74 0.0
m5stack (read only) 1054103 1054175 72 0.0
.flash.text 1048719 1048791 72 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181363 80 0.0
text 810452 810540 88 0.0
p6 all-clusters-app default (read/write) 2533016 2533112 96 0.0
.text 1491280 1491376 96 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 25e241e 54ff326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159932 159836 -96 -0.1
shell LP_CC2652R7 (read/write) 161368 161288 -80 -0.0
Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 25e241e 54ff326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692347 692443 96 0.0
(read/write) 159932 159836 -96 -0.1
.bss 75260 75260 0 0.0
.data 3412 3412 0 0.0
.rodata 103267 103267 0 0.0
.text 588600 588696 96 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163636 163636 0 0.0
.bss 73404 73404 0 0.0
.data 3236 3236 0 0.0
.rodata 94979 94979 0 0.0
.text 584268 584268 0 0.0
lock-mtd LP_CC2652R7 (read only) 628539 628539 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69140 69140 0 0.0
.data 3236 3236 0 0.0
.rodata 94859 94859 0 0.0
.text 533188 533188 0 0.0
pump-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 181376 181376 0 0.0
.bss 73668 73668 0 0.0
.data 3268 3268 0 0.0
.rodata 80519 80519 0 0.0
.text 582280 582280 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656471 656471 0 0.0
(read/write) 187984 187984 0 0.0
.bss 73724 73724 0 0.0
.data 3232 3232 0 0.0
.rodata 83607 83607 0 0.0
.text 572384 572384 0 0.0
shell LP_CC2652R7 (read only) 686734 686814 80 0.0
(read/write) 161368 161288 -80 -0.0
.bss 77884 77884 0 0.0
.data 3416 3416 0 0.0
.rodata 100814 100814 0 0.0
.text 585436 585516 80 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 530996 530996 0 0.0
.bss 79988 79988 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628286 628286 0 0.0
.app_xip_area 532396 532396 0 0.0
.bss 78564 78564 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576074 576074 0 0.0
.app_xip_area 470468 470468 0 0.0
.bss 87984 87984 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918680 918680 0 0.0
(read/write) 134440 134440 0 0.0
.bss 132376 132376 0 0.0
.data 2060 2060 0 0.0
.text 918672 918672 0 0.0
BRD4161A+rpc (read only) 952868 952868 0 0.0
(read/write) 151120 151120 0 0.0
.bss 148856 148856 0 0.0
.data 2264 2264 0 0.0
.text 952860 952860 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129656 129656 0 0.0
.bss 127588 127588 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 947672 947672 0 0.0
(read/write) 124140 124140 0 0.0
.bss 122116 122116 0 0.0
.data 2024 2024 0 0.0
.text 947664 947664 0 0.0
window-app BRD4161A (read only) 898968 898968 0 0.0
(read/write) 134384 134384 0 0.0
.bss 132336 132336 0 0.0
.data 2048 2048 0 0.0
.text 898960 898960 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000174 1000248 74 0.0
(read/write) 1477650 1477650 0 0.0
.dram0.bss 68352 68352 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209256 209256 0 0.0
.flash.text 1000174 1000248 74 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1054103 1054175 72 0.0
(read/write) 479552 479552 0 0.0
.dram0.bss 73872 73872 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239500 239500 0 0.0
.flash.text 1048719 1048791 72 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 686264 686264 0 0.0
.bss 81176 81176 0 0.0
.data 2016 2016 0 0.0
.text 601368 601368 0 0.0
lock k32w061+release (read/write) 732632 732632 0 0.0
.bss 81608 81608 0 0.0
.data 1976 1976 0 0.0
.text 647344 647344 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9060004 9060004 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443348 443348 0 0.0
.text 7157124 7157124 0 0.0
thermostat-no-ble arm64 (read only) 2370180 2370180 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993312 1993312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2421684 2421684 0 0.0
.bss 205436 205436 0 0.0
.data 5872 5872 0 0.0
.text 1384284 1384284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181283 1181363 80 0.0
bss 139568 139568 0 0.0
rodata 152428 152428 0 0.0
text 810452 810540 88 0.0
p6 all-clusters-app default (read/write) 2533016 2533112 96 0.0
.bss 138944 138944 0 0.0
.data 2808 2808 0 0.0
.text 1491280 1491376 96 0.0
light-app default (read/write) 2421968 2421968 0 0.0
.bss 132272 132272 0 0.0
.data 2608 2608 0 0.0
.text 1380232 1380232 0 0.0
lock-app default (read/write) 2432616 2432616 0 0.0
.bss 132088 132088 0 0.0
.data 2568 2568 0 0.0
.text 1390880 1390880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806568 806568 0 0.0
bss 72064 72064 0 0.0
noinit 40416 40416 0 0.0
text 572918 572918 0 0.0

@andy31415 andy31415 merged commit 06b401c into project-chip:master May 16, 2022
@lazarkov lazarkov deleted the feature/update-feature-flags-tv-matter-media branch May 16, 2022 14:28
bzbarsky-apple
bzbarsky-apple reviewed May 17, 2022
View reviewed changes
src/app/clusters/content-launch-server/content-launch-server.cpp
VerifyOrExit(isDelegateNull(delegate, endpoint) != true, err = CHIP_ERROR_INCORRECT_STATE);

VerifyOrExit(isDelegateNull(delegate, endpoint) != true && HasFeature(endpoint, ContentLauncherFeature::kContentSearch),
err = CHIP_ERROR_INCORRECT_STATE);
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazarkov This still has extra curly braces that don't seem to have a reason to exist....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I haven't understood your comment at first, I'll remove it.

@lazarkov lazarkov mentioned this pull request May 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@andy31415 andy31415 Awaiting requested review from andy31415

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@saurabhst saurabhst Awaiting requested review from saurabhst

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lazarkov @andy31415 @hawk248 @chrisdecenzo @bzbarsky-apple