-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin framework: add new header generation for cluster/attribute/command/event IDs to expose in darwin public framework #18172
Conversation
PR #18172: Size comparison from 54a39d7 to e485ffe Full report (15 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
bb5bea2
to
be578b4
Compare
PR #18172: Size comparison from d6a7226 to be578b4 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ff885bf
to
17a8504
Compare
PR #18172: Size comparison from bea994b to 17a8504 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
1d9a9ab
to
f45535b
Compare
PR #18172: Size comparison from 3c3a422 to f45535b Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
I have been fiddling with BUILD. gn for both chip-tool-darwin and CHIP framework and I can't get darwin to compile with ninja if the file is generated into the zap-generated directory. I couldn't find where the include path can be changed to include zap-generated. In any case, I've changed it so the new file will generate just inside CHIP, and now things work! In the xcode workspace I still have it in the CHIPGenerated folder. |
…mand/event IDs to expose in darwin public framework Issue project-chip#18164 - Need obj-c friendly constants header for cluster/attribute/command/event IDs
f45535b
to
1a4e87e
Compare
PR #18172: Size comparison from 2ae1d5a to 1a4e87e Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast-tracking platform-specific change. |
Issue #18164 - Need obj-c friendly constants header for cluster/attribute/command/event IDs
Problem
The existing constants are defined in C++. For darwin platform there should be an obj-c friendly header file.
Change overview
Added a zap template to generate the IDs as enums.