Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some methods that are unused from af-events.cpp #18099

Merged

Conversation

andy31415
Copy link
Contributor

Problem

Unused code. Af-events usage is unclear since af-gen-events.h currently is not generated yet it seems a required include sometimes generated as empty by our build infra.

Change overview

Remove some unused code in the repo, trying to simplify the amount of code we have to review and maintain.

Testing

Grepping said that this code is unused. CI will validate that things still build.

@github-actions
Copy link

github-actions bot commented May 5, 2022

PR #18099: Size comparison from d228b75 to 7ba9bbe

Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section d228b75 7ba9bbe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690331 690483 152 0.0
.rodata 102899 102923 24 0.0
.text 586948 587076 128 0.0
lock-ftd LP_CC2652R7 (read only) 677911 678063 152 0.0
.rodata 94695 94719 24 0.0
.text 582736 582864 128 0.0
lock-mtd LP_CC2652R7 (read only) 626663 626815 152 0.0
.rodata 94583 94607 24 0.0
.text 531592 531720 128 0.0
pump-app LP_CC2652R7 (read only) 662427 662579 152 0.0
.rodata 80891 80915 24 0.0
.text 581052 581180 128 0.0
pump-controller-app LP_CC2652R7 (read only) 655351 655503 152 0.0
.rodata 83847 83871 24 0.0
.text 571020 571148 128 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627026 627178 152 0.0
.app_xip_area 529616 529768 152 0.0
lock cyw930739m2evb_01 (read/write) 625930 626082 152 0.0
.app_xip_area 529984 530136 152 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574834 112 0.0
.app_xip_area 469060 469172 112 0.0
efr32 lighting-app BRD4161A (read only) 909744 909896 152 0.0
.text 909736 909888 152 0.0
BRD4161A+rpc (read only) 944088 944224 136 0.0
.text 944080 944216 136 0.0
BRD4161A+rs911x (read only) 747932 748084 152 0.0
.text 747924 748076 152 0.0
lock-app BRD4161A+wf200 (read only) 917636 917788 152 0.0
.text 917628 917780 152 0.0
window-app BRD4161A (read only) 847000 847136 136 0.0
.text 846992 847128 136 0.0
esp32 all-clusters-app c3devkit (read only) 1000528 1000620 92 0.0
(read/write) 1475258 1475282 24 0.0
.flash.rodata 207904 207928 24 0.0
.flash.text 1000528 1000620 92 0.0
m5stack (read only) 1055547 1055655 108 0.0
(read/write) 477680 477704 24 0.0
.flash.rodata 237684 237708 24 0.0
.flash.text 1050163 1050271 108 0.0
k32w light k32w061+release (read/write) 684560 684696 136 0.0
.text 599588 599724 136 0.0
lock k32w061+release (read/write) 729900 730052 152 0.0
.text 644536 644688 152 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2419124 2419276 152 0.0
.text 1381724 1381876 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179187 1179339 152 0.0
rodata 151460 151484 24 0.0
text 809328 809456 128 0.0
p6 all-clusters-app default (read/write) 2530480 2530632 152 0.0
.text 1488744 1488896 152 0.0
light-app default (read/write) 2420560 2420696 136 0.0
.text 1378824 1378960 136 0.0
lock-app default (read/write) 2430064 2430200 136 0.0
.text 1388328 1388464 136 0.0
telink lighting-app tlsr9518adk80d (read/write) 805408 805560 152 0.0
text 571882 572016 134 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section d228b75 7ba9bbe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162012 161860 -152 -0.1
lock-ftd LP_CC2652R7 (read/write) 165536 165384 -152 -0.1
pump-app LP_CC2652R7 (read/write) 182316 182164 -152 -0.1
pump-controller-app LP_CC2652R7 (read/write) 189192 189040 -152 -0.1
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section d228b75 7ba9bbe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690331 690483 152 0.0
(read/write) 162012 161860 -152 -0.1
.bss 75324 75324 0 0.0
.data 3412 3412 0 0.0
.rodata 102899 102923 24 0.0
.text 586948 587076 128 0.0
lock-ftd LP_CC2652R7 (read only) 677911 678063 152 0.0
(read/write) 165536 165384 -152 -0.1
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94695 94719 24 0.0
.text 582736 582864 128 0.0
lock-mtd LP_CC2652R7 (read only) 626663 626815 152 0.0
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94583 94607 24 0.0
.text 531592 531720 128 0.0
pump-app LP_CC2652R7 (read only) 662427 662579 152 0.0
(read/write) 182316 182164 -152 -0.1
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80891 80915 24 0.0
.text 581052 581180 128 0.0
pump-controller-app LP_CC2652R7 (read only) 655351 655503 152 0.0
(read/write) 189192 189040 -152 -0.1
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83847 83871 24 0.0
.text 571020 571148 128 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627026 627178 152 0.0
.app_xip_area 529616 529768 152 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625930 626082 152 0.0
.app_xip_area 529984 530136 152 0.0
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574834 112 0.0
.app_xip_area 469060 469172 112 0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909744 909896 152 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909736 909888 152 0.0
BRD4161A+rpc (read only) 944088 944224 136 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944080 944216 136 0.0
BRD4161A+rs911x (read only) 747932 748084 152 0.0
(read/write) 128700 128700 0 0.0
.bss 126708 126708 0 0.0
.data 1992 1992 0 0.0
.text 747924 748076 152 0.0
lock-app BRD4161A+wf200 (read only) 917636 917788 152 0.0
(read/write) 127480 127480 0 0.0
.bss 125532 125532 0 0.0
.data 1948 1948 0 0.0
.text 917628 917780 152 0.0
window-app BRD4161A (read only) 847000 847136 136 0.0
(read/write) 132608 132608 0 0.0
.bss 130632 130632 0 0.0
.data 1976 1976 0 0.0
.text 846992 847128 136 0.0
esp32 all-clusters-app c3devkit (read only) 1000528 1000620 92 0.0
(read/write) 1475258 1475282 24 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207904 207928 24 0.0
.flash.text 1000528 1000620 92 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055547 1055655 108 0.0
(read/write) 477680 477704 24 0.0
.dram0.bss 73976 73976 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 237684 237708 24 0.0
.flash.text 1050163 1050271 108 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684560 684696 136 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599588 599724 136 0.0
lock k32w061+release (read/write) 729900 730052 152 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 644536 644688 152 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419124 2419276 152 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381724 1381876 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179187 1179339 152 0.0
bss 139676 139676 0 0.0
rodata 151460 151484 24 0.0
text 809328 809456 128 0.0
p6 all-clusters-app default (read/write) 2530480 2530632 152 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1488744 1488896 152 0.0
light-app default (read/write) 2420560 2420696 136 0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1378824 1378960 136 0.0
lock-app default (read/write) 2430064 2430200 136 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1388328 1388464 136 0.0
telink lighting-app tlsr9518adk80d (read/write) 805408 805560 152 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 571882 572016 134 0.0

@andy31415
Copy link
Contributor Author

fast track because this is pure unused code deletion (and I see no plans to actually use this code in the future ... we should migrate away from using events from timers and only use system timers for consistency and simplicity - less generated code)

@andy31415 andy31415 merged commit 2e346b2 into project-chip:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants