-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some methods that are unused from af-events.cpp #18099
Merged
andy31415
merged 7 commits into
project-chip:master
from
andy31415:remove_unused_afevent_parts
May 6, 2022
Merged
Removed some methods that are unused from af-events.cpp #18099
andy31415
merged 7 commits into
project-chip:master
from
andy31415:remove_unused_afevent_parts
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #18099: Size comparison from d228b75 to 7ba9bbe Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 6, 2022
fast track because this is pure unused code deletion (and I see no plans to actually use this code in the future ... we should migrate away from using events from timers and only use system timers for consistency and simplicity - less generated code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unused code. Af-events usage is unclear since
af-gen-events.h
currently is not generated yet it seems a required include sometimes generated as empty by our build infra.Change overview
Remove some unused code in the repo, trying to simplify the amount of code we have to review and maintain.
Testing
Grepping said that this code is unused. CI will validate that things still build.