Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ameba] NotifyUpdateApplied sent after rebooting into new OTA image #18079

Merged
merged 2 commits into from
May 10, 2022
Merged

[Ameba] NotifyUpdateApplied sent after rebooting into new OTA image #18079

merged 2 commits into from
May 10, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented May 5, 2022

Problem

  • Current implementation of Ameba OTA will send notifyupdateapplied to the provider before it reboots into new image

Change overview

  • Added IsFirstImageRun and ConfirmCurrentImage checks
  • Remove notifyupdateapplied in HandleApply
  • Added 2sec countdown before rebooting into new image after successful OTA transfer

Testing

  • Tested with linux ota-provider-app
  • NotifyUpdateApplied received by provider after ameba reboots into new image

@pankore
[OTA] NotifyUpdateApplied to be sent after device first reboot into n…
2631d5e 
…ew image

- Added IsFirstRun and ConfirmCurrentImage checks
- Currently added delay of 15seconds in example_matter to give time for
  ameba to obtain ipv6 address
- TODO: Need to move wlan fast connect into matter using DCT
@restyled-io restyled-io bot mentioned this pull request May 5, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

PR #18079: Size comparison from b963a3f to 8c0dde9

Full report (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b963a3f 8c0dde9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690099 690099 0 0.0
(read/write) 162100 162100 0 0.0
.bss 75180 75180 0 0.0
.data 3412 3412 0 0.0
.rodata 102627 102627 0 0.0
.text 586988 586988 0 0.0
lock-ftd LP_CC2652R7 (read only) 677975 677975 0 0.0
(read/write) 165472 165472 0 0.0
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94695 94695 0 0.0
.text 582800 582800 0 0.0
lock-mtd LP_CC2652R7 (read only) 626719 626719 0 0.0
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94583 94583 0 0.0
.text 531648 531648 0 0.0
pump-app LP_CC2652R7 (read only) 662671 662671 0 0.0
(read/write) 182072 182072 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80887 80887 0 0.0
.text 581300 581300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655595 655595 0 0.0
(read/write) 188948 188948 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83843 83843 0 0.0
.text 571268 571268 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627274 627274 0 0.0
.app_xip_area 529864 529864 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625986 625986 0 0.0
.app_xip_area 530040 530040 0 0.0
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574962 574962 0 0.0
.app_xip_area 469300 469300 0 0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000606 1000606 0 0.0
(read/write) 1474842 1474842 0 0.0
.dram0.bss 68320 68320 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207632 207632 0 0.0
.flash.text 1000606 1000606 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055667 1055667 0 0.0
(read/write) 477256 477256 0 0.0
.dram0.bss 73832 73832 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 237404 237404 0 0.0
.flash.text 1050283 1050283 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684800 684800 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599828 599828 0 0.0
lock k32w061+release (read/write) 729964 729964 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 644600 644600 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8822740 8822740 0 0.0
(read/write) 643025 643025 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581936 581936 0 0.0
.dynamic 560 560 0 0.0
.got 14968 14968 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 432052 432052 0 0.0
.text 6931748 6931748 0 0.0
thermostat-no-ble arm64 (read only) 2366220 2366220 0 0.0
(read/write) 174993 174993 0 0.0
.bss 86401 86401 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79272 79272 0 0.0
.dynamic 560 560 0 0.0
.got 4760 4760 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146476 146476 0 0.0
.text 1990336 1990336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419108 2419108 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381708 1381708 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178787 1178787 0 0.0
bss 139532 139532 0 0.0
rodata 151188 151188 0 0.0
text 809340 809340 0 0.0
p6 all-clusters-app default (read/write) 2530240 2530240 0 0.0
.bss 139184 139184 0 0.0
.data 2808 2808 0 0.0
.text 1488504 1488504 0 0.0
light-app default (read/write) 2420816 2420816 0 0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1379080 1379080 0 0.0
lock-app default (read/write) 2430096 2430096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1388360 1388360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 805704 805704 0 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 572178 572178 0 0.0

@carol-apple carol-apple merged commit e8dbf5d into project-chip:master May 10, 2022
pankore added a commit to pankore/connectedhomeip that referenced this pull request May 10, 2022
@pankore @restyled-commits
[Ameba] NotifyUpdateApplied sent after rebooting into new OTA image (p…
f6bc5f1 
…roject-chip#18079)

* [OTA] NotifyUpdateApplied to be sent after device first reboot into new image
- Added IsFirstRun and ConfirmCurrentImage checks
- Currently added delay of 15seconds in example_matter to give time for
  ameba to obtain ipv6 address
- TODO: Need to move wlan fast connect into matter using DCT

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request May 10, 2022
@pankore @restyled-commits @step0035
[Ameba] NotifyUpdateApplied sent after rebooting into new OTA image (p…
c2d99e6 
…roject-chip#18079)

* [OTA] NotifyUpdateApplied to be sent after device first reboot into new image
- Added IsFirstRun and ConfirmCurrentImage checks
- Currently added delay of 15seconds in example_matter to give time for
  ameba to obtain ipv6 address
- TODO: Need to move wlan fast connect into matter using DCT

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
@pankore pankore deleted the ota_related_update branch September 15, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selissia selissia selissia approved these changes

@carol-apple carol-apple carol-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@isiu-apple isiu-apple isiu-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pankore @selissia @carol-apple @bzbarsky-apple @isiu-apple @restyled-commits