Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cluster-specific status APIs on WriteHandler. #18059

Merged
merged 1 commit into from
May 5, 2022
Merged

Implement cluster-specific status APIs on WriteHandler. #18059

merged 1 commit into from
May 5, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Also cleans up the implementation of the equivalent CommandHandler
APIs a bit.

Fixes #9908

Problem

See above.

Change overview

See above.

Testing

No behavior changes; just fixing the API surface for now.

@bzbarsky-apple
Implement cluster-specific status APIs on WriteHandler.
60b8bab 
Also cleans up the implementation of the equivalent CommandHandler
APIs a bit.

Fixes project-chip#9908
@boring-cyborg boring-cyborg bot added the app label May 4, 2022
yunhanw-google
yunhanw-google approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

PR #18059: Size comparison from 9aeecb3 to 60b8bab

Increases (4 builds for cc13x2_26x2)
platform target config section 9aeecb3 60b8bab change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162880 162904 24 0.0
lock-ftd LP_CC2652R7 (read/write) 166244 166268 24 0.0
pump-app LP_CC2652R7 (read/write) 182852 182876 24 0.0
pump-controller-app LP_CC2652R7 (read/write) 189720 189744 24 0.0
Decreases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 9aeecb3 60b8bab change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 689295 -24 -0.0
.text 586708 586684 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 677203 677179 -24 -0.0
.text 582528 582504 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 625947 625923 -24 -0.0
.text 531376 531352 -24 -0.0
pump-app LP_CC2652R7 (read only) 661891 661867 -24 -0.0
.text 581020 580996 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 654823 654799 -24 -0.0
.text 570996 570972 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 626478 -24 -0.0
.app_xip_area 529092 529068 -24 -0.0
lock cyw930739m2evb_01 (read/write) 625214 625190 -24 -0.0
.app_xip_area 529268 529244 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574714 -24 -0.0
.app_xip_area 469076 469052 -24 -0.0
efr32 lighting-app BRD4161A (read only) 909016 908984 -32 -0.0
.text 909008 908976 -32 -0.0
BRD4161A+rpc (read only) 943360 943328 -32 -0.0
.text 943352 943320 -32 -0.0
BRD4161A+rs911x (read only) 747236 747204 -32 -0.0
.text 747228 747196 -32 -0.0
lock-app BRD4161A+wf200 (read only) 916896 916864 -32 -0.0
.text 916888 916856 -32 -0.0
window-app BRD4161A (read only) 846280 846248 -32 -0.0
.text 846272 846240 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1000234 1000208 -26 -0.0
.flash.text 1000234 1000208 -26 -0.0
m5stack (read only) 1055375 1055351 -24 -0.0
.flash.text 1049991 1049967 -24 -0.0
k32w light k32w061+release (read/write) 684496 684464 -32 -0.0
.text 599524 599492 -32 -0.0
lock k32w061+release (read/write) 729176 729144 -32 -0.0
.text 643812 643780 -32 -0.0
linux all-clusters-app debug (read only) 2732841 2732777 -64 -0.0
.text 2323090 2323026 -64 -0.0
bridge-app debug+rpc (read only) 1888177 1888097 -80 -0.0
.text 1605410 1605330 -80 -0.0
chip-tool debug (read only) 8980533 8980469 -64 -0.0
.text 7193477 7193413 -64 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8820308 -96 -0.0
.text 6930292 6930196 -96 -0.0
lighting-app debug+rpc (read only) 2322313 2322217 -96 -0.0
.text 1971490 1971394 -96 -0.0
lock-app debug (read only) 2228513 2228433 -80 -0.0
.text 1874306 1874226 -80 -0.0
ota-provider-app debug (read only) 2058009 2057865 -144 -0.0
.text 1725266 1725122 -144 -0.0
ota-requestor-app debug (read only) 2089065 2088969 -96 -0.0
.text 1758562 1758466 -96 -0.0
shell debug (read only) 2557849 2557785 -64 -0.0
.text 2179714 2179650 -64 -0.0
thermostat-no-ble arm64 (read only) 2363852 2363724 -128 -0.0
.text 1988864 1988736 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1178003 -16 -0.0
text 809064 809040 -24 -0.0
p6 all-clusters-app default (read/write) 2529280 2529248 -32 -0.0
.text 1487544 1487512 -32 -0.0
light-app default (read/write) 2419856 2419824 -32 -0.0
.text 1378120 1378088 -32 -0.0
lock-app default (read/write) 2429136 2429104 -32 -0.0
.text 1387400 1387368 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 804788 -32 -0.0
text 571796 571768 -28 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9aeecb3 60b8bab change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 689295 -24 -0.0
(read/write) 162880 162904 24 0.0
.bss 75180 75180 0 0.0
.data 3412 3412 0 0.0
.rodata 102127 102127 0 0.0
.text 586708 586684 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 677203 677179 -24 -0.0
(read/write) 166244 166268 24 0.0
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94195 94195 0 0.0
.text 582528 582504 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 625947 625923 -24 -0.0
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94083 94083 0 0.0
.text 531376 531352 -24 -0.0
pump-app LP_CC2652R7 (read only) 661891 661867 -24 -0.0
(read/write) 182852 182876 24 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80387 80387 0 0.0
.text 581020 580996 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 654823 654799 -24 -0.0
(read/write) 189720 189744 24 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83343 83343 0 0.0
.text 570996 570972 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 626478 -24 -0.0
.app_xip_area 529092 529068 -24 -0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625214 625190 -24 -0.0
.app_xip_area 529268 529244 -24 -0.0
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574714 -24 -0.0
.app_xip_area 469076 469052 -24 -0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909016 908984 -32 -0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909008 908976 -32 -0.0
BRD4161A+rpc (read only) 943360 943328 -32 -0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 943352 943320 -32 -0.0
BRD4161A+rs911x (read only) 747236 747204 -32 -0.0
(read/write) 128700 128700 0 0.0
.bss 126708 126708 0 0.0
.data 1992 1992 0 0.0
.text 747228 747196 -32 -0.0
lock-app BRD4161A+wf200 (read only) 916896 916864 -32 -0.0
(read/write) 127484 127484 0 0.0
.bss 125532 125532 0 0.0
.data 1948 1948 0 0.0
.text 916888 916856 -32 -0.0
window-app BRD4161A (read only) 846280 846248 -32 -0.0
(read/write) 132608 132608 0 0.0
.bss 130632 130632 0 0.0
.data 1976 1976 0 0.0
.text 846272 846240 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1000234 1000208 -26 -0.0
(read/write) 1474338 1474338 0 0.0
.dram0.bss 68320 68320 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207128 207128 0 0.0
.flash.text 1000234 1000208 -26 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055375 1055351 -24 -0.0
(read/write) 476760 476760 0 0.0
.dram0.bss 73832 73832 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 236908 236908 0 0.0
.flash.text 1049991 1049967 -24 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684496 684464 -32 -0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599524 599492 -32 -0.0
lock k32w061+release (read/write) 729176 729144 -32 -0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 643812 643780 -32 -0.0
linux all-clusters-app debug (read only) 2732841 2732777 -64 -0.0
(read/write) 173432 173432 0 0.0
.bss 83488 83488 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 81752 81752 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235269 235269 0 0.0
.text 2323090 2323026 -64 -0.0
bridge-app debug+rpc (read only) 1888177 1888097 -80 -0.0
(read/write) 120728 120728 0 0.0
.bss 71488 71488 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40408 40408 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160513 160513 0 0.0
.text 1605410 1605330 -80 -0.0
chip-tool debug (read only) 8980533 8980469 -64 -0.0
(read/write) 576720 576720 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546496 546496 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463861 463861 0 0.0
.text 7193477 7193413 -64 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8820308 -96 -0.0
(read/write) 642833 642833 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581760 581760 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431572 431572 0 0.0
.text 6930292 6930196 -96 -0.0
lighting-app debug+rpc (read only) 2322313 2322217 -96 -0.0
(read/write) 151648 151648 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184713 184713 0 0.0
.text 1971490 1971394 -96 -0.0
lock-app debug (read only) 2228513 2228433 -80 -0.0
(read/write) 146264 146264 0 0.0
.bss 72160 72160 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66856 66856 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194449 194449 0 0.0
.text 1874306 1874226 -80 -0.0
ota-provider-app debug (read only) 2058009 2057865 -144 -0.0
(read/write) 139376 139376 0 0.0
.bss 71648 71648 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60200 60200 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175451 175451 0 0.0
.text 1725266 1725122 -144 -0.0
ota-requestor-app debug (read only) 2089065 2088969 -96 -0.0
(read/write) 142184 142184 0 0.0
.bss 72288 72288 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62280 62280 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171724 171724 0 0.0
.text 1758562 1758466 -96 -0.0
shell debug (read only) 2557849 2557785 -64 -0.0
(read/write) 197328 197328 0 0.0
.bss 114216 114216 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76016 76016 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216754 216754 0 0.0
.text 2179714 2179650 -64 -0.0
thermostat-no-ble arm64 (read only) 2363852 2363724 -128 -0.0
(read/write) 174801 174801 0 0.0
.bss 86401 86401 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145980 145980 0 0.0
.text 1988864 1988736 -128 -0.0
tv-app debug (read only) 2844753 2844753 0 0.0
(read/write) 276960 276960 0 0.0
.bss 189432 189432 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217323 217323 0 0.0
.text 2445378 2445378 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418460 2418460 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381060 1381060 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1178003 -16 -0.0
bss 139532 139532 0 0.0
rodata 150692 150692 0 0.0
text 809064 809040 -24 -0.0
p6 all-clusters-app default (read/write) 2529280 2529248 -32 -0.0
.bss 139184 139184 0 0.0
.data 2808 2808 0 0.0
.text 1487544 1487512 -32 -0.0
light-app default (read/write) 2419856 2419824 -32 -0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1378120 1378088 -32 -0.0
lock-app default (read/write) 2429136 2429104 -32 -0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1387368 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 804788 -32 -0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 571796 571768 -28 -0.0

@bzbarsky-apple bzbarsky-apple merged commit dbfeeea into project-chip:master May 5, 2022
@bzbarsky-apple bzbarsky-apple deleted the write-handler-status-APIs branch May 5, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@arkq arkq arkq approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status code handling in IM is a bit broken
3 participants
@bzbarsky-apple @arkq @yunhanw-google