Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample backport: chef wifi fix and RPC improvement #18044

Merged
merged 2 commits into from
May 4, 2022
Merged

Sample backport: chef wifi fix and RPC improvement #18044

merged 2 commits into from
May 4, 2022

Conversation

rochaferraz
Copy link
Contributor

Change overview

  • Added extended RPC support for ESP32 platform
  • Added initialization to platform wifi network commissioning instance

Testing

build successful with ./chef.py -zrcbfi -d lighting-app-wifi -t esp32
commissions with chip-tool, and the descriptor device-list can be read correctly

rochaferraz and others added 2 commits May 4, 2022 10:41
@rochaferraz @mauimauer
@MtTsai @vinitg1 @restyled-commits
Chef - Extended Pigweed RPC support (project-chip#17781)
3c18314 
* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Fix nrfconnect compilation errors (project-chip#17713)

* Fix nrfconnect compilation errors

* Chef: fix arguments for clean build

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Restyled by gn

* Restyled by autopep8

* Restyled by gn

Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
@rochaferraz
fix: added initialization to platform wifi network commissioning inst…
f3c6a49 
…ance (project-chip#17983)

Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964
@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

PR #18044: Size comparison from cfc3595 to f3c6a49

Full report (42 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cfc3595 f3c6a49 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688059 688059 0 0.0
(read/write) 164188 164188 0 0.0
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 101507 101507 0 0.0
.text 586072 586072 0 0.0
lock-ftd LP_CC2652R7 (read only) 688875 688875 0 0.0
(read/write) 154676 154676 0 0.0
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103171 103171 0 0.0
.text 585220 585220 0 0.0
lock-mtd LP_CC2652R7 (read only) 637611 637611 0 0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103051 103051 0 0.0
.text 534068 534068 0 0.0
pump-app LP_CC2652R7 (read only) 661639 661639 0 0.0
(read/write) 183112 183112 0 0.0
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80351 80351 0 0.0
.text 580808 580808 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654575 654575 0 0.0
(read/write) 189968 189968 0 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83383 83383 0 0.0
.text 570712 570712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626918 626918 0 0.0
.app_xip_area 529468 529468 0 0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621518 621518 0 0.0
.app_xip_area 525540 525540 0 0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574634 574634 0 0.0
.app_xip_area 469012 469012 0 0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907760 907760 0 0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907752 907752 0 0.0
BRD4161A+rpc (read only) 942112 942112 0 0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942104 942104 0 0.0
BRD4161A+rs911x (read only) 746076 746076 0 0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746068 746068 0 0.0
lock-app BRD4161A+wf200 (read only) 908780 908780 0 0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908772 908772 0 0.0
window-app BRD4161A (read only) 844952 844952 0 0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 844944 844944 0 0.0
esp32 all-clusters-app c3devkit (read only) 999288 999288 0 0.0
(read/write) 1473778 1473778 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206536 206536 0 0.0
.flash.text 999288 999288 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054687 1054687 0 0.0
(read/write) 476200 476200 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 236316 236316 0 0.0
.flash.text 1049303 1049303 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688788 688788 0 0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599676 599676 0 0.0
lock k32w061+release (read/write) 729648 729648 0 0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640168 640168 0 0.0
linux all-clusters-app debug (read only) 2732729 2732729 0 0.0
(read/write) 172976 172976 0 0.0
.bss 83328 83328 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81560 81560 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234533 234533 0 0.0
.text 2323618 2323618 0 0.0
bridge-app debug+rpc (read only) 1889881 1889881 0 0.0
(read/write) 120336 120336 0 0.0
.bss 71328 71328 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40248 40248 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 160033 160033 0 0.0
.text 1607474 1607474 0 0.0
chip-tool debug (read only) 8422109 8422109 0 0.0
(read/write) 474448 474448 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 444456 444456 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 457301 457301 0 0.0
.text 6879093 6879093 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8276484 8276484 0 0.0
(read/write) 539601 539601 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 479608 479608 0 0.0
.dynamic 560 560 0 0.0
.got 14088 14088 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 423604 423604 0 0.0
.text 6634532 6634532 0 0.0
lighting-app debug+rpc (read only) 2324257 2324257 0 0.0
(read/write) 151288 151288 0 0.0
.bss 73376 73376 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70184 70184 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 184169 184169 0 0.0
.text 1973858 1973858 0 0.0
lock-app debug (read only) 2205289 2205289 0 0.0
(read/write) 145640 145640 0 0.0
.bss 71968 71968 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66520 66520 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192593 192593 0 0.0
.text 1853106 1853106 0 0.0
ota-provider-app debug (read only) 2058777 2058777 0 0.0
(read/write) 138920 138920 0 0.0
.bss 71392 71392 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60072 60072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174651 174651 0 0.0
.text 1727026 1727026 0 0.0
ota-requestor-app debug (read only) 2089897 2089897 0 0.0
(read/write) 141728 141728 0 0.0
.bss 72032 72032 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170924 170924 0 0.0
.text 1760386 1760386 0 0.0
shell debug (read only) 2557873 2557873 0 0.0
(read/write) 197000 197000 0 0.0
.bss 114056 114056 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216306 216306 0 0.0
.text 2180066 2180066 0 0.0
thermostat-no-ble arm64 (read only) 2366892 2366892 0 0.0
(read/write) 174513 174513 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145980 0 0.0
.text 1991856 1991856 0 0.0
tv-app debug (read only) 2842865 2842865 0 0.0
(read/write) 276568 276568 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76432 76432 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216715 216715 0 0.0
.text 2444098 2444098 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411340 2411340 0 0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373940 1373940 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179447 1179447 0 0.0
bss 141992 141992 0 0.0
rodata 150104 150104 0 0.0
text 808660 808660 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156119 1156119 0 0.0
bss 145708 145708 0 0.0
rodata 121816 121816 0 0.0
text 809948 809948 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1120407 1120407 0 0.0
bss 145944 145944 0 0.0
rodata 112928 112928 0 0.0
text 782420 782420 0 0.0
nrf52840dongle_nrf52840 (read/write) 1064079 1064079 0 0.0
bss 152900 152900 0 0.0
rodata 91872 91872 0 0.0
text 738440 738440 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058510 1058510 0 0.0
bss 141912 141912 0 0.0
rodata 114572 114572 0 0.0
text 720060 720060 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093779 1093779 0 0.0
bss 135624 135624 0 0.0
rodata 133612 133612 0 0.0
text 746016 746016 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996494 996494 0 0.0
bss 131860 131860 0 0.0
rodata 126412 126412 0 0.0
text 656268 656268 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076527 1076527 0 0.0
bss 135712 135712 0 0.0
rodata 117328 117328 0 0.0
text 744844 744844 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058111 1058111 0 0.0
bss 135432 135432 0 0.0
rodata 113280 113280 0 0.0
text 730760 730760 0 0.0
p6 all-clusters-app default (read/write) 2526824 2526824 0 0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1485088 1485088 0 0.0
light-app default (read/write) 2418768 2418768 0 0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377032 1377032 0 0.0
lock-app default (read/write) 2422848 2422848 0 0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381112 1381112 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807680 807680 0 0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571416 571416 0 0.0

@andy31415 andy31415 merged commit d7c2dd2 into project-chip:interop_testing_te9 May 4, 2022
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Sep 9, 2022
@rochaferraz @mauimauer
@MtTsai @vinitg1 @restyled-commits @danielsilabs
Sample backport: chef wifi fix and RPC improvement (project-chip#18044)
213d21d 
* Chef - Extended Pigweed RPC support (project-chip#17781)

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Fix nrfconnect compilation errors (project-chip#17713)

* Fix nrfconnect compilation errors

* Chef: fix arguments for clean build

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Restyled by gn

* Restyled by autopep8

* Restyled by gn

Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* fix: added initialization to platform wifi network commissioning instance (project-chip#17983)

Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964

Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rochaferraz @andy31415