Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving android tv-casting-app build issues #18018

Merged
merged 1 commit into from
May 4, 2022
Merged

Resolving android tv-casting-app build issues #18018

merged 1 commit into from
May 4, 2022

Conversation

sharadb-amazon
Copy link
Contributor

@sharadb-amazon sharadb-amazon commented May 3, 2022 •
edited
Loading

Problem

Android tv-casting-app build was failing due to compilation issues with tv-casting-common, related to namespace usage and dependency libraries

Change overview

  1. Moved using namepace * declarations to .cpp instead of .h files as per C++ best practices.
  2. Moved call to DeviceLayer::PersistedStorage::KeyValueStoreMgrImpl().Init(CHIP_CONFIG_KVS_PATH) out of tv-casting-common to tv-casting-app/linux as KeyValueStoreMgrImpl only has platform specific implementations. Calling Init() from KeyValueStoreMgrImpl from tv-casting-common leads to a function not found compilation error.
  3. Reduced dependency lib list for tv-casting-common (examples/platform/linux:app-main, src/credentials:default_attestation_verifier, src/lib, third_party/inipp were not needed).
  4. Removed dependency of android tv-casting-app from libCHIPController as that was not needed.

Testing

  • Built both Linux as well as Android tv-casting-app and ran them successfully.

@boring-cyborg boring-cyborg bot added the scripts label May 3, 2022
@restyled-io restyled-io bot mentioned this pull request May 3, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

PR #18018: Size comparison from caa1d6b to e024487

Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section caa1d6b e024487 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688967 688967 0 0.0
(read/write) 163320 163320 0 0.0
.bss 75268 75268 0 0.0
.data 3404 3404 0 0.0
.rodata 102343 102343 0 0.0
.text 586140 586140 0 0.0
lock-ftd LP_CC2652R7 (read only) 676823 676823 0 0.0
(read/write) 166720 166720 0 0.0
.bss 73580 73580 0 0.0
.data 3228 3228 0 0.0
.rodata 94399 94399 0 0.0
.text 581944 581944 0 0.0
lock-mtd LP_CC2652R7 (read only) 625575 625575 0 0.0
(read/write) 146388 146388 0 0.0
.bss 69300 69300 0 0.0
.data 3228 3228 0 0.0
.rodata 94287 94287 0 0.0
.text 530800 530800 0 0.0
pump-app LP_CC2652R7 (read only) 661387 661387 0 0.0
(read/write) 183396 183396 0 0.0
.bss 73796 73796 0 0.0
.data 3260 3260 0 0.0
.rodata 80451 80451 0 0.0
.text 580452 580452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654283 654283 0 0.0
(read/write) 190300 190300 0 0.0
.bss 73852 73852 0 0.0
.data 3224 3224 0 0.0
.rodata 83395 83395 0 0.0
.text 570404 570404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626218 626218 0 0.0
.app_xip_area 528736 528736 0 0.0
.bss 80132 80132 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 624930 624930 0 0.0
.app_xip_area 528904 528904 0 0.0
.bss 78708 78708 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574050 574050 0 0.0
.app_xip_area 468404 468404 0 0.0
.bss 88032 88032 0 0.0
.data 576 576 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908432 908432 0 0.0
(read/write) 134592 134592 0 0.0
.bss 132536 132536 0 0.0
.data 2056 2056 0 0.0
.text 908424 908424 0 0.0
BRD4161A+rpc (read only) 942792 942792 0 0.0
(read/write) 151280 151280 0 0.0
.bss 149016 149016 0 0.0
.data 2260 2260 0 0.0
.text 942784 942784 0 0.0
BRD4161A+rs911x (read only) 746628 746628 0 0.0
(read/write) 128772 128772 0 0.0
.bss 126788 126788 0 0.0
.data 1984 1984 0 0.0
.text 746620 746620 0 0.0
lock-app BRD4161A+wf200 (read only) 916392 916392 0 0.0
(read/write) 127564 127564 0 0.0
.bss 125620 125620 0 0.0
.data 1940 1940 0 0.0
.text 916384 916384 0 0.0
window-app BRD4161A (read only) 845696 845696 0 0.0
(read/write) 132680 132680 0 0.0
.bss 130712 130712 0 0.0
.data 1968 1968 0 0.0
.text 845688 845688 0 0.0
esp32 all-clusters-app c3devkit (read only) 999538 999538 0 0.0
(read/write) 1474498 1474498 0 0.0
.dram0.bss 68400 68400 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207224 207224 0 0.0
.flash.text 999538 999538 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054727 1054727 0 0.0
(read/write) 476928 476928 0 0.0
.dram0.bss 73920 73920 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 236996 236996 0 0.0
.flash.text 1049343 1049343 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684104 684104 0 0.0
.bss 81336 81336 0 0.0
.data 2012 2012 0 0.0
.text 599052 599052 0 0.0
lock k32w061+release (read/write) 728904 728904 0 0.0
.bss 81760 81760 0 0.0
.data 1972 1972 0 0.0
.text 643468 643468 0 0.0
linux all-clusters-app debug (read only) 2729961 2729961 0 0.0
(read/write) 173144 173144 0 0.0
.bss 83360 83360 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235173 235173 0 0.0
.text 2320162 2320162 0 0.0
bridge-app debug+rpc (read only) 1885025 1885025 0 0.0
(read/write) 120472 120472 0 0.0
.bss 71360 71360 0 0.0
.data 3456 3456 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1602210 1602210 0 0.0
chip-tool debug (read only) 8977653 8977653 0 0.0
(read/write) 576464 576464 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546472 546472 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463733 463733 0 0.0
.text 7190773 7190773 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8817700 8817700 0 0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581752 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431460 431460 0 0.0
.text 6927732 6927732 0 0.0
lighting-app debug+rpc (read only) 2319433 2319433 0 0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184617 184617 0 0.0
.text 1968562 1968562 0 0.0
lock-app debug (read only) 2225649 2225649 0 0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1871394 1871394 0 0.0
ota-provider-app debug (read only) 2054289 2054289 0 0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1722066 1722066 0 0.0
ota-requestor-app debug (read only) 2085345 2085345 0 0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1755362 1755362 0 0.0
shell debug (read only) 2555033 2555033 0 0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2176786 2176786 0 0.0
thermostat-no-ble arm64 (read only) 2360868 2360868 0 0.0
(read/write) 174609 174609 0 0.0
.bss 86289 86289 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145828 145828 0 0.0
.text 1985920 1985920 0 0.0
tv-app debug (read only) 2841633 2841633 0 0.0
(read/write) 276704 276704 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76552 76552 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217259 217259 0 0.0
.text 2442178 2442178 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2417972 2417972 0 0.0
.bss 205900 205900 0 0.0
.data 5864 5864 0 0.0
.text 1380572 1380572 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177523 1177523 0 0.0
bss 139620 139620 0 0.0
rodata 150780 150780 0 0.0
text 808492 808492 0 0.0
p6 all-clusters-app default (read/write) 2528656 2528656 0 0.0
.bss 139272 139272 0 0.0
.data 2800 2800 0 0.0
.text 1486920 1486920 0 0.0
light-app default (read/write) 2419256 2419256 0 0.0
.bss 132736 132736 0 0.0
.data 2600 2600 0 0.0
.text 1377520 1377520 0 0.0
lock-app default (read/write) 2428544 2428544 0 0.0
.bss 132560 132560 0 0.0
.data 2560 2560 0 0.0
.text 1386808 1386808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 804352 804352 0 0.0
bss 72252 72252 0 0.0
noinit 40416 40416 0 0.0
text 571174 571174 0 0.0

@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

PR #18018: Size comparison from caa1d6b to f6dedaf

Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section caa1d6b f6dedaf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688967 688967 0 0.0
(read/write) 163320 163320 0 0.0
.bss 75268 75268 0 0.0
.data 3404 3404 0 0.0
.rodata 102343 102343 0 0.0
.text 586140 586140 0 0.0
lock-ftd LP_CC2652R7 (read only) 676823 676823 0 0.0
(read/write) 166720 166720 0 0.0
.bss 73580 73580 0 0.0
.data 3228 3228 0 0.0
.rodata 94399 94399 0 0.0
.text 581944 581944 0 0.0
lock-mtd LP_CC2652R7 (read only) 625575 625575 0 0.0
(read/write) 146388 146388 0 0.0
.bss 69300 69300 0 0.0
.data 3228 3228 0 0.0
.rodata 94287 94287 0 0.0
.text 530800 530800 0 0.0
pump-app LP_CC2652R7 (read only) 661387 661387 0 0.0
(read/write) 183396 183396 0 0.0
.bss 73796 73796 0 0.0
.data 3260 3260 0 0.0
.rodata 80451 80451 0 0.0
.text 580452 580452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654283 654283 0 0.0
(read/write) 190300 190300 0 0.0
.bss 73852 73852 0 0.0
.data 3224 3224 0 0.0
.rodata 83395 83395 0 0.0
.text 570404 570404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626218 626218 0 0.0
.app_xip_area 528736 528736 0 0.0
.bss 80132 80132 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 624930 624930 0 0.0
.app_xip_area 528904 528904 0 0.0
.bss 78708 78708 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574050 574050 0 0.0
.app_xip_area 468404 468404 0 0.0
.bss 88032 88032 0 0.0
.data 576 576 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908432 908432 0 0.0
(read/write) 134592 134592 0 0.0
.bss 132536 132536 0 0.0
.data 2056 2056 0 0.0
.text 908424 908424 0 0.0
BRD4161A+rpc (read only) 942792 942792 0 0.0
(read/write) 151280 151280 0 0.0
.bss 149016 149016 0 0.0
.data 2260 2260 0 0.0
.text 942784 942784 0 0.0
BRD4161A+rs911x (read only) 746628 746628 0 0.0
(read/write) 128772 128772 0 0.0
.bss 126788 126788 0 0.0
.data 1984 1984 0 0.0
.text 746620 746620 0 0.0
lock-app BRD4161A+wf200 (read only) 916392 916392 0 0.0
(read/write) 127564 127564 0 0.0
.bss 125620 125620 0 0.0
.data 1940 1940 0 0.0
.text 916384 916384 0 0.0
window-app BRD4161A (read only) 845696 845696 0 0.0
(read/write) 132680 132680 0 0.0
.bss 130712 130712 0 0.0
.data 1968 1968 0 0.0
.text 845688 845688 0 0.0
esp32 all-clusters-app c3devkit (read only) 999538 999538 0 0.0
(read/write) 1474498 1474498 0 0.0
.dram0.bss 68400 68400 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207224 207224 0 0.0
.flash.text 999538 999538 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054727 1054727 0 0.0
(read/write) 476928 476928 0 0.0
.dram0.bss 73920 73920 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 236996 236996 0 0.0
.flash.text 1049343 1049343 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684104 684104 0 0.0
.bss 81336 81336 0 0.0
.data 2012 2012 0 0.0
.text 599052 599052 0 0.0
lock k32w061+release (read/write) 728904 728904 0 0.0
.bss 81760 81760 0 0.0
.data 1972 1972 0 0.0
.text 643468 643468 0 0.0
linux all-clusters-app debug (read only) 2729961 2729961 0 0.0
(read/write) 173144 173144 0 0.0
.bss 83360 83360 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235173 235173 0 0.0
.text 2320162 2320162 0 0.0
bridge-app debug+rpc (read only) 1885025 1885025 0 0.0
(read/write) 120472 120472 0 0.0
.bss 71360 71360 0 0.0
.data 3456 3456 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1602210 1602210 0 0.0
chip-tool debug (read only) 8977653 8977653 0 0.0
(read/write) 576464 576464 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546472 546472 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463733 463733 0 0.0
.text 7190773 7190773 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8817700 8817700 0 0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581752 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431460 431460 0 0.0
.text 6927732 6927732 0 0.0
lighting-app debug+rpc (read only) 2319433 2319433 0 0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184617 184617 0 0.0
.text 1968562 1968562 0 0.0
lock-app debug (read only) 2225649 2225649 0 0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1871394 1871394 0 0.0
ota-provider-app debug (read only) 2054289 2054289 0 0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1722066 1722066 0 0.0
ota-requestor-app debug (read only) 2085345 2085345 0 0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1755362 1755362 0 0.0
shell debug (read only) 2555033 2555033 0 0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2176786 2176786 0 0.0
thermostat-no-ble arm64 (read only) 2360868 2360868 0 0.0
(read/write) 174609 174609 0 0.0
.bss 86289 86289 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145828 145828 0 0.0
.text 1985920 1985920 0 0.0
tv-app debug (read only) 2841633 2841633 0 0.0
(read/write) 276704 276704 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76552 76552 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217259 217259 0 0.0
.text 2442178 2442178 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2417972 2417972 0 0.0
.bss 205900 205900 0 0.0
.data 5864 5864 0 0.0
.text 1380572 1380572 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177523 1177523 0 0.0
bss 139620 139620 0 0.0
rodata 150780 150780 0 0.0
text 808492 808492 0 0.0
p6 all-clusters-app default (read/write) 2528656 2528656 0 0.0
.bss 139272 139272 0 0.0
.data 2800 2800 0 0.0
.text 1486920 1486920 0 0.0
light-app default (read/write) 2419256 2419256 0 0.0
.bss 132736 132736 0 0.0
.data 2600 2600 0 0.0
.text 1377520 1377520 0 0.0
lock-app default (read/write) 2428544 2428544 0 0.0
.bss 132560 132560 0 0.0
.data 2560 2560 0 0.0
.text 1386808 1386808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 804352 804352 0 0.0
bss 72252 72252 0 0.0
noinit 40416 40416 0 0.0
text 571174 571174 0 0.0

@chrisdecenzo chrisdecenzo merged commit efca638 into project-chip:master May 4, 2022
@sharadb-amazon sharadb-amazon deleted the droid-20220502 branch June 19, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
examples linux review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharadb-amazon @msandstedt @chrisdecenzo