Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix casting-app error where binding cannot be re-read from storage #17917

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

What is being fixed? Examples:

  • tv-casting-app bindings fail to load at startup

Change overview

  • tv-app uses the wrong value for null cluster field when creating bingings

Testing

test using tv-app and tv-casting-app

@github-actions
Copy link

github-actions bot commented Apr 29, 2022

PR #17917: Size comparison from e4049f2 to 6e08490

Full report (14 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect)
platform target config section e4049f2 6e08490 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626842 0 0.0
.app_xip_area 529392 529392 0 0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621466 621466 0 0.0
.app_xip_area 525488 525488 0 0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574574 0 0.0
.app_xip_area 468952 468952 0 0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907928 907928 0 0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907920 907920 0 0.0
BRD4161A+rpc (read only) 942296 942296 0 0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942288 942288 0 0.0
BRD4161A+rs911x (read only) 746244 746244 0 0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746236 746236 0 0.0
lock-app BRD4161A+wf200 (read only) 908808 908808 0 0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908800 908800 0 0.0
window-app BRD4161A (read only) 845152 845152 0 0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 845144 845144 0 0.0
esp32 all-clusters-app c3devkit (read only) 999918 999918 0 0.0
(read/write) 1474562 1474562 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207320 207320 0 0.0
.flash.text 999918 999918 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055315 1055315 0 0.0
(read/write) 476968 476968 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 237084 237084 0 0.0
.flash.text 1049931 1049931 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684720 684720 0 0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599704 599704 0 0.0
lock k32w061+release (read/write) 725564 725564 0 0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640180 640180 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411340 2411340 0 0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373940 1373940 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180647 0 0.0
bss 141992 141992 0 0.0
rodata 150872 150872 0 0.0
text 809096 809096 0 0.0

@chrisdecenzo chrisdecenzo merged commit 5488e57 into master Apr 30, 2022
@chrisdecenzo chrisdecenzo deleted the tv-apps17 branch April 30, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants