Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Add a command line argument to the all-clusters-app to Configure the minimal commissioning timeout #17911

Merged
merged 1 commit into from
Apr 30, 2022
Merged

[Testing] Add a command line argument to the all-clusters-app to Configure the minimal commissioning timeout #17911

merged 1 commit into from
Apr 30, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

The tests from #17837 are trying to use a delay for the minimum timeout of the commissioning window, which is currently 3 minutes per spec (and worse the test plan states 5 minutes). That is just lost time when it comes to our CI.

Change overview

  • Allow the minimum commissioning timeout of the all-clusters-app to be 1 second.

Testing

The command ./out/debug/standalone/chip-tool administratorcommissioning open-basic-commissioning-window 10 0x12344321 0 --timedInteractionTimeoutMs 1000 fails with an INVALID_COMMAND without this patch.

@vivien-apple vivien-apple self-assigned this Apr 29, 2022
@vivien-apple vivien-apple mentioned this pull request Apr 29, 2022
Merged
@vivien-apple vivien-apple force-pushed the YAML_AllowCommissioningTimeoutToBeConfigured branch from d2426a5 to b1c311a Compare April 29, 2022 15:29
bzbarsky-apple
bzbarsky-apple reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to fail some of our tests, which check that a too-short commissioning window can't be opened....

src/app/server/CommissioningWindowManager.h Outdated Show resolved Hide resolved
@bzbarsky-apple
Copy link
Contributor

More generally, we shouldn't be introducing non-spec-compliant behavior that holds across all tests. If we want it for specific test because it does not actually depend on the spec-compliance, can we figure out a way to do it for just the one test?

For example, could we add a command-line arg for this thing and then restart the app with that arg in the tests that would like a shorter timeout?

@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17911: Size comparison from 917142a to b1c311a

Increases above 0.2%:

platform target config section 917142a b1c311a change % change
efr32 lighting-app BRD4161A+rs911x .data 1972 1976 4 0.2
lock-app BRD4161A+wf200 .data 1920 1924 4 0.2
window-app BRD4161A .data 1956 1960 4 0.2
p6 all-clusters-app default .data 2784 2792 8 0.3
light-app default .data 2584 2592 8 0.3
lock-app default .data 2544 2552 8 0.3
Increases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
platform target config section 917142a b1c311a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689151 689199 48 0.0
.bss 75228 75236 8 0.0
.text 586432 586476 44 0.0
lock-ftd LP_CC2652R7 (read only) 688719 688767 48 0.0
.bss 73588 73596 8 0.0
.text 585068 585120 52 0.0
lock-mtd LP_CC2652R7 (read only) 637471 637511 40 0.0
(read/write) 146388 146396 8 0.0
.bss 69308 69316 8 0.0
.text 533932 533976 44 0.0
pump-app LP_CC2652R7 (read only) 661443 661491 48 0.0
.bss 73764 73772 8 0.0
.text 580648 580692 44 0.0
pump-controller-app LP_CC2652R7 (read only) 654443 654491 48 0.0
.bss 73812 73820 8 0.0
.text 570584 570628 44 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626698 626754 56 0.0
.app_xip_area 529248 529304 56 0.0
lock cyw930739m2evb_01 (read/write) 621298 621354 56 0.0
.app_xip_area 525320 525376 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574414 574478 64 0.0
.app_xip_area 468792 468856 64 0.0
efr32 lighting-app BRD4161A (read only) 907640 907768 128 0.0
(read/write) 135112 135120 8 0.0
.bss 133064 133072 8 0.0
.data 2044 2048 4 0.2
.text 907632 907760 128 0.0
BRD4161A+rpc (read only) 942008 942136 128 0.0
(read/write) 151792 151808 16 0.0
.bss 149544 149552 8 0.0
.data 2248 2252 4 0.2
.text 942000 942128 128 0.0
BRD4161A+rs911x (read only) 745956 746100 144 0.0
(read/write) 129344 129348 4 0.0
.data 1972 1976 4 0.2
.text 745948 746092 144 0.0
lock-app BRD4161A+wf200 (read only) 908648 908696 48 0.0
(read/write) 126300 126308 8 0.0
.data 1920 1924 4 0.2
.text 908640 908688 48 0.0
window-app BRD4161A (read only) 844848 844976 128 0.0
(read/write) 133200 133208 8 0.0
.bss 131240 131248 8 0.0
.data 1956 1960 4 0.2
.text 844840 844968 128 0.0
esp32 all-clusters-app c3devkit (read only) 999716 999754 38 0.0
.flash.text 999716 999754 38 0.0
m5stack (read only) 1055123 1055183 60 0.0
(read/write) 476968 476972 4 0.0
.flash.rodata 237084 237088 4 0.0
.flash.text 1049739 1049799 60 0.0
k32w light k32w061+release (read/write) 684592 684652 60 0.0
.bss 81312 81320 8 0.0
.data 2000 2004 4 0.2
.text 599576 599624 48 0.0
lock k32w061+release (read/write) 725404 725464 60 0.0
.bss 81720 81728 8 0.0
.data 1960 1964 4 0.2
.text 640020 640068 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180503 1180567 64 0.0
bss 141992 141996 4 0.0
text 808956 809008 52 0.0
p6 all-clusters-app default (read/write) 2528080 2528224 144 0.0
.data 2784 2792 8 0.3
.text 1486344 1486488 144 0.0
light-app default (read/write) 2418648 2418792 144 0.0
.data 2584 2592 8 0.3
.text 1376912 1377056 144 0.0
lock-app default (read/write) 2422744 2422872 128 0.0
.data 2544 2552 8 0.3
.text 1381008 1381136 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 807484 807548 64 0.0
bss 75424 75432 8 0.0
text 571226 571278 52 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section 917142a b1c311a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 163096 163056 -40 -0.0
lock-ftd LP_CC2652R7 (read/write) 154832 154792 -40 -0.0
pump-app LP_CC2652R7 (read/write) 183308 183268 -40 -0.0
pump-controller-app LP_CC2652R7 (read/write) 190100 190060 -40 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 917142a b1c311a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689151 689199 48 0.0
(read/write) 163096 163056 -40 -0.0
.bss 75228 75236 8 0.0
.data 3396 3396 0 0.0
.rodata 102239 102239 0 0.0
.text 586432 586476 44 0.0
lock-ftd LP_CC2652R7 (read only) 688719 688767 48 0.0
(read/write) 154832 154792 -40 -0.0
.bss 73588 73596 8 0.0
.data 3220 3220 0 0.0
.rodata 103167 103167 0 0.0
.text 585068 585120 52 0.0
lock-mtd LP_CC2652R7 (read only) 637471 637511 40 0.0
(read/write) 146388 146396 8 0.0
.bss 69308 69316 8 0.0
.data 3220 3220 0 0.0
.rodata 103047 103047 0 0.0
.text 533932 533976 44 0.0
pump-app LP_CC2652R7 (read only) 661443 661491 48 0.0
(read/write) 183308 183268 -40 -0.0
.bss 73764 73772 8 0.0
.data 3252 3252 0 0.0
.rodata 80315 80315 0 0.0
.text 580648 580692 44 0.0
pump-controller-app LP_CC2652R7 (read only) 654443 654491 48 0.0
(read/write) 190100 190060 -40 -0.0
.bss 73812 73820 8 0.0
.data 3216 3216 0 0.0
.rodata 83379 83379 0 0.0
.text 570584 570628 44 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626698 626754 56 0.0
.app_xip_area 529248 529304 56 0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621298 621354 56 0.0
.app_xip_area 525320 525376 56 0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574414 574478 64 0.0
.app_xip_area 468792 468856 64 0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907640 907768 128 0.0
(read/write) 135112 135120 8 0.0
.bss 133064 133072 8 0.0
.data 2044 2048 4 0.2
.text 907632 907760 128 0.0
BRD4161A+rpc (read only) 942008 942136 128 0.0
(read/write) 151792 151808 16 0.0
.bss 149544 149552 8 0.0
.data 2248 2252 4 0.2
.text 942000 942128 128 0.0
BRD4161A+rs911x (read only) 745956 746100 144 0.0
(read/write) 129344 129348 4 0.0
.bss 127372 127372 0 0.0
.data 1972 1976 4 0.2
.text 745948 746092 144 0.0
lock-app BRD4161A+wf200 (read only) 908648 908696 48 0.0
(read/write) 126300 126308 8 0.0
.bss 124380 124380 0 0.0
.data 1920 1924 4 0.2
.text 908640 908688 48 0.0
window-app BRD4161A (read only) 844848 844976 128 0.0
(read/write) 133200 133208 8 0.0
.bss 131240 131248 8 0.0
.data 1956 1960 4 0.2
.text 844840 844968 128 0.0
esp32 all-clusters-app c3devkit (read only) 999716 999754 38 0.0
(read/write) 1474562 1474562 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207320 207320 0 0.0
.flash.text 999716 999754 38 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055123 1055183 60 0.0
(read/write) 476968 476972 4 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 237084 237088 4 0.0
.flash.text 1049739 1049799 60 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684592 684652 60 0.0
.bss 81312 81320 8 0.0
.data 2000 2004 4 0.2
.text 599576 599624 48 0.0
lock k32w061+release (read/write) 725404 725464 60 0.0
.bss 81720 81728 8 0.0
.data 1960 1964 4 0.2
.text 640020 640068 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411212 2411212 0 0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373812 1373812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180503 1180567 64 0.0
bss 141992 141996 4 0.0
rodata 150872 150872 0 0.0
text 808956 809008 52 0.0
p6 all-clusters-app default (read/write) 2528080 2528224 144 0.0
.bss 139248 139248 0 0.0
.data 2784 2792 8 0.3
.text 1486344 1486488 144 0.0
light-app default (read/write) 2418648 2418792 144 0.0
.bss 132720 132720 0 0.0
.data 2584 2592 8 0.3
.text 1376912 1377056 144 0.0
lock-app default (read/write) 2422744 2422872 128 0.0
.bss 132520 132520 0 0.0
.data 2544 2552 8 0.3
.text 1381008 1381136 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 807484 807548 64 0.0
bss 75424 75432 8 0.0
noinit 40416 40416 0 0.0
text 571226 571278 52 0.0

@vivien-apple vivien-apple force-pushed the YAML_AllowCommissioningTimeoutToBeConfigured branch from b1c311a to e08d134 Compare April 29, 2022 17:36
@restyled-io restyled-io bot mentioned this pull request Apr 29, 2022
Closed
@vivien-apple vivien-apple force-pushed the YAML_AllowCommissioningTimeoutToBeConfigured branch from e08d134 to aeeaa7e Compare April 29, 2022 17:37
@vivien-apple
Copy link
Contributor Author

I have updated the patch. It does not launch the all-clusters-app with a commissioning timeout that it not spec-compliant by default.

Now (in an other PR) we need to decide if we want to add an commissioning window timeout to the list of arguments that are allowed when starting an application from YAML, or an other way could be to add a method to TestCluster

Any opinions ?

@vivien-apple vivien-apple force-pushed the YAML_AllowCommissioningTimeoutToBeConfigured branch from aeeaa7e to 40183e1 Compare April 29, 2022 17:46
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17911: Size comparison from e4049f2 to 40183e1

Increases above 0.2%:

platform target config section e4049f2 40183e1 change % change
linux all-clusters-app debug .data 1984 2016 32 1.6
Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section e4049f2 40183e1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689287 689303 16 0.0
.text 586568 586584 16 0.0
lock-ftd LP_CC2652R7 (read only) 688871 688911 40 0.0
.text 585220 585260 40 0.0
lock-mtd LP_CC2652R7 (read only) 637623 637655 32 0.0
.text 534084 534116 32 0.0
pump-app LP_CC2652R7 (read only) 661579 661595 16 0.0
.text 580784 580800 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654595 654627 32 0.0
.text 570736 570768 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626874 32 0.0
.app_xip_area 529392 529424 32 0.0
lock cyw930739m2evb_01 (read/write) 621466 621490 24 0.0
.app_xip_area 525488 525512 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574598 24 0.0
.app_xip_area 468952 468976 24 0.0
efr32 lighting-app BRD4161A (read only) 907928 907976 48 0.0
.text 907920 907968 48 0.0
BRD4161A+rpc (read only) 942296 942344 48 0.0
.text 942288 942336 48 0.0
BRD4161A+rs911x (read only) 746244 746292 48 0.0
.text 746236 746284 48 0.0
lock-app BRD4161A+wf200 (read only) 908808 908840 32 0.0
.text 908800 908832 32 0.0
window-app BRD4161A (read only) 845152 845200 48 0.0
.text 845144 845192 48 0.0
esp32 all-clusters-app c3devkit (read only) 999918 999952 34 0.0
.flash.text 999918 999952 34 0.0
m5stack (read only) 1055315 1055383 68 0.0
.flash.text 1049931 1049999 68 0.0
k32w light k32w061+release (read/write) 684720 684752 32 0.0
.text 599704 599736 32 0.0
lock k32w061+release (read/write) 725564 725596 32 0.0
.text 640180 640212 32 0.0
linux all-clusters-app debug (read only) 2734457 2734961 504 0.0
(read/write) 172944 172976 32 0.0
.data 1984 2016 32 1.6
.rodata 234501 234693 192 0.1
.text 2325426 2325714 288 0.0
bridge-app debug+rpc (read only) 1889753 1889817 64 0.0
.text 1607426 1607490 64 0.0
lighting-app debug+rpc (read only) 2324129 2324193 64 0.0
.text 1973810 1973874 64 0.0
lock-app debug (read only) 2205257 2205305 48 0.0
.text 1853154 1853202 48 0.0
ota-provider-app debug (read only) 2058745 2058777 32 0.0
.text 1727074 1727106 32 0.0
ota-requestor-app debug (read only) 2089865 2089929 64 0.0
.text 1760434 1760498 64 0.0
shell debug (read only) 2559681 2559745 64 0.0
.text 2181954 2182018 64 0.0
thermostat-no-ble arm64 (read only) 2367004 2367052 48 0.0
.text 1992048 1992096 48 0.0
tv-app debug (read only) 2842281 2842345 64 0.0
.text 2443586 2443650 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180679 32 0.0
text 809096 809124 28 0.0
p6 all-clusters-app default (read/write) 2528352 2528416 64 0.0
.text 1486616 1486680 64 0.0
light-app default (read/write) 2418936 2419000 64 0.0
.text 1377200 1377264 64 0.0
lock-app default (read/write) 2423048 2423096 48 0.0
.text 1381312 1381360 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 807660 807684 24 0.0
text 571400 571424 24 0.0
Decreases (5 builds for cc13x2_26x2, mbed)
platform target config section e4049f2 40183e1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162960 162944 -16 -0.0
lock-ftd LP_CC2652R7 (read/write) 154680 154640 -40 -0.0
pump-app LP_CC2652R7 (read/write) 183172 183156 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189948 189916 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2411340 2411188 -152 -0.0
.text 1373940 1373788 -152 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e4049f2 40183e1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689287 689303 16 0.0
(read/write) 162960 162944 -16 -0.0
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 102239 102239 0 0.0
.text 586568 586584 16 0.0
lock-ftd LP_CC2652R7 (read only) 688871 688911 40 0.0
(read/write) 154680 154640 -40 -0.0
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103167 103167 0 0.0
.text 585220 585260 40 0.0
lock-mtd LP_CC2652R7 (read only) 637623 637655 32 0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103047 103047 0 0.0
.text 534084 534116 32 0.0
pump-app LP_CC2652R7 (read only) 661579 661595 16 0.0
(read/write) 183172 183156 -16 -0.0
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80315 80315 0 0.0
.text 580784 580800 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654595 654627 32 0.0
(read/write) 189948 189916 -32 -0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83379 83379 0 0.0
.text 570736 570768 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626874 32 0.0
.app_xip_area 529392 529424 32 0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621466 621490 24 0.0
.app_xip_area 525488 525512 24 0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574598 24 0.0
.app_xip_area 468952 468976 24 0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907928 907976 48 0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907920 907968 48 0.0
BRD4161A+rpc (read only) 942296 942344 48 0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942288 942336 48 0.0
BRD4161A+rs911x (read only) 746244 746292 48 0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746236 746284 48 0.0
lock-app BRD4161A+wf200 (read only) 908808 908840 32 0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908800 908832 32 0.0
window-app BRD4161A (read only) 845152 845200 48 0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 845144 845192 48 0.0
esp32 all-clusters-app c3devkit (read only) 999918 999952 34 0.0
(read/write) 1474562 1474562 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207320 207320 0 0.0
.flash.text 999918 999952 34 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055315 1055383 68 0.0
(read/write) 476968 476968 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 237084 237084 0 0.0
.flash.text 1049931 1049999 68 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684720 684752 32 0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599704 599736 32 0.0
lock k32w061+release (read/write) 725564 725596 32 0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640180 640212 32 0.0
linux all-clusters-app debug (read only) 2734457 2734961 504 0.0
(read/write) 172944 172976 32 0.0
.bss 83328 83328 0 0.0
.data 1984 2016 32 1.6
.data.rel.ro 81544 81544 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234501 234693 192 0.1
.text 2325426 2325714 288 0.0
bridge-app debug+rpc (read only) 1889753 1889817 64 0.0
(read/write) 120304 120304 0 0.0
.bss 71328 71328 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40232 40232 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 160001 160001 0 0.0
.text 1607426 1607490 64 0.0
chip-tool debug (read only) 8850133 8850133 0 0.0
(read/write) 550480 550480 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462517 462517 0 0.0
.text 7124949 7124949 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692404 0 0.0
(read/write) 616289 616289 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429748 429748 0 0.0
.text 6865412 6865412 0 0.0
lighting-app debug+rpc (read only) 2324129 2324193 64 0.0
(read/write) 151256 151256 0 0.0
.bss 73376 73376 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70168 70168 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 184137 184137 0 0.0
.text 1973810 1973874 64 0.0
lock-app debug (read only) 2205257 2205305 48 0.0
(read/write) 145640 145640 0 0.0
.bss 71968 71968 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66504 66504 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192561 192561 0 0.0
.text 1853154 1853202 48 0.0
ota-provider-app debug (read only) 2058745 2058777 32 0.0
(read/write) 138888 138888 0 0.0
.bss 71392 71392 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60056 60056 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174619 174619 0 0.0
.text 1727074 1727106 32 0.0
ota-requestor-app debug (read only) 2089865 2089929 64 0.0
(read/write) 141696 141696 0 0.0
.bss 72032 72032 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62120 62120 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170892 170892 0 0.0
.text 1760434 1760498 64 0.0
shell debug (read only) 2559681 2559745 64 0.0
(read/write) 197000 197000 0 0.0
.bss 114056 114056 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75840 75840 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216274 216274 0 0.0
.text 2181954 2182018 64 0.0
thermostat-no-ble arm64 (read only) 2367004 2367052 48 0.0
(read/write) 174481 174481 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145980 0 0.0
.text 1992048 1992096 48 0.0
tv-app debug (read only) 2842281 2842345 64 0.0
(read/write) 276536 276536 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76408 76408 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216715 216715 0 0.0
.text 2443586 2443650 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411340 2411188 -152 -0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373940 1373788 -152 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180679 32 0.0
bss 141992 141992 0 0.0
rodata 150872 150872 0 0.0
text 809096 809124 28 0.0
p6 all-clusters-app default (read/write) 2528352 2528416 64 0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1486616 1486680 64 0.0
light-app default (read/write) 2418936 2419000 64 0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377200 1377264 64 0.0
lock-app default (read/write) 2423048 2423096 48 0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381312 1381360 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 807660 807684 24 0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571400 571424 24 0.0

woody-apple
woody-apple approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given this is unblocking testing.

bzbarsky-apple
bzbarsky-apple approved these changes Apr 29, 2022
View reviewed changes
src/app/server/CommissioningWindowManager.h Outdated Show resolved Hide resolved
src/app/server/CommissioningWindowManager.h Outdated Show resolved Hide resolved
@bzbarsky-apple
Copy link
Contributor

For the followup: I think just passing this arg via yaml when doing a Start would make a lot of sense...

@vivien-apple vivien-apple force-pushed the YAML_AllowCommissioningTimeoutToBeConfigured branch from 40183e1 to 8cd929c Compare April 30, 2022 09:45
@vivien-apple vivien-apple changed the title [Testing] Configure the minimal commissioning timeout to be 1 second [Testing] Add a command line argument to the all-clusters-app to Configure the minimal commissioning timeout Apr 30, 2022
@github-actions
Copy link

github-actions bot commented Apr 30, 2022 •
edited
Loading

PR #17911: Size comparison from df644b2 to 8cd929c

Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section df644b2 8cd929c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688879 688903 24 0.0
.text 586092 586116 24 0.0
lock-ftd LP_CC2652R7 (read only) 676735 676767 32 0.0
.text 581896 581928 32 0.0
lock-mtd LP_CC2652R7 (read only) 625487 625527 40 0.0
.text 530752 530792 40 0.0
pump-app LP_CC2652R7 (read only) 661227 661267 40 0.0
.text 580356 580396 40 0.0
pump-controller-app LP_CC2652R7 (read only) 654123 654155 32 0.0
.text 570316 570348 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626322 626354 32 0.0
.app_xip_area 528856 528888 32 0.0
lock cyw930739m2evb_01 (read/write) 625026 625066 40 0.0
.app_xip_area 529024 529064 40 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574170 574194 24 0.0
.app_xip_area 468548 468572 24 0.0
efr32 lighting-app BRD4161A (read only) 908168 908216 48 0.0
.text 908160 908208 48 0.0
BRD4161A+rpc (read only) 942512 942560 48 0.0
.text 942504 942552 48 0.0
BRD4161A+rs911x (read only) 746468 746516 48 0.0
.text 746460 746508 48 0.0
lock-app BRD4161A+wf200 (read only) 916480 916512 32 0.0
.text 916472 916504 32 0.0
window-app BRD4161A (read only) 845416 845464 48 0.0
.text 845408 845456 48 0.0
esp32 all-clusters-app c3devkit (read only) 999570 999604 34 0.0
.flash.text 999570 999604 34 0.0
m5stack (read only) 1054731 1054795 64 0.0
.flash.text 1049347 1049411 64 0.0
k32w light k32w061+release (read/write) 684204 684236 32 0.0
.text 599172 599204 32 0.0
lock k32w061+release (read/write) 729100 729132 32 0.0
.text 643684 643716 32 0.0
linux thermostat-no-ble arm64 (read only) 2360948 2360980 32 0.0
.text 1986048 1986080 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180075 1180107 32 0.0
text 808588 808620 32 0.0
p6 all-clusters-app default (read/write) 2528512 2528576 64 0.0
.text 1486776 1486840 64 0.0
light-app default (read/write) 2419112 2419176 64 0.0
.text 1377376 1377440 64 0.0
lock-app default (read/write) 2428384 2428448 64 0.0
.text 1386648 1386712 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 807324 807348 24 0.0
text 571118 571142 24 0.0
Decreases (5 builds for cc13x2_26x2, mbed)
platform target config section df644b2 8cd929c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 163376 163352 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 166776 166744 -32 -0.0
pump-app LP_CC2652R7 (read/write) 183524 183484 -40 -0.0
pump-controller-app LP_CC2652R7 (read/write) 190428 190396 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418140 2418060 -80 -0.0
.text 1380740 1380660 -80 -0.0
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section df644b2 8cd929c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688879 688903 24 0.0
(read/write) 163376 163352 -24 -0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586092 586116 24 0.0
lock-ftd LP_CC2652R7 (read only) 676735 676767 32 0.0
(read/write) 166776 166744 -32 -0.0
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 581896 581928 32 0.0
lock-mtd LP_CC2652R7 (read only) 625487 625527 40 0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 530752 530792 40 0.0
pump-app LP_CC2652R7 (read only) 661227 661267 40 0.0
(read/write) 183524 183484 -40 -0.0
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80387 80387 0 0.0
.text 580356 580396 40 0.0
pump-controller-app LP_CC2652R7 (read only) 654123 654155 32 0.0
(read/write) 190428 190396 -32 -0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83323 83323 0 0.0
.text 570316 570348 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626322 626354 32 0.0
.app_xip_area 528856 528888 32 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625026 625066 40 0.0
.app_xip_area 529024 529064 40 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574170 574194 24 0.0
.app_xip_area 468548 468572 24 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908168 908216 48 0.0
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908160 908208 48 0.0
BRD4161A+rpc (read only) 942512 942560 48 0.0
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 942504 942552 48 0.0
BRD4161A+rs911x (read only) 746468 746516 48 0.0
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 746460 746508 48 0.0
lock-app BRD4161A+wf200 (read only) 916480 916512 32 0.0
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 916472 916504 32 0.0
window-app BRD4161A (read only) 845416 845464 48 0.0
(read/write) 133216 133216 0 0.0
.bss 131248 131248 0 0.0
.data 1964 1964 0 0.0
.text 845408 845456 48 0.0
esp32 all-clusters-app c3devkit (read only) 999570 999604 34 0.0
(read/write) 1474506 1474506 0 0.0
.dram0.bss 68376 68376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207248 207248 0 0.0
.flash.text 999570 999604 34 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054731 1054795 64 0.0
(read/write) 476936 476936 0 0.0
.dram0.bss 73896 73896 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 237028 237028 0 0.0
.flash.text 1049347 1049411 64 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684204 684236 32 0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599172 599204 32 0.0
lock k32w061+release (read/write) 729100 729132 32 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 643684 643716 32 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8692244 8692244 0 0.0
(read/write) 616305 616305 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429748 429748 0 0.0
.text 6865252 6865252 0 0.0
thermostat-no-ble arm64 (read only) 2360948 2360980 32 0.0
(read/write) 174593 174593 0 0.0
.bss 86273 86273 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145748 145748 0 0.0
.text 1986048 1986080 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418140 2418060 -80 -0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1380740 1380660 -80 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180075 1180107 32 0.0
bss 142000 142000 0 0.0
rodata 150804 150804 0 0.0
text 808588 808620 32 0.0
p6 all-clusters-app default (read/write) 2528512 2528576 64 0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1486776 1486840 64 0.0
light-app default (read/write) 2419112 2419176 64 0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1377376 1377440 64 0.0
lock-app default (read/write) 2428384 2428448 64 0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1386648 1386712 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 807324 807348 24 0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571118 571142 24 0.0

@vivien-apple vivien-apple merged commit d2cb68c into project-chip:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees

@vivien-apple vivien-apple

Labels
app examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @bzbarsky-apple @tcarmelveilleux @woody-apple