Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PairingSession from transport/ to protocols/secure_channel/ #17889

Merged
merged 2 commits into from
May 5, 2022
Merged

Move PairingSession from transport/ to protocols/secure_channel/ #17889

merged 2 commits into from
May 5, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Apr 29, 2022 •
edited
Loading

Problem

Originally NewPairing in SessionManager depends on PairingSession class, but we have moved it into PASE/CASE session. So there is nothing depends on PairingSession in transport layer. We should move it into protocols.

By doing this, allowing PairingSession depends on messaging layer, such that we can pull up some methods and fields to it, to save code space.

Change overview

  • Move PairingSession from transport/ to protocols/secure_channel/
  • Pull up method Finish/AbortExchange/CloseExchange/DiscardExchange
  • Pull up member mDelegate/mExchangeCtxt

Only refactor, no actual change. Calling AbortExchange and DiscardExchange for error path is changed according to comment #17889 (comment)

Testing

Passed unit-tests

@restyled-io restyled-io bot mentioned this pull request Apr 29, 2022
Closed
@kghost kghost mentioned this pull request Apr 29, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17889: Size comparison from 6672d6e to 84d44c2

Increases (16 builds for cc13x2_26x2, linux)
platform target config section 6672d6e 84d44c25 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 164268 164452 184 0.1
lock-ftd LP_CC2652R7 (read/write) 154756 154944 188 0.1
.rodata 103171 103175 4 0.0
lock-mtd LP_CC2652R7 .rodata 103051 103055 4 0.0
pump-app LP_CC2652R7 (read/write) 183192 183372 180 0.1
.rodata 80351 80355 4 0.0
pump-controller-app LP_CC2652R7 (read/write) 190032 190220 188 0.1
.rodata 83383 83387 4 0.0
linux all-clusters-app debug .rodata 234501 234629 128 0.1
bridge-app debug+rpc .rodata 160001 160097 96 0.1
chip-tool debug .rodata 462517 462629 112 0.0
chip-tool-no-interactive-ipv6only arm64 .rodata 429764 429796 32 0.0
lighting-app debug+rpc .rodata 184137 184217 80 0.0
lock-app debug .rodata 192561 192649 88 0.0
ota-provider-app debug .rodata 174619 174675 56 0.0
ota-requestor-app debug .rodata 170892 171004 112 0.1
shell debug .rodata 216274 216338 64 0.0
thermostat-no-ble arm64 .rodata 145980 146012 32 0.0
tv-app debug .rodata 216683 216811 128 0.1
Decreases (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6672d6e 84d44c25 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687795 -184 -0.0
.text 585992 585808 -184 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688607 -188 -0.0
.text 585140 584948 -192 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637359 -180 -0.0
.text 533996 533812 -184 -0.0
pump-app LP_CC2652R7 (read only) 661559 661379 -180 -0.0
.text 580728 580544 -184 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654323 -188 -0.0
.text 570648 570456 -192 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626582 -192 -0.0
.app_xip_area 529324 529132 -192 -0.0
lock cyw930739m2evb_01 (read/write) 621374 621190 -184 -0.0
.app_xip_area 525396 525212 -184 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574306 -176 -0.0
.app_xip_area 468860 468684 -176 -0.0
efr32 lighting-app BRD4161A (read only) 907744 907520 -224 -0.0
.text 907736 907512 -224 -0.0
BRD4161A+rpc (read only) 942112 941888 -224 -0.0
.text 942104 941880 -224 -0.0
BRD4161A+rs911x (read only) 746060 745820 -240 -0.0
.text 746052 745812 -240 -0.0
lock-app BRD4161A+wf200 (read only) 908716 908528 -188 -0.0
.text 908708 908520 -188 -0.0
window-app BRD4161A (read only) 844952 844728 -224 -0.0
.text 844944 844720 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 999188 998970 -218 -0.0
.flash.text 999188 998970 -218 -0.0
m5stack (read only) 1054623 1054367 -256 -0.0
(read/write) 476200 476192 -8 -0.0
.flash.rodata 236316 236308 -8 -0.0
.flash.text 1049239 1048983 -256 -0.0
k32w light k32w061+release (read/write) 688756 688564 -192 -0.0
.text 599644 599452 -192 -0.0
lock k32w061+release (read/write) 729568 729376 -192 -0.0
.text 640088 639896 -192 -0.0
linux all-clusters-app debug (read only) 2732633 2732265 -368 -0.0
.text 2323554 2323058 -496 -0.0
bridge-app debug+rpc (read only) 1889785 1889385 -400 -0.0
.text 1607410 1606914 -496 -0.0
chip-tool debug (read only) 8850245 8849845 -400 -0.0
.text 7125013 7124501 -512 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692148 -256 -0.0
.text 6865332 6865044 -288 -0.0
lighting-app debug+rpc (read only) 2324161 2323729 -432 -0.0
.text 1973794 1973282 -512 -0.0
lock-app debug (read only) 2205193 2204785 -408 -0.0
.text 1853042 1852546 -496 -0.0
ota-provider-app debug (read only) 2058697 2058257 -440 -0.0
.text 1726978 1726482 -496 -0.0
ota-requestor-app debug (read only) 2089817 2089433 -384 -0.0
.text 1760338 1759842 -496 -0.0
shell debug (read only) 2557777 2557345 -432 -0.0
.text 2180002 2179506 -496 -0.0
thermostat-no-ble arm64 (read only) 2366924 2366668 -256 -0.0
.text 1991888 1991600 -288 -0.0
tv-app debug (read only) 2842769 2842385 -384 -0.0
.text 2444034 2443522 -512 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2411276 2411100 -176 -0.0
.text 1373876 1373700 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179303 1179111 -192 -0.0
text 808516 808336 -180 -0.0
p6 all-clusters-app default (read/write) 2526824 2526600 -224 -0.0
.text 1485088 1484864 -224 -0.0
light-app default (read/write) 2418752 2418528 -224 -0.0
.text 1377016 1376792 -224 -0.0
lock-app default (read/write) 2422832 2422608 -224 -0.0
.text 1381096 1380872 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807560 807352 -208 -0.0
text 571296 571092 -204 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6672d6e 84d44c25 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687795 -184 -0.0
(read/write) 164268 164452 184 0.1
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 101507 101507 0 0.0
.text 585992 585808 -184 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688607 -188 -0.0
(read/write) 154756 154944 188 0.1
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103171 103175 4 0.0
.text 585140 584948 -192 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637359 -180 -0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103051 103055 4 0.0
.text 533996 533812 -184 -0.0
pump-app LP_CC2652R7 (read only) 661559 661379 -180 -0.0
(read/write) 183192 183372 180 0.1
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80351 80355 4 0.0
.text 580728 580544 -184 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654323 -188 -0.0
(read/write) 190032 190220 188 0.1
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83383 83387 4 0.0
.text 570648 570456 -192 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626582 -192 -0.0
.app_xip_area 529324 529132 -192 -0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621374 621190 -184 -0.0
.app_xip_area 525396 525212 -184 -0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574306 -176 -0.0
.app_xip_area 468860 468684 -176 -0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907744 907520 -224 -0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907736 907512 -224 -0.0
BRD4161A+rpc (read only) 942112 941888 -224 -0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942104 941880 -224 -0.0
BRD4161A+rs911x (read only) 746060 745820 -240 -0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746052 745812 -240 -0.0
lock-app BRD4161A+wf200 (read only) 908716 908528 -188 -0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908708 908520 -188 -0.0
window-app BRD4161A (read only) 844952 844728 -224 -0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 844944 844720 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 999188 998970 -218 -0.0
(read/write) 1473778 1473778 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206536 206536 0 0.0
.flash.text 999188 998970 -218 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054623 1054367 -256 -0.0
(read/write) 476200 476192 -8 -0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 236316 236308 -8 -0.0
.flash.text 1049239 1048983 -256 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688756 688564 -192 -0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599644 599452 -192 -0.0
lock k32w061+release (read/write) 729568 729376 -192 -0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640088 639896 -192 -0.0
linux all-clusters-app debug (read only) 2732633 2732265 -368 -0.0
(read/write) 172976 172976 0 0.0
.bss 83328 83328 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81560 81560 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234501 234629 128 0.1
.text 2323554 2323058 -496 -0.0
bridge-app debug+rpc (read only) 1889785 1889385 -400 -0.0
(read/write) 120336 120336 0 0.0
.bss 71328 71328 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40248 40248 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 160001 160097 96 0.1
.text 1607410 1606914 -496 -0.0
chip-tool debug (read only) 8850245 8849845 -400 -0.0
(read/write) 550480 550480 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520504 520504 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462517 462629 112 0.0
.text 7125013 7124501 -512 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692148 -256 -0.0
(read/write) 616321 616321 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555664 555664 0 0.0
.dynamic 560 560 0 0.0
.got 14744 14744 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429764 429796 32 0.0
.text 6865332 6865044 -288 -0.0
lighting-app debug+rpc (read only) 2324161 2323729 -432 -0.0
(read/write) 151288 151288 0 0.0
.bss 73376 73376 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70184 70184 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 184137 184217 80 0.0
.text 1973794 1973282 -512 -0.0
lock-app debug (read only) 2205193 2204785 -408 -0.0
(read/write) 145640 145640 0 0.0
.bss 71968 71968 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66520 66520 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192561 192649 88 0.0
.text 1853042 1852546 -496 -0.0
ota-provider-app debug (read only) 2058697 2058257 -440 -0.0
(read/write) 138920 138920 0 0.0
.bss 71392 71392 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60072 60072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174619 174675 56 0.0
.text 1726978 1726482 -496 -0.0
ota-requestor-app debug (read only) 2089817 2089433 -384 -0.0
(read/write) 141728 141728 0 0.0
.bss 72032 72032 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170892 171004 112 0.1
.text 1760338 1759842 -496 -0.0
shell debug (read only) 2557777 2557345 -432 -0.0
(read/write) 197000 197000 0 0.0
.bss 114056 114056 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216274 216338 64 0.0
.text 2180002 2179506 -496 -0.0
thermostat-no-ble arm64 (read only) 2366924 2366668 -256 -0.0
(read/write) 174513 174513 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 146012 32 0.0
.text 1991888 1991600 -288 -0.0
tv-app debug (read only) 2842769 2842385 -384 -0.0
(read/write) 276568 276568 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76432 76432 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216683 216811 128 0.1
.text 2444034 2443522 -512 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411276 2411100 -176 -0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373876 1373700 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179303 1179111 -192 -0.0
bss 141992 141992 0 0.0
rodata 150104 150104 0 0.0
text 808516 808336 -180 -0.0
p6 all-clusters-app default (read/write) 2526824 2526600 -224 -0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1485088 1484864 -224 -0.0
light-app default (read/write) 2418752 2418528 -224 -0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377016 1376792 -224 -0.0
lock-app default (read/write) 2422832 2422608 -224 -0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381096 1380872 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807560 807352 -208 -0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571296 571092 -204 -0.0

@pullapprove pullapprove bot requested review from tcarmelveilleux and removed request for cecille May 4, 2022 16:07
@restyled-io restyled-io bot mentioned this pull request May 5, 2022
Closed
@kghost kghost force-pushed the session-8 branch 2 times, most recently from 8b74520 to dae9409 Compare May 5, 2022 11:41
@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

PR #17889: Size comparison from 5a61cdd to 56814ae

Increases (7 builds for cc13x2_26x2, esp32, linux)
platform target config section 5a61cdd 56814ae change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161780 162020 240 0.1
lock-ftd LP_CC2652R7 (read/write) 165280 165512 232 0.1
pump-app LP_CC2652R7 (read/write) 182072 182292 220 0.1
.rodata 80887 80891 4 0.0
pump-controller-app LP_CC2652R7 (read/write) 188948 189168 220 0.1
.rodata 83843 83847 4 0.0
esp32 all-clusters-app m5stack (read/write) 477672 477680 8 0.0
.flash.rodata 237676 237684 8 0.0
linux chip-tool-no-interactive-ipv6only arm64 .rodata 431748 431780 32 0.0
thermostat-no-ble arm64 .rodata 146476 146508 32 0.0
Decreases (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5a61cdd 56814ae change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690563 690323 -240 -0.0
.text 587180 586940 -240 -0.0
lock-ftd LP_CC2652R7 (read only) 678167 677935 -232 -0.0
.text 582992 582760 -232 -0.0
lock-mtd LP_CC2652R7 (read only) 626911 626687 -224 -0.0
.text 531840 531616 -224 -0.0
pump-app LP_CC2652R7 (read only) 662671 662451 -220 -0.0
.text 581300 581076 -224 -0.0
pump-controller-app LP_CC2652R7 (read only) 655595 655375 -220 -0.0
.text 571268 571044 -224 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627274 627050 -224 -0.0
.app_xip_area 529864 529640 -224 -0.0
lock cyw930739m2evb_01 (read/write) 626178 625954 -224 -0.0
.app_xip_area 530232 530008 -224 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574962 574746 -216 -0.0
.app_xip_area 469300 469084 -216 -0.0
efr32 lighting-app BRD4161A (read only) 910016 909776 -240 -0.0
.text 910008 909768 -240 -0.0
BRD4161A+rpc (read only) 944360 944120 -240 -0.0
.text 944352 944112 -240 -0.0
BRD4161A+rs911x (read only) 748204 747964 -240 -0.0
.text 748196 747956 -240 -0.0
lock-app BRD4161A+wf200 (read only) 917872 917668 -204 -0.0
(read/write) 127484 127480 -4 -0.0
.text 917864 917660 -204 -0.0
window-app BRD4161A (read only) 847256 847032 -224 -0.0
.text 847248 847024 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 1000802 1000514 -288 -0.0
.flash.text 1000802 1000514 -288 -0.0
m5stack (read only) 1055831 1055535 -296 -0.0
.flash.text 1050447 1050151 -296 -0.0
k32w light k32w061+release (read/write) 684800 684576 -224 -0.0
.text 599828 599604 -224 -0.0
lock k32w061+release (read/write) 730156 729916 -240 -0.0
.text 644792 644552 -240 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8820484 8820100 -384 -0.0
.text 6929796 6929380 -416 -0.0
thermostat-no-ble arm64 (read only) 2366220 2365836 -384 -0.0
.text 1990336 1989920 -416 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2419300 2419124 -176 -0.0
.text 1381900 1381724 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179379 1179171 -208 -0.0
text 809532 809316 -216 -0.0
p6 all-clusters-app default (read/write) 2530752 2530512 -240 -0.0
.text 1489016 1488776 -240 -0.0
light-app default (read/write) 2420816 2420592 -224 -0.0
.text 1379080 1378856 -224 -0.0
lock-app default (read/write) 2430320 2430096 -224 -0.0
.text 1388584 1388360 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 805704 805432 -272 -0.0
text 572178 571910 -268 -0.0
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5a61cdd 56814ae change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690563 690323 -240 -0.0
(read/write) 161780 162020 240 0.1
.bss 75324 75324 0 0.0
.data 3412 3412 0 0.0
.rodata 102899 102899 0 0.0
.text 587180 586940 -240 -0.0
lock-ftd LP_CC2652R7 (read only) 678167 677935 -232 -0.0
(read/write) 165280 165512 232 0.1
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94695 94695 0 0.0
.text 582992 582760 -232 -0.0
lock-mtd LP_CC2652R7 (read only) 626911 626687 -224 -0.0
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94583 94583 0 0.0
.text 531840 531616 -224 -0.0
pump-app LP_CC2652R7 (read only) 662671 662451 -220 -0.0
(read/write) 182072 182292 220 0.1
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80887 80891 4 0.0
.text 581300 581076 -224 -0.0
pump-controller-app LP_CC2652R7 (read only) 655595 655375 -220 -0.0
(read/write) 188948 189168 220 0.1
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83843 83847 4 0.0
.text 571268 571044 -224 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627274 627050 -224 -0.0
.app_xip_area 529864 529640 -224 -0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626178 625954 -224 -0.0
.app_xip_area 530232 530008 -224 -0.0
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574962 574746 -216 -0.0
.app_xip_area 469300 469084 -216 -0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910016 909776 -240 -0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910008 909768 -240 -0.0
BRD4161A+rpc (read only) 944360 944120 -240 -0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944352 944112 -240 -0.0
BRD4161A+rs911x (read only) 748204 747964 -240 -0.0
(read/write) 128700 128700 0 0.0
.bss 126708 126708 0 0.0
.data 1992 1992 0 0.0
.text 748196 747956 -240 -0.0
lock-app BRD4161A+wf200 (read only) 917872 917668 -204 -0.0
(read/write) 127484 127480 -4 -0.0
.bss 125532 125532 0 0.0
.data 1948 1948 0 0.0
.text 917864 917660 -204 -0.0
window-app BRD4161A (read only) 847256 847032 -224 -0.0
(read/write) 132608 132608 0 0.0
.bss 130632 130632 0 0.0
.data 1976 1976 0 0.0
.text 847248 847024 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 1000802 1000514 -288 -0.0
(read/write) 1475258 1475258 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207904 207904 0 0.0
.flash.text 1000802 1000514 -288 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055831 1055535 -296 -0.0
(read/write) 477672 477680 8 0.0
.dram0.bss 73976 73976 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 237676 237684 8 0.0
.flash.text 1050447 1050151 -296 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684800 684576 -224 -0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599828 599604 -224 -0.0
lock k32w061+release (read/write) 730156 729916 -240 -0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 644792 644552 -240 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8820484 8820100 -384 -0.0
(read/write) 643025 643025 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581936 581936 0 0.0
.dynamic 560 560 0 0.0
.got 14968 14968 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431748 431780 32 0.0
.text 6929796 6929380 -416 -0.0
thermostat-no-ble arm64 (read only) 2366220 2365836 -384 -0.0
(read/write) 174993 174993 0 0.0
.bss 86401 86401 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79272 79272 0 0.0
.dynamic 560 560 0 0.0
.got 4760 4760 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146476 146508 32 0.0
.text 1990336 1989920 -416 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419300 2419124 -176 -0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381900 1381724 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179379 1179171 -208 -0.0
bss 139676 139676 0 0.0
rodata 151460 151460 0 0.0
text 809532 809316 -216 -0.0
p6 all-clusters-app default (read/write) 2530752 2530512 -240 -0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489016 1488776 -240 -0.0
light-app default (read/write) 2420816 2420592 -224 -0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1379080 1378856 -224 -0.0
lock-app default (read/write) 2430320 2430096 -224 -0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1388584 1388360 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 805704 805432 -272 -0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 572178 571910 -268 -0.0

@kghost kghost merged commit 498be03 into project-chip:master May 5, 2022
@kghost kghost deleted the session-8 branch May 5, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
review - approved scripts transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kghost @msandstedt @woody-apple @bzbarsky-apple