-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more event tests #17851
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/add_more_event_tests
Apr 29, 2022
Merged
add more event tests #17851
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/add_more_event_tests
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
robszewczyk
April 28, 2022 18:22
pullapprove
bot
requested review from
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
April 28, 2022 18:22
-- Add event wildcard test where we fetch event path with wildcard, expect to receive all events, and extend this test with event list -- Add event list test where we fetch event list without wildcard, and expect to recieve all events for those interested paths.
yunhanw-google
force-pushed
the
feature/add_more_event_tests
branch
from
April 28, 2022 18:24
d274daf
to
f0255a0
Compare
PR #17851: Size comparison from 6d67737 to f0255a0 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yufengwangca
approved these changes
Apr 28, 2022
bzbarsky-apple
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need more unit tests for events.
Change overview
-- Add event wildcard test where we fetch event path with wildcard, expect to receive all events, and extend this test with event list
-- Add event list test where we fetch event list without wildcard, and expect to receive all events for those interested paths.
Testing
See above